From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: radu.sabau@analog.com
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Alexandru Ardelean" <alexandru.ardelean@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/6] iio: imu: Add driver for the ADI ADIS16607
Date: Mon, 12 Oct 2026 14:45:52 +0200 [thread overview]
Message-ID: <aszWHiDLbNZIQz3J@monoceros> (raw)
In-Reply-To: <20261008-adis16607-v2-3-7c94df80878a@analog.com>
[-- Attachment #1: Type: text/plain, Size: 539 bytes --]
On Thu, Oct 08, 2026 at 11:31:55AM +0300, Radu Sabau via B4 Relay wrote:
> +#include <linux/mod_devicetable.h>
Please drop this header. <linux/spi/spi.h> already provides the needed
*_device_id structs.
> +static const struct spi_device_id adis16607_id[] = {
> + { "adis16607-2", (kernel_ulong_t)&adis16607_2_chip_info },
> + { "adis16607-3", (kernel_ulong_t)&adis16607_3_chip_info },
Please use named initializers here (i.e.
{ .name = "adis16607-2", .driver_data = (kernel_ulong_t)&adis16607_2_chip_info },
...
)
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-10-12 12:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 8:31 [PATCH v2 0/6] iio: imu: Add support for the ADI ADIS16607 Radu Sabau via B4 Relay
2026-10-08 8:31 ` Radu Sabau
2026-10-08 8:31 ` [PATCH v2 1/6] iio: imu: adis: Add optional self_test callback and fix custom reset dispatch Radu Sabau via B4 Relay
2026-10-08 8:31 ` Radu Sabau
2026-10-08 8:45 ` sashiko-bot
2026-10-08 8:31 ` [PATCH v2 2/6] dt-bindings: iio: imu: Add bindings for ADI ADIS16607 Radu Sabau via B4 Relay
2026-10-08 8:31 ` Radu Sabau
2026-10-08 8:37 ` sashiko-bot
2026-10-08 10:14 ` Conor Dooley
2026-10-08 8:31 ` [PATCH v2 3/6] iio: imu: Add driver for the " Radu Sabau via B4 Relay
2026-10-08 8:31 ` Radu Sabau
2026-10-12 12:45 ` Uwe Kleine-König [this message]
2026-10-08 8:31 ` [PATCH v2 4/6] iio: imu: adis16607: Add FIFO-based buffered/triggered capture Radu Sabau via B4 Relay
2026-10-08 8:31 ` Radu Sabau
2026-10-08 8:45 ` sashiko-bot
2026-10-08 8:31 ` [PATCH v2 5/6] iio: imu: adis16607: Add external clock sync support Radu Sabau via B4 Relay
2026-10-08 8:31 ` Radu Sabau
2026-10-08 8:42 ` sashiko-bot
2026-10-08 8:31 ` [PATCH v2 6/6] iio: imu: adis16607: Add calibration bias support for gyro/accel Radu Sabau via B4 Relay
2026-10-08 8:31 ` Radu Sabau
2026-10-08 8:43 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aszWHiDLbNZIQz3J@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.ardelean@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=radu.sabau@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.