From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D21AACA9ED0 for ; Mon, 12 Oct 2026 13:19:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kUEbgK9u7AqwWb0kpz5ZCTNvCFOmowv2E2RTx2pAUbA=; b=Lc6jkPmgBvbSh+ y6oNSoIY4WAs/fZqVQZHSBIlxPggZVBSipG8dVTx1ylp3R2TVoxkjraSJ6Hb0FUxHhs6IsSyIAb1K V2nGKNe7vkRgtCHx4YgvA5IyJCwBxt+FrDGxarQAgz2qgWnWv5Nx9xvkHjNVfXy+Vyzs3yvFDQGRn CTxJ33ycfEgGp3kJPoSDwx+hka7/ZwUpxB2QhFVMN2wZxSzJ8blFv4uPHOWh0U03RB4FeymfLyw5P jSaANK8BMKbn1hDEjO+WhDyuYUpLdF7KRvKJAGlVncVB7AsoqncbXq8XQG4hYBko++d8peVPzYQTu FYCe65vsL4s8/9IxKz9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGFw0-0000000AY21-1wZi; Mon, 12 Oct 2026 13:19:20 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xGFvz-0000000AY1m-41qw for linux-phy@lists.infradead.org; Mon, 12 Oct 2026 13:19:20 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 7278F411E8; Mon, 12 Oct 2026 13:19:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4437E1F0089B; Mon, 12 Oct 2026 13:19:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791811159; bh=l8F4WlE83w/gzZrKmJrEQ/hWZM/K60nnEHKAMTgjHJA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=ZRW6XwmNU4pS1UBwDwmzH7Dj6icbWlkneHuKE1wfxjmsQYEqzhgsWMsjhg8rTWsWv AUzRQfsMKXMmlx+METx2RDDHR0l71GYbo52W+t+LAmf04U/scU+gYQzVC/vP3xgKSO 2RnXaF5xfPen5CugsXtz3sFLD8uCAyejLSadFkTHHfhaTOffz4Ag0y/mjM8XuI30nj +/8i/YmmC5VLWWn+wVthiR6FCv1jzmxw2rz7pxVZbEtwPTIL0nJ2PYhyCmyR4YQZq4 osYB/2VEOqpEaKr92HfGAwGADBQu043VEwmQU/4c+aSX31hYriWFo5+nVbzF6ozzF7 JOjsl5zN3oPUQ== Date: Mon, 12 Oct 2026 18:49:05 +0530 From: Manivannan Sadhasivam To: Nabige Aala Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Kuogee Hsieh , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Ritesh Kumar , Mahadevan P Subject: Re: [PATCH 09/17] phy: qcom: edp: Add Nord AUX channel and VCO divider configuration tables Message-ID: References: <20260911-nord-drv-dt-v1-0-e25c073cf1b6@oss.qualcomm.com> <20260911-nord-drv-dt-v1-9-e25c073cf1b6@oss.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260911-nord-drv-dt-v1-9-e25c073cf1b6@oss.qualcomm.com> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org T24gRnJpLCBTZXAgMTEsIDIwMjYgYXQgMDk6MDY6NDBQTSArMDUzMCwgTmFiaWdlIEFhbGEgd3Jv dGU6Cj4gRnJvbTogUml0ZXNoIEt1bWFyIDxyaXRlc2gua3VtYXJAb3NzLnF1YWxjb21tLmNvbT4K PiAKPiBOb3JkIHJlcXVpcmVzIGRpZmZlcmVudCBBVVggY2hhbm5lbCBhbmQgVkNPIGRpdmlkZXIg c2V0dGluZ3MgY29tcGFyZWQKPiB0byBleGlzdGluZyBTb0NzLiAgQWRkIGVkcF9waHlfYXV4X2Nm Z19ub3JkIGFuZCBlZHBfcGh5X3Zjb19kaXZfY2ZnX25vcmQKPiB3aXRoIHZhbHVlcyBzb3VyY2Vk IGZyb20gSFBHIFRhYmxlcyAyLTEtYSBhbmQgMi0xLWIgcmVzcGVjdGl2ZWx5Lgo+IAo+IFNpZ25l ZC1vZmYtYnk6IFJpdGVzaCBLdW1hciA8cml0ZXNoLmt1bWFyQG9zcy5xdWFsY29tbS5jb20+Cj4g U2lnbmVkLW9mZi1ieTogTmFiaWdlIEFhbGEgPG5hYmlnZS5hYWxhQG9zcy5xdWFsY29tbS5jb20+ Cj4gLS0tCj4gIGRyaXZlcnMvcGh5L3F1YWxjb21tL3BoeS1xY29tLWVkcC5jIHwgMTkgKysrKysr KysrKysrKysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKQo+IAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL3BoeS9xdWFsY29tbS9waHktcWNvbS1lZHAuYyBiL2RyaXZlcnMv cGh5L3F1YWxjb21tL3BoeS1xY29tLWVkcC5jCj4gaW5kZXggMzczZjEzYjNkNmQ1Li5lZTBkN2Yx YTkwZmUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9waHkvcXVhbGNvbW0vcGh5LXFjb20tZWRwLmMK PiArKysgYi9kcml2ZXJzL3BoeS9xdWFsY29tbS9waHktcWNvbS1lZHAuYwo+IEBAIC0xNTA4LDYg KzE1MDgsMjUgQEAgc3RhdGljIGludCBxY29tX2VkcF9waHlfcHJvYmUoc3RydWN0IHBsYXRmb3Jt X2RldmljZSAqcGRldikKPiAgCXJldHVybiBQVFJfRVJSX09SX1pFUk8ocGh5X3Byb3ZpZGVyKTsK PiAgfQo+ICAKPiArLyoKPiArICogbm9yZCBBVVggY29uZmlnIChlRFAgbW9kZSkuCj4gKyAqIEZy b20gSFBHIFRhYmxlIDItMS1hOiBlZHBfcGh5X2F1eF9iaXN0LmNzdgo+ICsgKiBJbmRleDogIDAg ICAgIDEgICAgIDIgICAgIDMgICAgIDQgICAgIDUgICAgIDYgICAgIDcgICAgIDggICAgIDkgICAg MTAgICAgMTEgICAgMTIKPiArICovCj4gK3N0YXRpYyBjb25zdCB1OCBlZHBfcGh5X2F1eF9jZmdf bm9yZFtEUF9BVVhfQ0ZHX1NJWkVdID0gewo+ICsJMHgwMCwgMHgxMywgMHhhNCwgMHgwMCwgMHgw YSwgMHgyNiwgMHgwYSwgMHgwMywgMHgzNywgMHgwMywgMHgwMiwgMHgwMiwgMHgwNCwKPiArfTsK PiArCj4gKy8qCj4gKyAqIG5vcmQgVkNPX0RJViBjb25maWcgZm9yIGVEUCBtb2RlLgo+ICsgKiBG cm9tIEhQRyBUYWJsZSAyLTEtYiBBVVggQ2xvY2sgU2V0dGluZ3MgKGVEUCBtb2RlKSAtIE5vbWlu YWwvVHVyYm8gY29sdW1uLgo+ICsgKiBJbmRpY2VzOiBbMF09MTYyMCwgWzFdPTI3MDAsIFsyXT01 NDAwLCBbM109ODEwMAo+ICsgKi8KPiArc3RhdGljIGNvbnN0IHU4IGVkcF9waHlfdmNvX2Rpdl9j Zmdfbm9yZFs0XSA9IHsKPiArCTB4MDAsIDB4MDAsIDB4MDIsIDB4MDEsCj4gK307Cj4gKwoKRnJv bSB0aGlzIHBhdGNoIG9ud2FyZHMgeW91IGFyZSBpbnRyb2R1Y2luZyAtV3VudXNlZCogd2Fybmlu Z3MgZm9yIGVhY2ggcGF0Y2guCllvdSAqbXVzdCBub3QqIGRvIHRoYXQuCgpJZiBsb2dpY2FsIHNw bGl0IGlzIHdoYXQgeW91IGFyZSBhaW1pbmcgaGVyZSwgSSBjYW4gc2F5IHRoYXQgaXQgaXNuJ3Qg d2hhdCB5b3UKYXJlIGRvaW5nIGhlcmUuCgpQbGVhc2UgZ3JvdXAgTm9yZCBTb0Mgc3VwcG9ydCBp biBvbmUgcGF0Y2ggYW5kIGtlZXAgdGhlIHByZXBhcmF0b3J5IHBhdGNoZXMKc2VwYXJhdGUuCgot IE1hbmkKCi0tIArgrq7grqPgrr/grrXgrqPgr43grqPgrqngr40g4K6a4K6k4K6+4K6a4K6/4K61 4K6u4K+NCgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D12A7CA9ED0 for ; Mon, 12 Oct 2026 13:19:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 376A010F0FB; Mon, 12 Oct 2026 13:19:26 +0000 (UTC) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8D6CA10F0F8; Mon, 12 Oct 2026 13:19:19 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 7278F411E8; Mon, 12 Oct 2026 13:19:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4437E1F0089B; Mon, 12 Oct 2026 13:19:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1791811159; bh=l8F4WlE83w/gzZrKmJrEQ/hWZM/K60nnEHKAMTgjHJA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=ZRW6XwmNU4pS1UBwDwmzH7Dj6icbWlkneHuKE1wfxjmsQYEqzhgsWMsjhg8rTWsWv AUzRQfsMKXMmlx+METx2RDDHR0l71GYbo52W+t+LAmf04U/scU+gYQzVC/vP3xgKSO 2RnXaF5xfPen5CugsXtz3sFLD8uCAyejLSadFkTHHfhaTOffz4Ag0y/mjM8XuI30nj +/8i/YmmC5VLWWn+wVthiR6FCv1jzmxw2rz7pxVZbEtwPTIL0nJ2PYhyCmyR4YQZq4 osYB/2VEOqpEaKr92HfGAwGADBQu043VEwmQU/4c+aSX31hYriWFo5+nVbzF6ozzF7 JOjsl5zN3oPUQ== Date: Mon, 12 Oct 2026 18:49:05 +0530 From: Manivannan Sadhasivam To: Nabige Aala Cc: Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Kuogee Hsieh , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Ritesh Kumar , Mahadevan P Subject: Re: [PATCH 09/17] phy: qcom: edp: Add Nord AUX channel and VCO divider configuration tables Message-ID: References: <20260911-nord-drv-dt-v1-0-e25c073cf1b6@oss.qualcomm.com> <20260911-nord-drv-dt-v1-9-e25c073cf1b6@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260911-nord-drv-dt-v1-9-e25c073cf1b6@oss.qualcomm.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Sep 11, 2026 at 09:06:40PM +0530, Nabige Aala wrote: > From: Ritesh Kumar > > Nord requires different AUX channel and VCO divider settings compared > to existing SoCs. Add edp_phy_aux_cfg_nord and edp_phy_vco_div_cfg_nord > with values sourced from HPG Tables 2-1-a and 2-1-b respectively. > > Signed-off-by: Ritesh Kumar > Signed-off-by: Nabige Aala > --- > drivers/phy/qualcomm/phy-qcom-edp.c | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c > index 373f13b3d6d5..ee0d7f1a90fe 100644 > --- a/drivers/phy/qualcomm/phy-qcom-edp.c > +++ b/drivers/phy/qualcomm/phy-qcom-edp.c > @@ -1508,6 +1508,25 @@ static int qcom_edp_phy_probe(struct platform_device *pdev) > return PTR_ERR_OR_ZERO(phy_provider); > } > > +/* > + * nord AUX config (eDP mode). > + * From HPG Table 2-1-a: edp_phy_aux_bist.csv > + * Index: 0 1 2 3 4 5 6 7 8 9 10 11 12 > + */ > +static const u8 edp_phy_aux_cfg_nord[DP_AUX_CFG_SIZE] = { > + 0x00, 0x13, 0xa4, 0x00, 0x0a, 0x26, 0x0a, 0x03, 0x37, 0x03, 0x02, 0x02, 0x04, > +}; > + > +/* > + * nord VCO_DIV config for eDP mode. > + * From HPG Table 2-1-b AUX Clock Settings (eDP mode) - Nominal/Turbo column. > + * Indices: [0]=1620, [1]=2700, [2]=5400, [3]=8100 > + */ > +static const u8 edp_phy_vco_div_cfg_nord[4] = { > + 0x00, 0x00, 0x02, 0x01, > +}; > + >From this patch onwards you are introducing -Wunused* warnings for each patch. You *must not* do that. If logical split is what you are aiming here, I can say that it isn't what you are doing here. Please group Nord SoC support in one patch and keep the preparatory patches separate. - Mani -- மணிவண்ணன் சதாசிவம்