From: Florian Westphal <fw@strlen.de>
To: Joas Antonio dos Santos <joasantonio108@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Phil Sutter <phil@nwl.cc>, Weiming Shi <bestswngs@gmail.com>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nft_set_pipapo: skip transaction elements during GC
Date: Sun, 25 Oct 2026 00:23:09 +0200 [thread overview]
Message-ID: <at0vzdlVTF8XAzHj@strlen.de> (raw)
In-Reply-To: <179287943591.17355.17353179557993329094@gmail.com>
Joas Antonio dos Santos <joasantonio108@gmail.com> wrote:
> Since nft_set_commit_update() runs set commit callbacks before processing
> NEWSETELEM transactions, pipapo_gc_scan() can observe elements added by
> the transaction being committed: nft_pipapo_commit() calls
> pipapo_gc_scan() on the clone, which already holds the freshly inserted
> (not yet activated) elements.
>
> pipapo_gc_scan() selects elements to collect using only
> __nft_set_elem_expired(), without checking the element's transaction
> state. A new element that is already expired at commit time (for
> example a short expiration whose delta elapses during a large batch
Please ask your LLM to explain how a newly added element can be both new
and expired at the same time, then fix that.
next prev parent reply other threads:[~2026-10-24 22:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 22:03 [PATCH nf] netfilter: nft_set_pipapo: skip transaction elements during GC Joas Antonio dos Santos
2026-10-24 22:23 ` Florian Westphal [this message]
2026-10-24 22:43 ` Joas Antonio dos Santos
2026-10-25 5:38 ` Florian Westphal
2026-10-25 16:48 ` Joas Antonio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=at0vzdlVTF8XAzHj@strlen.de \
--to=fw@strlen.de \
--cc=bestswngs@gmail.com \
--cc=coreteam@netfilter.org \
--cc=joasantonio108@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.