From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <kees@kernel.org>, Petr Mladek <pmladek@suse.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Tycho Andersen <tycho@tycho.pizza>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH v5 2/2] kallsyms: Don't leak pointers for unresolved symbols
Date: Sun, 25 Oct 2026 16:51:43 +0200 [thread overview]
Message-ID: <at4Xf345aTRe9N7o@ashevche-desk.local> (raw)
In-Reply-To: <20261024161029.a52VJ8Bg@linutronix.de>
On Sat, Oct 24, 2026 at 06:10:29PM +0200, Sebastian Andrzej Siewior wrote:
> On 2026-10-24 13:07:09 [+0300], Andy Shevchenko wrote:
...
> > > - return sprintf(buffer, "0x%lx", address - symbol_offset);
> > > + return sprintf(buffer, "0x%p", address - symbol_offset);
> >
> > Hmm... Do we need a 0x here? I believe it's embedded into %p output, no?
>
> No, it does not. The %p does a fix digit size (different between 64 and
> 32 bit) without the 0x prefix.
Thanks for checking that. I dunno why my memory is weak in this sense...
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-25 14:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 16:46 [PATCH v5 0/2] vsprintf: Don't leak pointers Sebastian Andrzej Siewior
2026-10-23 16:46 ` [PATCH v5 1/2] vsprintf: Don't leak pointers for %ps without KALLSYMS enabled Sebastian Andrzej Siewior
2026-10-23 16:46 ` [PATCH v5 2/2] kallsyms: Don't leak pointers for unresolved symbols Sebastian Andrzej Siewior
2026-10-24 2:13 ` kernel test robot
2026-10-24 10:07 ` Andy Shevchenko
2026-10-24 16:10 ` Sebastian Andrzej Siewior
2026-10-25 14:51 ` Andy Shevchenko [this message]
2026-10-27 16:00 ` Petr Mladek
2026-11-02 11:38 ` Sebastian Andrzej Siewior
2026-11-03 14:10 ` [PATCH v5 0/2] vsprintf: Don't leak pointers Petr Mladek
2026-11-03 15:45 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=at4Xf345aTRe9N7o@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=namhyung@kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tycho@tycho.pizza \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.