From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Filip Hejsek <filip.hejsek@gmail.com>
Cc: qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v3 2/2] io: report a warning when a file channel is created from a stdio fd
Date: Mon, 26 Oct 2026 11:32:25 +0000 [thread overview]
Message-ID: <at86SePt-nZUCyIE@redhat.com> (raw)
In-Reply-To: <20261017-fix-stdio-close-v3-2-cfff0122a2a4@gmail.com>
On Sat, Oct 17, 2026 at 01:09:09AM +0200, Filip Hejsek wrote:
> A channel closes its fd when the last reference to it is dropped.
> Closing stdio fds is typically unwanted, so warn when they are passed to
> qio_channel_file_new_fd().
>
> Change the documentation of qio_channel_file_new_fd() to explicitly say
> that passing stdio descriptors is incorrect.
>
> Signed-off-by: Filip Hejsek <filip.hejsek@gmail.com>
> ---
> include/io/channel-file.h | 12 ++++++++----
> io/channel-file.c | 6 ++++++
> 2 files changed, 14 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
next prev parent reply other threads:[~2026-10-26 11:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 23:09 [PATCH v3 0/2] io: make sure we don't close stdio fds Filip Hejsek
2026-10-16 23:09 ` [PATCH v3 1/2] char-stdio: avoid closing " Filip Hejsek
2026-10-26 11:32 ` Daniel P. Berrangé
2026-10-16 23:09 ` [PATCH v3 2/2] io: report a warning when a file channel is created from a stdio fd Filip Hejsek
2026-10-26 11:32 ` Daniel P. Berrangé [this message]
2026-10-20 13:44 ` [PATCH v3 0/2] io: make sure we don't close stdio fds marcandre.lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=at86SePt-nZUCyIE@redhat.com \
--to=berrange@redhat.com \
--cc=filip.hejsek@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.