All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: "Kumar G, Naresh" <naresh.kumar.g@intel.com>
Cc: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>,
	intel-xe@lists.freedesktop.org, rodrigo.vivi@intel.com,
	Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
	Danilo Krummrich <dakr@kernel.org>,
	"Upadhyay, Tejas" <tejas.upadhyay@intel.com>
Subject: Re: [PATCH] drm/xe/i2c: Fix use-after-free on driver unload
Date: Mon, 26 Oct 2026 12:47:57 +0100	[thread overview]
Message-ID: <at897eWTsL57jHR3@black.igk.intel.com> (raw)
In-Reply-To: <7939f69c-bc63-4465-a578-8024e20c4eb8@intel.com>

On Mon, Oct 12, 2026 at 05:16:16PM +0530, Kumar G, Naresh wrote:
> Hi Bala,
> 
> I was investigating this issue earlier in sometime and found the root cause
> in software _node_notify_remove().
> 
> It is a kind of ownership bug in driver/base/swnode.c
> sofware_node_notify_remove(). when a manged swnode is mirrored onto a
> 
> second device(which is exactly what i2c-core does for the adapter's own
> struct device), the old code does an extra
> set_secondary_fwnode()/swnode_put()
> 
> for every device that tears down, not just the true owner. this is a
> double-release/UAF risk. The following fix solves the issue without changing
> i2c adapter registration flow.
> 
> The following code patch is suggested/provided to @heikki: waiting for his
> inputs on the same.

As I already explained you guys before, you don't need my ACK for
that. I have not input for it.

Br,

-- 
heikki

  parent reply	other threads:[~2026-10-26 11:48 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-09 16:42 [PATCH] drm/xe/i2c: Fix use-after-free on driver unload Balasubramani Vivekanandan
2026-10-09 16:42 ` ✗ CI.checkpatch: warning for " Patchwork
2026-10-09 16:44 ` ✓ CI.KUnit: success " Patchwork
2026-10-09 16:47 ` [PATCH] " sashiko-bot
2026-10-12 12:25   ` Vivekanandan, Balasubramani
2026-10-09 18:19 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-10-09 21:19 ` ✓ Xe.CI.FULL: " Patchwork
2026-10-10 20:14 ` [PATCH] " Danilo Krummrich
2026-10-12 12:15   ` Vivekanandan, Balasubramani
2026-10-12 11:46 ` Kumar G, Naresh
2026-10-12 13:16   ` Vivekanandan, Balasubramani
2026-10-26 11:56     ` Heikki Krogerus
2026-10-26 18:10       ` Andy Shevchenko
2026-10-28 17:10         ` Kumar G, Naresh
2026-10-29 17:02         ` Bartosz Golaszewski
2026-10-26 11:47   ` Heikki Krogerus [this message]
2026-10-27 12:49   ` Andi Shyti
2026-10-28 17:24     ` Kumar G, Naresh
2026-10-27 15:11 ` Andi Shyti
2026-10-29  8:09   ` Vivekanandan, Balasubramani
2026-10-29 17:04   ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=at897eWTsL57jHR3@black.igk.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=balasubramani.vivekanandan@intel.com \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=dakr@kernel.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=naresh.kumar.g@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=tejas.upadhyay@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.