From: Patrick Steinhardt <ps@pks.im>
To: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
Cc: git@vger.kernel.org, christian.couder@gmail.com,
usmanakinyemi202@gmail.com, siddharthasthana31@gmail.com,
kaartic.sivaraam@gmail.com
Subject: Re: [Outreachy PATCH] diffcore-rename: stop using the_repository
Date: Mon, 26 Oct 2026 12:54:33 +0100 [thread overview]
Message-ID: <at8_ebX7cYMrlhU9@pks.im> (raw)
In-Reply-To: <CAFpMFfDaVf47QKkNROJAHJB7oJR+iPt5gkkCnj4KdZW_9MRqGQ@mail.gmail.com>
On Mon, Oct 26, 2026 at 12:22:59PM +0100, Okhuomon Ajayi wrote:
> Thanks for the review, Patrick!
Nit: please don't top-post, the expectation is to write your answer
below the parts you respond to. Thanks!
Patrick
> On Mon, Oct 26, 2026 at 11:52 AM Patrick Steinhardt <ps@pks.im> wrote:
> >
> > On Sat, Oct 24, 2026 at 11:13:41PM +0100, Okhuomon Ajayi wrote:
> > > diffcore_rename_extended() already has the repository through
> > > options. Use its hash algorithm when checking for empty blobs,
> > > and pass it to start_delayed_progress().
> > >
> > > Remove the USE_THE_REPOSITORY_VARIABLE definition.
> >
> > All of the conversions are trivial, and we already dereference
> > `options->repo` unconditionally in this function. So the patch looks
> > trivially correct to me, nice!
> >
> > Patrick
next prev parent reply other threads:[~2026-10-26 11:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 22:13 [Outreachy PATCH] diffcore-rename: stop using the_repository Okhuomon Ajayi
2026-10-26 10:52 ` Patrick Steinhardt
2026-10-26 11:22 ` Okhuomon Ajayi
2026-10-26 11:54 ` Patrick Steinhardt [this message]
2026-10-26 11:58 ` Okhuomon Ajayi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=at8_ebX7cYMrlhU9@pks.im \
--to=ps@pks.im \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=kaartic.sivaraam@gmail.com \
--cc=okhuomonajayi54@gmail.com \
--cc=siddharthasthana31@gmail.com \
--cc=usmanakinyemi202@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.