All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: himanshu bakshi <himanshu.bakshi478@gmail.com>
Cc: andy@kernel.org, gregkh@linuxfoundation.org,
	dennylin0707@gmail.com, cenzhang@linux.microsoft.com,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	error27@gmail.com
Subject: Re: [PATCH v2] staging: fbtft: Remove unused fbtft_init_dbg()
Date: Mon, 26 Oct 2026 11:48:02 +0200	[thread overview]
Message-ID: <at8h0ignZd8srvBi@ashevche-desk.local> (raw)
In-Reply-To: <20261026092423.66168-1-himanshu.bakshi478@gmail.com>

On Mon, Oct 26, 2026 at 02:54:23PM +0530, himanshu bakshi wrote:
> 
> The fbtft_init_dbg() macro is not being used, so delete it.
> 
> Reviewed-by: Dan Carpenter error27@gmail.com
> 

No blank line in the tag block.

> Signed-off-by: Himanshu Bakshi <himanshu.bakshi478@gmail.com>
> ---

You must learn to provide a changelog!
What has been changed? Why (whose request was that)?

>  drivers/staging/fbtft/fbtft.h | 7 -------
>  1 file changed, 7 deletions(-)

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2026-10-26  9:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26  9:24 [PATCH v2] staging: fbtft: Remove unused fbtft_init_dbg() himanshu bakshi
2026-10-26  9:44 ` Himanshu Bakshi
2026-10-26  9:48 ` Andy Shevchenko [this message]
2026-10-26 10:19   ` Himanshu Bakshi
2026-10-26 10:05 ` Dan Carpenter
2026-10-26 10:22   ` Himanshu Bakshi
2026-10-26 10:29     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=at8h0ignZd8srvBi@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=cenzhang@linux.microsoft.com \
    --cc=dennylin0707@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=error27@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=himanshu.bakshi478@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.