From: Mark Brown <broonie@kernel.org>
To: Sasha Levin <sashal@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>, Oliver Upton <oupton@kernel.org>,
Fuad Tabba <fuad.tabba@linux.dev>,
Joey Gouly <joey.gouly@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Steffen Eiden <seiden@linux.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Shuah Khan <shuah@kernel.org>,
"Lorenzo Stoakes (ARM)" <ljs@kernel.org>,
Itaru Kitayama <itaru.kitayama@fujitsu.com>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] KVM: arm64: selftests: Skip unwritable ID fields in the failed-run test
Date: Mon, 26 Oct 2026 12:05:08 +0000 [thread overview]
Message-ID: <at9B9N-90QwLPv5i@sirena.co.uk> (raw)
In-Reply-To: <20261026012128.2270251-1-sashal@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 743 bytes --]
On Sun, Oct 25, 2026 at 09:21:28PM -0400, Sasha Levin wrote:
> Only a field that userspace can change can be frozen, and KVM reports
> these registers as not writable in KVM_ARM_GET_REG_WRITABLE_MASKS. Skip
> the fields that the writable mask does not cover. test_vm_ftr_id_regs()
> already requires the mask to cover every other field in test_regs, so
> this only drops the fields KVM never lets userspace change. Whether KVM
> accepts writes to fields it reports as not writable is a separate
> question from finalization.
It would be nice to apply the same thing to the NV instances as well but
in any case:
Reviewed-by: Mark Brown <broonie@kernel.org>
I didn't redo the testing that Fuad already did since it'd just be the
same thing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2026-10-26 12:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 1:21 [PATCH v2] KVM: arm64: selftests: Skip unwritable ID fields in the failed-run test Sasha Levin
2026-10-26 8:09 ` Fuad Tabba
2026-10-26 12:01 ` Marc Zyngier
2026-10-26 12:05 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=at9B9N-90QwLPv5i@sirena.co.uk \
--to=broonie@kernel.org \
--cc=fuad.tabba@linux.dev \
--cc=itaru.kitayama@fujitsu.com \
--cc=joey.gouly@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=ljs@kernel.org \
--cc=maz@kernel.org \
--cc=oupton@kernel.org \
--cc=pbonzini@redhat.com \
--cc=sashal@kernel.org \
--cc=seanjc@google.com \
--cc=seiden@linux.ibm.com \
--cc=shuah@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.