From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Wesley Hershberger <wesley.hershberger@canonical.com>
Cc: qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>,
"Hector Cao" <hector.cao@canonical.com>,
"Alex Ramírez" <alex.ramirez@canonical.com>
Subject: Re: [PATCH v4 2/2] util/coroutine: Reduce default idle pool max size
Date: Thu, 15 Oct 2026 08:46:11 +0100 [thread overview]
Message-ID: <atCEw5dxu8GCHNWU@redhat.com> (raw)
In-Reply-To: <20261014-set-default-pool-size-v4-2-a3aff89b94f0@canonical.com>
On Wed, Oct 14, 2026 at 04:55:46PM -0500, Wesley Hershberger wrote:
> If g_file_get_contents fails (AppArmor, etc), use a more conservative
> default max size for the idle coroutine pool.
>
> This avoids any possibility of the failure described in 86a637e48104
> unless the host kernel is configured with a lower-than-default
> vm.max_map_count.
>
> This change is motivated by a discussion of backport risk:
> https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/2168803/comments/8
>
> Fixes: 86a637e48104 ("coroutine: cap per-thread local pool size")
> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Wesley Hershberger <wesley.hershberger@canonical.com>
> ---
> util/qemu-coroutine.c | 73 ++++++++++++++++++++++++++++++++-------------------
> 1 file changed, 46 insertions(+), 27 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
next prev parent reply other threads:[~2026-10-15 7:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 21:55 [PATCH v4 0/2] util/coroutine: Reduce default idle pool max size Wesley Hershberger
2026-10-14 21:55 ` [PATCH v4 1/2] util/coroutine: trim sysctl's max_map_count newline before parsing Wesley Hershberger
2026-10-15 18:44 ` Stefan Hajnoczi
2026-10-14 21:55 ` [PATCH v4 2/2] util/coroutine: Reduce default idle pool max size Wesley Hershberger
2026-10-15 7:46 ` Daniel P. Berrangé [this message]
2026-10-15 18:39 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atCEw5dxu8GCHNWU@redhat.com \
--to=berrange@redhat.com \
--cc=alex.ramirez@canonical.com \
--cc=hector.cao@canonical.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wesley.hershberger@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.