From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B336CC6B34 for ; Thu, 15 Oct 2026 07:59:59 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xHGNN-0003Kr-In; Thu, 15 Oct 2026 03:59:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xHGNI-0003KX-KU for qemu-devel@nongnu.org; Thu, 15 Oct 2026 03:59:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xHGNG-0004ut-Od for qemu-devel@nongnu.org; Thu, 15 Oct 2026 03:59:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792051176; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P3xVoBYMtW5UXEqsWNovVRjqkGWjM5k6zx2/Sm4bQMA=; b=dvxoX3eTKkmpjmW1s078RgBX6vqzTPCv/JtmeYfBP8oW0csA+t4R7V1hiEaQHa08TT932L oMlrK6AYqo5PC0rmX2ZESg01WZp1OIYd8WK6Cm4E3n5abk7aXZ7XEUFKH02RvrNvDFjUm4 wJprzOgtTun61kyJLYkf2eTrgnwWXSo= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-259-y-3bD4pPPoGytGyvUn9_og-1; Thu, 15 Oct 2026 07:59:27 +0000 X-MC-Unique: y-3bD4pPPoGytGyvUn9_og-1 X-Mimecast-MFC-AGG-ID: y-3bD4pPPoGytGyvUn9_og_1792051166 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BA3FD1955E8D; Thu, 15 Oct 2026 07:59:26 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D8F757C6; Thu, 15 Oct 2026 07:59:24 +0000 (UTC) Date: Thu, 15 Oct 2026 08:59:21 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Pierrick Bouvier Cc: qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Markus Armbruster Subject: Re: [PATCH 0/8] multi-target: remove qmp_query_cpu_definitions duplication Message-ID: References: <20261015005355.62406-1-pierrick.bouvier@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20261015005355.62406-1-pierrick.bouvier@oss.qualcomm.com> User-Agent: Mutt/2.4.2 (2026-08-30) X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 10 X-Spam_score: 1.0 X-Spam_bar: + X-Spam_report: (1.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.24, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Oct 15, 2026 at 12:53:47AM +0000, Pierrick Bouvier wrote: > This series allows to link multiple targets that define > qmp_query_cpu_definitions. It simply replaces the duplicated definitions with > target-specific ones and a single dispatcher. We didn't use yet the dispatcher > pattern, and it's the first situation where it appears to be a good fit. > > A possible alternative would be to introduce this callback directly at > target-info level, which I think is a less desirable solution, since it would > ties this API to monitor. > > If the approach here is accepted, I'll extend this series with > qmp_query_cpu_model_expansion which follows the same pattern. > With this, we'll be free to link together almost all the base architectures. > > Pierrick Bouvier (8): > target/arm: rename qmp_query_cpu_definitions to > qmp_query_arm_cpu_definitions > target/i386: rename qmp_query_cpu_definitions to > qmp_query_i386_cpu_definitions > target/loongarch: rename to qmp_query_loongarch_cpu_definitions > target/mips: rename qmp_query_cpu_definitions to > qmp_query_mips_cpu_definitions > target/ppc: rename qmp_query_cpu_definitions to > qmp_query_ppc_cpu_definitions > target/riscv: rename to qmp_query_cpu_definitions to > qmp_query_riscv_cpu_definitions > target/s390x: rename qmp_query_cpu_definitions to > qmp_query_s390x_cpu_definitions > qmp: reimplement qmp_query_cpu_definitions as a dispatcher function > > hw/core/machine-qmp-cmds.c | 32 +++++++++++++++++++++++++++ > include/system/qmp-cpu.h | 20 +++++++++++++++++ > stubs/meson.build | 6 +++++ > stubs/qmp-cpu-arm.c | 9 ++++++++ > stubs/qmp-cpu-i386.c | 9 ++++++++ > stubs/qmp-cpu-loongarch.c | 9 ++++++++ > stubs/qmp-cpu-mips.c | 9 ++++++++ > stubs/qmp-cpu-ppc.c | 9 ++++++++ > stubs/qmp-cpu-riscv.c | 9 ++++++++ > stubs/qmp-cpu-s390x.c | 6 +++++ > stubs/qmp-cpu.c | 7 ------ > target/arm/arm-qmp-cmds.c | 3 ++- > target/i386/cpu.c | 3 ++- > target/loongarch/loongarch-qmp-cmds.c | 3 ++- > target/mips/system/mips-qmp-cmds.c | 3 ++- > target/ppc/ppc-qmp-cmds.c | 3 ++- > target/riscv/riscv-qmp-cmds.c | 3 ++- > target/s390x/cpu_models_system.c | 3 ++- > 18 files changed, 132 insertions(+), 14 deletions(-) > create mode 100644 include/system/qmp-cpu.h > create mode 100644 stubs/qmp-cpu-arm.c > create mode 100644 stubs/qmp-cpu-i386.c > create mode 100644 stubs/qmp-cpu-loongarch.c > create mode 100644 stubs/qmp-cpu-mips.c > create mode 100644 stubs/qmp-cpu-ppc.c > create mode 100644 stubs/qmp-cpu-riscv.c For series: Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|