From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D4404AA3F1 for ; Thu, 15 Oct 2026 08:03:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792051434; cv=none; b=O0sPUwCXmqO6Vu3J2GGdHpBT7Oocmxolf/gRehg9gOF0kL1d4+Avo6aIuxbW2qDhaLoWXYsQ8orlOYHKU/mZgNspZ4kPSaIaCvf+yQjJUrxNSBzZ1/dJYj6YSvlbPYksCAtJSXf3DdYMvXpIUvNG9+7JCPmg3CeX3pBPcL5wYmg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792051434; c=relaxed/simple; bh=XobB0GpO5sYyTZ2hFUN5pcaQvo46soO0LtUdcW2CECI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jAVFfCAuA0g5QHUS7ywxfLhjFgzhBs8x9Idslyxk3FSUIeJbR02ouj8kCDyl43IZtzXJgWN/iU+OUocSySNDl7tgGa+fcWv2pv3/YU2zqlAB+/uuKlUMf8b2MeAHOtU32mwb7QYwYZZHJBed4SNc+GXegpS7YivqFZL0hhQP6pM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kYecT8vv; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kYecT8vv" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4a1682bff3cso7899695e9.1 for ; Thu, 15 Oct 2026 01:03:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792051431; x=1792656231; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=1tCr4+FZVRH42/s/Dcv1+y2zUOpfmIVxo7wybQlZ/hQ=; b=kYecT8vvJOhxWfYDM4/+pAwOTXskQUXrw6kl4hmvQ7ZeYStXQHcgbRgBs1P5Iwtpqy AaVDeAUo+kTcv1LLfI4HUokux4bcau9prg/q6NMZhIgCylfN+LTNLVsL2VSPGTbteF30 +NybnR/PKMKzLAUtuvCyEazTF4N7obsyl651AQeOECrJq0i4pZPsRbf+XI8VUvRMcHdX fMkaOh4EGMnE1sTpf7d4PYmt7vXUjvhtfwBaTIcQZR2Brk9Cg3j6E1WenKexLwK1vqhk DwcGqCCys6GiV3upJUriria+OP3IR9Vc9oxQL8oz95XvDdmGYerOeS1Z13BIRKqZ5TrJ dRRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792051431; x=1792656231; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1tCr4+FZVRH42/s/Dcv1+y2zUOpfmIVxo7wybQlZ/hQ=; b=UCYWcIFElLfwWlZwzeQFGJ8cPY46RKVpEANBHhOq9m7r+ArAXOOuqxoX/G7FnsipWG UhKqDFkWTyKFATTkVQpKSkKDKeJjD4/akNpv/2ChvZ9rzX9R7RPst7luZDUcI8Sk3Hez sUEEic5ptZLyBU23K+M1BwdF9ak1+xmTKHeuV/ojfeS6MOqZNKMOSji25VZkhQ/8NQb5 avQ6rSgDqcDW30AjRQsHV1bZD+02jZuIGJwdX0MDV4YZudfYxdKPzjRRfaGNfb+eZ3+M zkGowwDA/CCieLIyQdF+DfiWeNAgt82+B7+gGqPN6yioF/80QhNFihbyI2NxCg9dXML0 iF1Q== X-Forwarded-Encrypted: i=1; AKwUvBzQ0+5tY/KE7Q6FRzUbpora5E4+c4wwihaTpHrDQKX7G8kX67/VxxHKIUBTryCtKjNQnwrBCHo8@lists.linux.dev X-Gm-Message-State: AFq9FYITfgJZCxbX+Q4TzOgZY/s9C7kMaRjdLsi7BCW2CS8iJgkjverv j2c+tQAsRumshCQs+wQGXTsTkupeUjfH+XUrOFOGPaGL4m9hRVdcasTV X-Gm-Gg: AYBFou2JpC1I+w485TS1/3gGn0QLfzy7/zBTtJ21jIWv8pkottSqaYYKfnhmC8uoGdO 9ZO7bGCEvrN4JW+FZppf1yTPQtdCCgz50mpiGbLltm6MGHMST7I9lpi3dJFwoCXuoWaIV7oX8OH 7/QdeiDCPvehFcBcugpDC/8PMuZhF2G9zugrUwaKc/3MfG7L0Qe8LtovdCfInoGH+mgSYkFk9tS Dd2cV75fOSN15IAih+3asmOJgRAPCfq+M4DeonZ5EqKfRWTWe7L1hg2+zIaFBC+jxc2RCObHX09 lOsxSdTsr+Kr0FVvwwuw9uTldcolGIkYpWDruaycEuxlCWxTf6aq+ViKNRRy66gQJYaV/oBzWeL K7RMIDZN+Oxbp2P5EGaAXfaFbqCxOGIDzFkkx9F6/oT6wb4XzTl+PC+xdwCn4NZHRyJhXga74Rn SUqAlX92oNwYYmNx4Hv0oQvP7uPzC0QvWuZxcBKqOGGYyz1ByBdzUd+WSJZ7TBKKJXdpY= X-Received: by 2002:a05:600c:4e89:b0:4a0:12d7:4c88 with SMTP id 5b1f17b1804b1-4a18e4ac77amr406529725e9.30.1792051430698; Thu, 15 Oct 2026 01:03:50 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48de0967affsm15482509f8f.1.2026.10.15.01.03.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2026 01:03:49 -0700 (PDT) Date: Thu, 15 Oct 2026 11:03:46 +0300 From: Dan Carpenter To: "Michael S. Tsirkin" Cc: Sasha Levin , workflows@vger.kernel.org, ksummit@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Corbet , Shuah Khan , Randy Dunlap , Mark Brown , Theodore Ts'o , Laurent Pinchart , Greg Kroah-Hartman , Leon Romanovsky , Konstantin Ryabitsev , Thorsten Leemhuis Subject: Re: [PATCH v2 2/5] agents: add a skill to determine Fixes tags Message-ID: References: <20261012213452.1863248-1-sashal@kernel.org> <20261012213452.1863248-3-sashal@kernel.org> <20261013003535-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: ksummit@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261013003535-mutt-send-email-mst@kernel.org> On Tue, Oct 13, 2026 at 12:42:19AM -0400, Michael S. Tsirkin wrote: > On Mon, Oct 12, 2026 at 05:34:49PM -0400, Sasha Levin wrote: > > Blame and existing Fixes tags can point to code movement instead of the > > change that introduced a bug. Add a read-only investigation procedure > > that traces historical behavior and checks candidate commits against > > their parents before returning a tag with supporting evidence. > > > > Keep the skill entry point and procedure together under > > agents/skills/find-fixes/. Connect the procedure to the coding-assistant > > guidance so bug fixes get verified attribution before finalization. > > > > If the origin cannot be established, return no trailer and keep the fix > > as a draft. Applying the tag and writing the commit message remain outside > > the skill. > > > > Validated with controlled histories covering moved code, changed > > preconditions, incorrect tags, shallow history, and reintroduction after > > a revert, as well as a real kernel fix. > > > > Assisted-by: LLM > > Signed-off-by: Sasha Levin > > Current documentation states: > > A Fixes: tag indicates that the patch fixes a bug in a previous commit. It > is used to make it easy to determine where an issue originated, which can help > review a bug fix. This tag also assists the stable kernel team in determining > which stable kernel versions should receive your fix. This is the preferred > method for indicating a bug fixed by the patch. See :ref:`describe_changes` > for more details. > > > the second part is easy to miss, so "what about an old bug in commit A > commit B exposes" This is pretty common for Makefile cleanups which enable COMPILE_TEST etc. The Fixes tag should point to the commit which introduces the bug and not the one that exposes it. Someone could backport the original patch or expose the bug a different way. > and "what if the bug both in commit A and commit B" > are pretty common questions. > This sentence is missing a verb. I don't understand the question. > > > > Worth answering, maybe, and maybe here: the implication of the "stable > kernel team" rule is that the meaning of the tag is actually: "if you > have commit A then you need this commit". > The Fixes tag is useful for stable, but that's not the only point. It also means that if you don't have the commit, then you don't need the fix. It's also useful for training AI for example. Someone told me that the netdev team was leaving Fixes tags off patches that they didn't want to be backported to stable. But when I looked at it, it was documentation stuff that is really debatable if it deserves a Fixes tag or not. There are some gray areas. regards, dan carpenter