From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 229E8CC6B38 for ; Thu, 15 Oct 2026 20:31:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7D14310E5F7; Thu, 15 Oct 2026 20:31:51 +0000 (UTC) X-Greylist: delayed 333 seconds by postgrey-1.36 at gabe; Thu, 15 Oct 2026 20:31:50 UTC Received: from mailout2.hostsharing.net (mailout2.hostsharing.net [83.223.78.233]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8B5F110E84F for ; Thu, 15 Oct 2026 20:31:50 +0000 (UTC) Received: from h08.hostsharing.net (h08.hostsharing.net [IPv6:2a01:37:1000::53df:5f1c:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature ECDSA (secp384r1) client-digest SHA384) (Client CN "*.hostsharing.net", Issuer "GlobalSign GCC R6 AlphaSSL CA 2025" (verified OK)) by mailout2.hostsharing.net (Postfix) with ESMTPS id 07AE010DF8; Thu, 15 Oct 2026 22:26:16 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id D29636295735; Thu, 15 Oct 2026 22:26:15 +0200 (CEST) Date: Thu, 15 Oct 2026 22:26:15 +0200 From: Lukas Wunner To: Aditya Garg Cc: vasilij.kernel@tototo.si, Aun-Ali Zaidi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Kerem Karabay , Atharva Tiwari Subject: Re: [PATCH v2] drm/appletbdrm: Add suspend and resume support Message-ID: References: <586d0b39-40c8-4f3d-a786-c1085f87b858@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Oct 07, 2026 at 07:50:38PM +0530, Aditya Garg wrote: > > On 4 Oct 2026, at 5:36???PM, Aditya Garg wrote: > > The driver has no USB power management callbacks, so the USB core > > unbinds it before system suspend and binds it again on resume. The DRM > > device is unregistered and registered again on every suspend and resume > > cycle, userspace driving the Touch Bar through it (such as tiny-dfr) > > loses its device, and the Touch Bar stays dark after resume. > > > > Implement suspend and resume with drm_mode_config_helper_suspend() and > > drm_mode_config_helper_resume(), so the device stays registered and the > > last committed state is restored on resume. If the device was reset > > while suspended, repeat the probe-time handshake first. [...] > Could anyone please merge it if they are ok with it? Thanks. I'd love to, but both v1 and v2 have sashiko findings that nobody bothered to debunk or fix. (The fix for v1 consisted of removing a callback, which triggered other sashiko findings.) I'm neither an expert on this driver nor the tiny drm library, but I'd like to help improve Linux Mac support. Please help me understand whether the sashiko findings are valid. Thanks, Lukas