From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6DA74582E8 for ; Thu, 15 Oct 2026 19:57:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792094230; cv=none; b=jlXxygOwmIFgsnXmxDwZEQggsbckQvkD2ToNrztOLfCAbZzrmTEIGrdedjnvp4OYOCMlZ9ZTTVzFlZN+aLe13sFvMDUAvRk+a1xT7sdXbvCXuMKuzhNBYqcyBbNZOgObMvrVJRxAb6tAn0qnRXfZiTtCFEBAkYtG6oPbQ17LBgo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792094230; c=relaxed/simple; bh=W+WQcbkuYlf7iZbcxCz0t5n2JDNxk3p3Ac8rA0qdxo4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jMjChj2VdBCxs7oSMLOUurwc7dLlZ3I6m0QgGl5gqXOkk3VM7Y5HT0Y0wPmCRQIJbiGSDSqU1Hr2fBSVrrEcu77xaKolf7GC4yKw47Hka01NQVMcdog6sgY3OI6xeYA0iXAKAgBbmOO+Tf9etZKDt5v/vnDtj09N8VoZLKzLISs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IV9Ncna1; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IV9Ncna1" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-48de72fc832so648625f8f.1 for ; Thu, 15 Oct 2026 12:57:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792094227; x=1792699027; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=JdoamN/QCC00RvjhRgyruFfNMjWo34XWF83HIj4FenE=; b=IV9Ncna1iVgpQ6ZIVGbDRnAyeL6OHFVt3Ac3z2bX/+xv9r3MvOZt2ykcvUWxGeGL7n B7u8RnTm2+rGFbgx/goaH4oHEhflOeELSfGxB6xFhVHHRjQSBFw3jCPG5LMuLhDEWdzh 44O3Hfpj8U3K35fPooHr25YmSiVZ5ngQ+MD9IPC07Dbn1KLWuEtR3imL6AyiJ0FA72l5 8gUOaOBH6hNmYeILI0MvpU0Z6SdiEVCuH6rqg5CYcsYTw2KqE6SWh857TbNqIzIl4TgJ 3q2e1LXdvY7SKi0G9pm0tW9j2qQWzAxZ0v0/CS3EuherzRHLaErBjbfCuQhV76HNHHNW PbUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792094227; x=1792699027; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JdoamN/QCC00RvjhRgyruFfNMjWo34XWF83HIj4FenE=; b=Kkc6ueqyGs6BPUrLdhePzRszWAT9TbM7gTOAib5PtrqbO5sdP6ytoi2Ptwd+cDFvHt yRMAD8ZUke6blokPQR+GXbQZQP5pwnsHiJn7pgsEl5WjNM7rpQXVYkJDYJZpJnitLJ2O XlCyjXQKSksQFdTg9i0OippmSrGkZDF1RvfW4jQDZNkEEqd48UD1zQyk+8NihbSWSGhj GyCCMfdRxPG3tQiaLdXMKrbVWrqOLz/Poyir2XpUStNT/uWiRA3OjXRg69g57zqtfMV3 B0RliwOCBwhATrnKRaOStW63sNMHpCZ7aTX7Y9ygj2RBkFTLcC8U/SLV/0itPguTk2mx 6wJA== X-Forwarded-Encrypted: i=1; AKwUvBx65YDAf+9bYADp5ANpxPXrR84ZD/gqxixc249aN4oHWy/rGvc7aQNoLmh96t5N8MYj9/43g9qea1g=@lists.linux.dev X-Gm-Message-State: AFq9FYIrm9d24vXsBGXd0dsz1snU6OLP4geGPB+E1FBCYbb/jBCHJkgU 57YyD6cYTIwKez16jEQEwu/R+NYjhkFZAY6miTdNTUpdSfWkJj9kSvKy X-Gm-Gg: AYBFou1d5AJZ2GJK80e+XTUhFy5uR5fsseEsAHLZLsX4sQy23UduuoQCou6skRX2fv1 On8dCy3h0ZsGGvL8UhhOYwlguKJ+tGRP/PfX7xkMlaQYWD/2KatgDNXNO+qOFQ1nyLAmPkaxTi6 tEKMQr8I7gSBZHReArbTiQlQvt5mvzgLhwad4n7Uhns4gGYr1hqhei4/BxI7BAH6QHUEI6AKFLr dFlpkEx0firaccnArssU1ZfSECaRZGLewMAHgssL0Y7Sm4nboNmyniea1B0sEssE8lvYEAJSUMg O+Sd386VKtRBFIVoiiSZD2U3mP8R+lHH8zQlBbmm8A17QoXwend0+pHF2bSS/bjweXB5LVuxbS+ y0bRTB62D+7vlDwDMJV/OXrN7P09Tm4P1rnrBTBfYwlJj8MH3YCVYrnj4Rqch2T3mNz+cAcC/WG 6sfkRdhUIPRvUTMsjQoFJl+SLAk0rAX0MTkSOUctQDT9OMW8b3MqHMf2tv2ENIkUptB1c= X-Received: by 2002:a5d:6402:0:b0:48c:7f18:c85e with SMTP id ffacd0b85a97d-48dbace9c60mr29174300f8f.45.1792094226897; Thu, 15 Oct 2026 12:57:06 -0700 (PDT) Received: from localhost ([2c0f:3d00:6be:8900:ce5e:9212:ea4b:f30]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48dfd4f8cfesm200478f8f.37.2026.10.15.12.57.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2026 12:57:05 -0700 (PDT) Date: Thu, 15 Oct 2026 22:57:01 +0300 From: Dan Carpenter To: Julia Lawall Cc: Alex Elder , pavankumaryalagada@gmail.com, johan@kernel.org, gregkh@linuxfoundation.org, vireshk@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: Re: [PATCH v4] staging: greybus: replace PTR_ERR() with %pe in error messages Message-ID: References: <20261015082238.65187-1-pavankumaryalagada@gmail.com> <99cd529b-dffd-4315-b9be-9b0029973497@ieee.org> Precedence: bulk X-Mailing-List: outreachy@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Oct 15, 2026 at 02:10:53PM -0400, Julia Lawall wrote: > > > On Thu, 15 Oct 2026, Alex Elder wrote: > > > On 10/15/26 3:22 AM, pavankumaryalagada@gmail.com wrote: > > > From: Yalagada Pavan Kumar > > > > > > Use %pe to print error pointers directly and display their > > > error names. > > > > > > Keep PTR_ERR() calls when the numeric error value is needed > > > for returning the error code. > > > > > > Signed-off-by: Yalagada Pavan Kumar > > > > In a few places you are *adding* the error value where it was > > missing (which I think is an improvement). I assume that the > > return values in this case are negative errnos. > > > > It would have been worth mentioning this other type of change > > in the patch description too. But it's not worth doing a new > > version for that. I trust you found all the spots, and fixed > > them this way. This looks good to me. > > This Coccinelle semantic patch finds over 3000 opportunities for this > change in the kernel as a whole. Outside the context of outreachy, I > wonder if people would be happy to see such changes, since the %pe code > seems much more informative. > I like %pe but it's not universally popular. I've seen people NAK these patches because it looks weird in their subsystem and I'm wondering how many error messages their code prints? Surely, any error message would stand out is weird and undesirable? regards, dan carpenter