From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CD95CC6B38 for ; Fri, 16 Oct 2026 00:06:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QtvLOcojnUWoF9SfzesJgsBKalGCzIj2pOFdZ3KsaN8=; b=hEGj+DdjB09cWj UZDyDEQS4+G6QpyedtPjXKpglKIapjuALBodE4Q/ti48wQ9nLtSB6NWNfkaQfcEinUXDKu+9aIvW7 b/I3ir3fUSPSIZtjRfxwe6xsiOWUsSyKH/a182z9uLeXQv8scmoRAEMlZWmfOGp/TwNEbHsjZY28E uZacfSkFNHnqahAG7F6YTvMaROn1Vi2fisNhoW8ZdVL6kdZoNwQW2NBy3+eSUThy3FD0631YydFqE Q3aly7id6OfHCwJmsjyDq5fLu5Gw3azqIOK+bJAiD7jZ9km3+jUpnX1+n1lgB+crU/3MjMpRlRwHG ByCKO4PZU2knM+I4BKBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHVSv-00000001b1V-08AA; Fri, 16 Oct 2026 00:06:29 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xHVSt-00000001b1P-2dyK for linux-riscv@lists.infradead.org; Fri, 16 Oct 2026 00:06:27 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id A84C140327; Fri, 16 Oct 2026 00:06:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CB1C1F000C4; Fri, 16 Oct 2026 00:06:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792109186; bh=lj0QXNDYWzykhho+9TgSGkXQQEpotIYDIIMXMua7eT8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=oOHnLwpwzXtkpHlf/6U6iF7vR87WzvWbEDkOSs+3dp8FKUwEDtOEWfd+6JMd2ssjz GksAiaUpsIWqUo0dFVk155pkKrt/uQGX1NYw1QEdERp+A1Nt6fjyyEr0VjxDe3MTLn y3tG+1pIiDhw0uPafqBUYvc9Ob3kIiwceYOBmf8l7m9JtxTkieKn+UDxCnUf+6eCLS OeTrKt80VAXQzJyVsPTmXXwbritv3DMzHM+pKHlhVzZH8TactA4tSM7tc2hImMGgUV ren66sBe8znD4ykW994KGmIo/iQIXn+69G6S9pkjIAYVzlA6PWgkL1vtq3LBsyYzxv dfLtdDCrcOvRw== Date: Thu, 15 Oct 2026 17:06:24 -0700 From: Drew Fustini To: Sunil V L Cc: Adrien Ricciardi , Alexandre Ghiti , Albert Ou , Atish Patra , Babu Moger , Ben Horgan , Borislav Petkov , Chen Pei , Conor Dooley , Conor Dooley , Dave Hansen , Dave Martin , Fenghua Yu , Gong Shuai , Gong Shuai , guo.wenjia23@zte.com.cn, James Morse , Kornel =?utf-8?Q?Dul=C4=99ba?= , Krzysztof Kozlowski , liu.qingtao2@zte.com.cn, Liu Zhiwei , Palmer Dabbelt , Paul Walmsley , Peter Newman , Radim =?utf-8?B?S3LEjW3DocWZ?= , Reinette Chatre , Rob Herring , Samuel Holland , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt , Tony Luck , Vasudevan Srinivasan , Ved Shanbhogue , Weiwei Li , yunhui cui , Zhanpeng Zhang , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, devicetree@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-doc@vger.kernel.org Subject: Re: [PATCH v9 1/5] riscv_cbqri: Add capacity controller probe and allocation device ops Message-ID: References: <20261003-dfustini-atl-sc-cbqri-dt-v9-0-52fd8be98dcf@kernel.org> <20261003-dfustini-atl-sc-cbqri-dt-v9-1-52fd8be98dcf@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gTW9uLCBPY3QgMTIsIDIwMjYgYXQgMDk6NDI6NTlQTSArMDUzMCwgU3VuaWwgViBMIHdyb3Rl Ogo+IEhpIERyZXchCgpIaSBTdW5pbCwgdGhhbmtzIGZvciByZXZpZXdpbmchCgo+IE9uIFNhdCwg T2N0IDMsIDIwMjYgYXQgMTI6NDXigK9QTSBEcmV3IEZ1c3RpbmkgPGZ1c3RpbmlAa2VybmVsLm9y Zz4gd3JvdGU6Cj4gPgo+ID4gQWRkIHN1cHBvcnQgZm9yIHRoZSBSSVNDLVYgQ0JRUkkgY2FwYWNp dHkgY29udHJvbGxlci4gQSBwbGF0Zm9ybSBkcml2ZXIKPiA+IHBhc3NlcyBhIGNicXJpX2NvbnRy b2xsZXJfaW5mbyBkZXNjcmlwdG9yIHRvZ2V0aGVyIHdpdGggdGhlIGNhY2hlIGxldmVsCj4gPiB0 byByaXNjdl9jYnFyaV9yZWdpc3Rlcl9jY19kdCgpLCB3aGljaCBwcm9iZXMgdGhlIGNvbnRyb2xs ZXIgYW5kIGFkZHMgaXQKPiA+IHRvIHRoZSBjb250cm9sbGVyIGxpc3QuCj4gPgo+ID4gQXNzaXN0 ZWQtYnk6IExMTQo+ID4gQ28tZGV2ZWxvcGVkLWJ5OiBBZHJpZW4gUmljY2lhcmRpIDxhcmljY2lh cmRpQGJheWxpYnJlLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IEFkcmllbiBSaWNjaWFyZGkgPGFy aWNjaWFyZGlAYmF5bGlicmUuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogRHJldyBGdXN0aW5pIDxm dXN0aW5pQGtlcm5lbC5vcmc+Cj4gPiAtLS0KPiA+ICBNQUlOVEFJTkVSUyAgICAgICAgICAgICAg ICAgICAgICB8ICAgMyArCj4gPiAgZHJpdmVycy9yZXNjdHJsL0tjb25maWcgICAgICAgICAgfCAg IDkgKwo+ID4gIGRyaXZlcnMvcmVzY3RybC9NYWtlZmlsZSAgICAgICAgIHwgICAzICsKPiA+ICBk cml2ZXJzL3Jlc2N0cmwvY2JxcmlfZGV2aWNlcy5jICB8IDU3NCArKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysKPiA+ICBkcml2ZXJzL3Jlc2N0cmwvY2JxcmlfaW50ZXJuYWwu aCB8IDEyMiArKysrKysrKysKPiA+ICBpbmNsdWRlL2xpbnV4L3Jpc2N2X2NicXJpLmggICAgICB8 ICA0NSArKysKPiA+ICA2IGZpbGVzIGNoYW5nZWQsIDc1NiBpbnNlcnRpb25zKCspClsuLl0KPiA+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL3Jlc2N0cmwvY2JxcmlfZGV2aWNlcy5jIGIvZHJpdmVycy9y ZXNjdHJsL2NicXJpX2RldmljZXMuYwo+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiA+IGluZGV4 IDAwMDAwMDAwMDAwMC4uODdkNGVjZjhmMTQxCj4gPiAtLS0gL2Rldi9udWxsCj4gPiArKysgYi9k cml2ZXJzL3Jlc2N0cmwvY2JxcmlfZGV2aWNlcy5jClsuLl0KPiA+ICtzdGF0aWMgaW50IGNicXJp X3Byb2JlX2NvbnRyb2xsZXIoc3RydWN0IGNicXJpX2NvbnRyb2xsZXIgKmN0cmwpCj4gPiArewpb Li5dCj4gPiArCj4gPiArICAgICAgIGlmICghcmVxdWVzdF9tZW1fcmVnaW9uKGN0cmwtPmFkZHIs IGN0cmwtPnNpemUsICJjYnFyaV9jb250cm9sbGVyIikpIHsKPiA+ICsgICAgICAgICAgICAgICBw cl9lcnIoInJlcXVlc3RfbWVtX3JlZ2lvbiBmYWlsZWQgZm9yICVwYVxuIiwgJmN0cmwtPmFkZHIp Owo+ID4gKyAgICAgICAgICAgICAgIHJldHVybiAtRUJVU1k7Cj4gPiArICAgICAgIH0KPiA+ICsK PiBBcG9sb2dpZXMgZm9yIGp1bXBpbmcgb24gdGhpcyBsYXRlLiBCdXQgd2h5IG5vdCBzaW1wbHkg dXNlCj4gZGV2bV9wbGF0Zm9ybV9pb3JlbWFwX3Jlc291cmNlKCkgPwoKVGhpcyBpcyBhbiBhcnRp ZmFjdCBvZiBteSBmdWxsZXIgUkZDIHNlcmllcyB3aGljaCBpbXBsZW1lbnRlZCBSUVNDIGFzCndl bGwuIEZvciBBQ1BJLCBpdCByZWdpc3RlcnMgY29udHJvbGxlcnMgZGlyZWN0bHkgZnJvbSB0aGUg UlFTQyB0YWJsZQp3aXRob3V0IGEgcGxhdGZvcm0gZGV2aWNlLgoKQnV0IHlvdSBtYWtlIGEgZ29v ZCBwb2ludCBhbmQgdGhpcyBpcyB3aGF0IE1QQU0gZG9lcyBhcyB3ZWxsLiBJIHdpbGwKc3dpdGNo IHRvIGRldm1fcGxhdGZvcm1fZ2V0X2FuZF9pb3JlbWFwX3Jlc291cmNlKCkgYW5kIGFkZCBhIGJh c2UgZmllbGQKdG8gY2JxcmlfY29udHJvbGxlcl9pbmZvLgoKPiA+ICsvKioKPiA+ICsgKiByaXNj dl9jYnFyaV9yZWdpc3Rlcl9jY19kdCgpIC0gcmVnaXN0ZXIgYSBEVC1kZXNjcmliZWQgY2FwYWNp dHkgY29udHJvbGxlcgo+ID4gKyAqIEBpbmZvOiAgICAgICAgcmVnaXN0cmF0aW9uIGRlc2NyaXB0 b3IuIGluZm8tPmNhY2hlX2lkIGlzIHVzZWQgYXMgdGhlCj4gPiArICogICAgICAgICAgICAgICBy ZXNjdHJsIGRvbWFpbiBpZC4gaW5mby0+dHlwZSBtdXN0IGJlIENBUEFDSVRZLgo+ID4gKyAqIEBj YWNoZV9sZXZlbDogY2FjaGUgbGV2ZWwgKDIgb3IgMykgdGhlIGNvbnRyb2xsZXIgYmFja3MsIG1h cHBlZCB0byB0aGUKPiA+ICsgKiAgICAgICAgICAgICAgIHJlc2N0cmwgTDIvTDMgcmVzb3VyY2Ug YnkgdGhlIHJlc2N0cmwgZ2x1ZS4KPiA+ICsgKgo+ID4gKyAqIFRoZSBjYWNoZSBsZXZlbCBhbmQg aWQgKGluZm8tPmNhY2hlX2lkKSBhcmUgc3VwcGxpZWQgZGlyZWN0bHkgYnkgdGhlCj4gPiArICog Y2FsbGVyLCB3aGljaCByZXNvbHZlcyB0aGVtIGZyb20gY2FjaGVpbmZvLiBEb21haW4gbWVtYmVy c2hpcCBpcyByZXNvbHZlZAo+ID4gKyAqIHBlciBDUFUgYXQgaG90cGx1Zywgc28gbm8gY3B1IG1h c2sgaXMgc3RvcmVkLiBUaGVyZSBpcyBubyBmaXJtd2FyZSB0YWJsZQo+ID4gKyAqIHRvIHJlc29s dmUgYW55IG9mIHRoaXMgZnJvbS4KPiA+ICsgKgo+ID4gKyAqIFJldHVybjogMCBvbiBzdWNjZXNz LCAtRUVYSVNUIHdoZW4gYSBjb250cm9sbGVyIGZvciB0aGUgc2FtZSBjYWNoZSBsZXZlbAo+ID4g KyAqIGFuZCBpZCBpcyBhbHJlYWR5IHJlZ2lzdGVyZWQsIG9yIGFub3RoZXIgbmVnYXRpdmUgZXJy bm8gb24gZmFpbHVyZS4KPiA+ICsgKi8KPiA+ICtpbnQgcmlzY3ZfY2JxcmlfcmVnaXN0ZXJfY2Nf ZHQoY29uc3Qgc3RydWN0IGNicXJpX2NvbnRyb2xsZXJfaW5mbyAqaW5mbywKPiA+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB1MzIgY2FjaGVfbGV2ZWwpCj4gPgo+IFdoYXQgaXMgRFQg c3BlY2lmaWMgY29kZSBpbiB0aGlzIGZ1bmN0aW9uPyBJTU8sIGl0IGlzIGJldHRlciB0byBnYXRo ZXIKPiBhbGwgaW5mb3JtYXRpb24gaW4gdGhlIG1haW4KPiBkcml2ZXIgaXRzZWxmIGludG8gYSBn ZW5lcmljICJpbmZvIiBzdHJ1Y3R1cmUuIFRoYXQgd2F5LCBhbGwgQUNQSSB2cwo+IERUIGRpZmZl cmVuY2VzIHdpbGwgYmUgaGFuZGxlZCBpbgo+IG9uZSBwbGFjZSBhbmQgZXZlcnl0aGluZyBmdXJ0 aGVyIHdpbGwgYmUgZ2VuZXJpYy4KClRoZXJlIGlzIG5vdGhpbmcgdGhhdCBpcyBEVCBzcGVjaWZp YyBiZXlvbmQgbmVlZGluZyB0byBwYXNzIHRoZSBjYWNoZQpsZXZlbCB3aGVyZWFzIEFDUEkgY2Fu IGRldGVybWluZSBpdCBmcm9tIFBQVFQuCgpCdXQgSSB0aGluayBpdCB3b3VsZCBtYWtlIHNlbnNl IHRvIGJlIG1vcmUgZ2VuZXJpYy4gSSB3aWxsIG1vdmUKY2FjaGVfbGV2ZWwgaW50byBjYnFyaV9j b250cm9sbGVyX2luZm8gYW5kIGRyb3AgdGhlIF9kdCBzdWZmaXguCgpbLi5dCj4gPiArICAgICAg IC8qCj4gPiArICAgICAgICAqIFNSTUNGRyBlbmNvZGVzIFJDSUQgaW4gMTIgYml0cy4gUmVqZWN0 IGFuIG91dC1vZi1yYW5nZSBjb3VudCByYXRoZXIKPiA+ICsgICAgICAgICogdGhhbiBzaWxlbnRs eSB0cnVuY2F0aW5nIGluIGV2ZXJ5IEZJRUxEX1BSRVAoU1JNQ0ZHX1JDSURfTUFTSywgY2xvc2lk KQo+ID4gKyAgICAgICAgKiBvbiB0aGUgc2NoZWR1bGUtaW4gZmFzdCBwYXRoLgo+ID4gKyAgICAg ICAgKi8KPiA+ICsgICAgICAgaWYgKGN0cmwtPnJjaWRfY291bnQgPiBGSUVMRF9NQVgoU1JNQ0ZH X1JDSURfTUFTSykgKyAxKSB7Cj4gPiArICAgICAgICAgICAgICAgcHJfd2FybigiQ0MgYXQgJXBh IGhhcyBSQ0lEIGNvdW50ICV1IGJleW9uZCB0aGUgMTItYml0IFNSTUNGRyBmaWVsZCwgc2tpcHBp bmdcbiIsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAmY3RybC0+YWRkciwgY3RybC0+cmNp ZF9jb3VudCk7Cj4gPiArICAgICAgICAgICAgICAgY2JxcmlfY29udHJvbGxlcl9kZXN0cm95KGN0 cmwpOwo+ID4KPiBBbnkgcmVhc29uIHRvIGhhdmUgZXhwbGljaXQgY2xlYW51cHMgPwoKTm8uIEkg d2lsbCBtb3ZlIHRoZSBpbmZvLT5yY2lkX2NvdW50IGNoZWNrIGJlZm9yZSBhbGxvY2F0aW9uIGFu ZCB1c2UKX19mcmVlKCkgZm9yIHRoZSBjb250cm9sbGVyLgoKWy4uXQo+ID4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvcmVzY3RybC9jYnFyaV9pbnRlcm5hbC5oIGIvZHJpdmVycy9yZXNjdHJsL2NicXJp X2ludGVybmFsLmgKWy4uXQo+ID4gK2V4dGVybiBzdHJ1Y3QgbGlzdF9oZWFkIGNicXJpX2NvbnRy b2xsZXJzOwo+ID4gK2V4dGVybiBzdHJ1Y3QgbXV0ZXggY2JxcmlfY29udHJvbGxlcnNfbG9jazsK PiA+ICsKPiA+Cj4gQ2FuIHRoZXNlIGJlIG1hZGUgc3RhdGljIGluIGNicXJpX2RldmljZXMuYyBh bmQgcHJvdmlkZSBBUEkgZm9yIGNicXJpX3Jlc2N0cmwuYz8KClllcywgdGhlIG9ubHkgdXNlIG91 dHNpZGUgb2YgY2JxcmlfZGV2aWNlcy5jIGlzCmNicXJpX3Jlc2N0cmxfcGlja19jYWNoZXMoKS4g SSB3aWxsIG1ha2UgYm90aCBzdGF0aWMgYW5kIGFkZCBhIGhlbHBlcgp0aGF0IHJldHVybnMgdGhl IHJlZ2lzdGVyZWQgY29udHJvbGxlcnMuCgpUaGFua3MsCkRyZXcKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdAps aW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8B352030A; Fri, 16 Oct 2026 00:06:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792109187; cv=none; b=HrstzWFfYZSR4400t3cj+LA65k0RT4wiOU79CaURfBhoNAQvS2+B/5EjFM3DwFrFT4bMV2m0qszFJrSSx/qEU2hSBfW1m75WnTdrJJVkRAocblzzv0KGKZMTWAwGLFEUY4/FqSiX5kQtMyeunZfK+tNW4ZdNli9qr6aPNLAtneM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792109187; c=relaxed/simple; bh=JQNlIBOrQQ4CZzFwrfBRyxU2RHdddOs451H/qbf3jVQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Qf2Xye0uyfE1BTGBcS4jQXx1pqpbbb8XdC1xqvlPKwssIX6s9tkmBcU2KreeY73qeuwvtKoxF1/R4Ztx8RpYnUQlBrYwdgkhrLqJk9mteVbP3aOQB36PBuDTGFjIqHtfYtOrQ3aIriIU8iAHvmcS7jOeX0TXAiEAncTc1W7qIR8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oOHnLwpw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oOHnLwpw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CB1C1F000C4; Fri, 16 Oct 2026 00:06:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792109186; bh=lj0QXNDYWzykhho+9TgSGkXQQEpotIYDIIMXMua7eT8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=oOHnLwpwzXtkpHlf/6U6iF7vR87WzvWbEDkOSs+3dp8FKUwEDtOEWfd+6JMd2ssjz GksAiaUpsIWqUo0dFVk155pkKrt/uQGX1NYw1QEdERp+A1Nt6fjyyEr0VjxDe3MTLn y3tG+1pIiDhw0uPafqBUYvc9Ob3kIiwceYOBmf8l7m9JtxTkieKn+UDxCnUf+6eCLS OeTrKt80VAXQzJyVsPTmXXwbritv3DMzHM+pKHlhVzZH8TactA4tSM7tc2hImMGgUV ren66sBe8znD4ykW994KGmIo/iQIXn+69G6S9pkjIAYVzlA6PWgkL1vtq3LBsyYzxv dfLtdDCrcOvRw== Date: Thu, 15 Oct 2026 17:06:24 -0700 From: Drew Fustini To: Sunil V L Cc: Adrien Ricciardi , Alexandre Ghiti , Albert Ou , Atish Patra , Babu Moger , Ben Horgan , Borislav Petkov , Chen Pei , Conor Dooley , Conor Dooley , Dave Hansen , Dave Martin , Fenghua Yu , Gong Shuai , Gong Shuai , guo.wenjia23@zte.com.cn, James Morse , Kornel =?utf-8?Q?Dul=C4=99ba?= , Krzysztof Kozlowski , liu.qingtao2@zte.com.cn, Liu Zhiwei , Palmer Dabbelt , Paul Walmsley , Peter Newman , Radim =?utf-8?B?S3LEjW3DocWZ?= , Reinette Chatre , Rob Herring , Samuel Holland , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt , Tony Luck , Vasudevan Srinivasan , Ved Shanbhogue , Weiwei Li , yunhui cui , Zhanpeng Zhang , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, devicetree@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-doc@vger.kernel.org Subject: Re: [PATCH v9 1/5] riscv_cbqri: Add capacity controller probe and allocation device ops Message-ID: References: <20261003-dfustini-atl-sc-cbqri-dt-v9-0-52fd8be98dcf@kernel.org> <20261003-dfustini-atl-sc-cbqri-dt-v9-1-52fd8be98dcf@kernel.org> Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Oct 12, 2026 at 09:42:59PM +0530, Sunil V L wrote: > Hi Drew! Hi Sunil, thanks for reviewing! > On Sat, Oct 3, 2026 at 12:45 PM Drew Fustini wrote: > > > > Add support for the RISC-V CBQRI capacity controller. A platform driver > > passes a cbqri_controller_info descriptor together with the cache level > > to riscv_cbqri_register_cc_dt(), which probes the controller and adds it > > to the controller list. > > > > Assisted-by: LLM > > Co-developed-by: Adrien Ricciardi > > Signed-off-by: Adrien Ricciardi > > Signed-off-by: Drew Fustini > > --- > > MAINTAINERS | 3 + > > drivers/resctrl/Kconfig | 9 + > > drivers/resctrl/Makefile | 3 + > > drivers/resctrl/cbqri_devices.c | 574 +++++++++++++++++++++++++++++++++++++++ > > drivers/resctrl/cbqri_internal.h | 122 +++++++++ > > include/linux/riscv_cbqri.h | 45 +++ > > 6 files changed, 756 insertions(+) [..] > > diff --git a/drivers/resctrl/cbqri_devices.c b/drivers/resctrl/cbqri_devices.c > > new file mode 100644 > > index 000000000000..87d4ecf8f141 > > --- /dev/null > > +++ b/drivers/resctrl/cbqri_devices.c [..] > > +static int cbqri_probe_controller(struct cbqri_controller *ctrl) > > +{ [..] > > + > > + if (!request_mem_region(ctrl->addr, ctrl->size, "cbqri_controller")) { > > + pr_err("request_mem_region failed for %pa\n", &ctrl->addr); > > + return -EBUSY; > > + } > > + > Apologies for jumping on this late. But why not simply use > devm_platform_ioremap_resource() ? This is an artifact of my fuller RFC series which implemented RQSC as well. For ACPI, it registers controllers directly from the RQSC table without a platform device. But you make a good point and this is what MPAM does as well. I will switch to devm_platform_get_and_ioremap_resource() and add a base field to cbqri_controller_info. > > +/** > > + * riscv_cbqri_register_cc_dt() - register a DT-described capacity controller > > + * @info: registration descriptor. info->cache_id is used as the > > + * resctrl domain id. info->type must be CAPACITY. > > + * @cache_level: cache level (2 or 3) the controller backs, mapped to the > > + * resctrl L2/L3 resource by the resctrl glue. > > + * > > + * The cache level and id (info->cache_id) are supplied directly by the > > + * caller, which resolves them from cacheinfo. Domain membership is resolved > > + * per CPU at hotplug, so no cpu mask is stored. There is no firmware table > > + * to resolve any of this from. > > + * > > + * Return: 0 on success, -EEXIST when a controller for the same cache level > > + * and id is already registered, or another negative errno on failure. > > + */ > > +int riscv_cbqri_register_cc_dt(const struct cbqri_controller_info *info, > > + u32 cache_level) > > > What is DT specific code in this function? IMO, it is better to gather > all information in the main > driver itself into a generic "info" structure. That way, all ACPI vs > DT differences will be handled in > one place and everything further will be generic. There is nothing that is DT specific beyond needing to pass the cache level whereas ACPI can determine it from PPTT. But I think it would make sense to be more generic. I will move cache_level into cbqri_controller_info and drop the _dt suffix. [..] > > + /* > > + * SRMCFG encodes RCID in 12 bits. Reject an out-of-range count rather > > + * than silently truncating in every FIELD_PREP(SRMCFG_RCID_MASK, closid) > > + * on the schedule-in fast path. > > + */ > > + if (ctrl->rcid_count > FIELD_MAX(SRMCFG_RCID_MASK) + 1) { > > + pr_warn("CC at %pa has RCID count %u beyond the 12-bit SRMCFG field, skipping\n", > > + &ctrl->addr, ctrl->rcid_count); > > + cbqri_controller_destroy(ctrl); > > > Any reason to have explicit cleanups ? No. I will move the info->rcid_count check before allocation and use __free() for the controller. [..] > > diff --git a/drivers/resctrl/cbqri_internal.h b/drivers/resctrl/cbqri_internal.h [..] > > +extern struct list_head cbqri_controllers; > > +extern struct mutex cbqri_controllers_lock; > > + > > > Can these be made static in cbqri_devices.c and provide API for cbqri_resctrl.c? Yes, the only use outside of cbqri_devices.c is cbqri_resctrl_pick_caches(). I will make both static and add a helper that returns the registered controllers. Thanks, Drew