From: Benjamin Tissoires <bentiss@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Michael Zaidman <michael.zaidman@gmail.com>,
Rishi Gupta <gupt21@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
David Barksdale <dbarksdale@uplogix.com>,
Andrej Shadura <andrew@shadura.me>,
Johannes Roith <johannes@gnu-linux.rocks>,
linux-input@vger.kernel.org, linux-bluetooth@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] HID: hidraw: Encapsulate struct hidraw and make hidraw.h private
Date: Fri, 16 Oct 2026 12:15:54 +0200 [thread overview]
Message-ID: <atH4tx8B_alkLgu9@beelink> (raw)
In-Reply-To: <20261014051326.3784498-1-dmitry.torokhov@gmail.com>
Hi Dmitry,
On Oct 13 2026, Dmitry Torokhov wrote:
> This series cleans up internal HID core and hidraw header boundaries.
>
> First, internal HID core declarations and unused symbol exports are
> moved out of include/linux/hid.h into a private drivers/hid/hid-core.h
> header. Next, a hidraw_instance() accessor is introduced in
> include/linux/hidraw.h so HID drivers that only need the hidraw minor
> number for naming or debug logging no longer dereference struct hidraw
> directly. After converting the drivers and dropping unused
> linux/hidraw.h includes, hidraw.h is moved to drivers/hid/hidraw.h and
> struct hidraw along with its internal buffer and list structures are
> made private to drivers/hid/hidraw.c.
Series looks good to me. However I have a couple of hiccups:
- the series doesn't apply cleanly on v7.3 (conflict in
include/linux/hid.h, which seems 7.2 based), and also not on v7.2
(conflict in 2/5 this time around)
- Jinmo kind of hijacked the series, and now b4 thinks 1/6 is Jinmo's patch.
Would you mind respinning it on top of 7.3-rc7 or hid.git/for-next?
Cheers,
Benjamin
>
> Dmitry Torokhov (5):
> HID: core: Move internal declarations and drop unused exports
> HID: hidraw: Introduce hidraw_instance() helper
> HID: Use hidraw_instance() in drivers
> HID: Drop unused linux/hidraw.h includes
> HID: hidraw: Make hidraw.h private to HID subsystem
>
> drivers/hid/Kconfig | 3 ++
> drivers/hid/hid-core.c | 7 ++--
> drivers/hid/hid-core.h | 20 +++++++++++
> drivers/hid/hid-cp2112.c | 15 ++++----
> drivers/hid/hid-ft260.c | 2 +-
> drivers/hid/hid-input.c | 4 +--
> drivers/hid/hid-led.c | 10 ++++--
> drivers/hid/hid-mcp2200.c | 1 -
> drivers/hid/hid-mcp2221.c | 1 -
> drivers/hid/hid-quirks.c | 1 +
> drivers/hid/hid-u2fzero.c | 10 ++++--
> drivers/hid/hid-winwing.c | 1 -
> drivers/hid/hidraw.c | 48 ++++++++++++++++++++++---
> {include/linux => drivers/hid}/hidraw.h | 32 +++--------------
> drivers/hid/usbhid/hid-core.c | 1 -
> include/linux/hid.h | 8 -----
> net/bluetooth/hidp/core.c | 1 -
> 17 files changed, 100 insertions(+), 65 deletions(-)
> create mode 100644 drivers/hid/hid-core.h
> rename {include/linux => drivers/hid}/hidraw.h (58%)
>
> --
> 2.56.0.385.gd3acb90ef8-goog
>
prev parent reply other threads:[~2026-10-16 10:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 5:13 [PATCH 0/5] HID: hidraw: Encapsulate struct hidraw and make hidraw.h private Dmitry Torokhov
2026-10-14 5:13 ` [PATCH 1/5] HID: core: Move internal declarations and drop unused exports Dmitry Torokhov
2026-10-14 6:35 ` HID: hidraw: Encapsulate struct hidraw and make hidraw.h private bluez.test.bot
2026-10-14 5:13 ` [PATCH 2/5] HID: hidraw: Introduce hidraw_instance() helper Dmitry Torokhov
2026-10-14 5:13 ` [PATCH 3/5] HID: Use hidraw_instance() in drivers Dmitry Torokhov
2026-10-14 10:38 ` [PATCH] HID: cp2112: don't dereference hdev->hidraw unconditionally Jinmo Yang
2026-10-14 13:50 ` Benjamin Tissoires
2026-10-14 5:13 ` [PATCH 4/5] HID: Drop unused linux/hidraw.h includes Dmitry Torokhov
2026-10-14 5:13 ` [PATCH 5/5] HID: hidraw: Make hidraw.h private to HID subsystem Dmitry Torokhov
2026-10-16 10:15 ` Benjamin Tissoires [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atH4tx8B_alkLgu9@beelink \
--to=bentiss@kernel.org \
--cc=andrew@shadura.me \
--cc=dbarksdale@uplogix.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gupt21@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=jikos@kernel.org \
--cc=johannes@gnu-linux.rocks \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=michael.zaidman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.