From: Dan Carpenter <error27@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Alexander Aring <aahringo@redhat.com>,
gfs2@lists.linux.dev, kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
David Teigland <teigland@redhat.com>
Subject: Re: dlm: clean up a type in waiters_read()
Date: Fri, 16 Oct 2026 12:14:36 +0300 [thread overview]
Message-ID: <atHq_LLtPx8SXMUt@stanley.mountain> (raw)
In-Reply-To: <c8b6843c-c87a-4330-b6f4-e556117a8026@web.de>
On Tue, Oct 13, 2026 at 05:27:10PM +0200, Markus Elfring wrote:
> >>> This doesn't affect runtime but "rv" stores error codes and so
> >>> declare it as ssize_t instead of size_t.
> >>
> >> Can a similar adjustment matter also for the local variable “ret”?
> >
> > What do you mean by 'matter'? It's declared as cleanup.
> Can the usage of a data type like “int” become more desirable for “ret”
> according to the affected function implementation?
Either way is a defensible style choice for "ret" so I left it as-is.
regards,
dan carpenter
next prev parent reply other threads:[~2026-10-16 9:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 6:44 [PATCH] dlm: clean up a type in waiters_read() Dan Carpenter
2026-10-01 23:11 ` Alexander Aring
2026-10-11 12:11 ` Markus Elfring
2026-10-13 13:07 ` Alexander Aring
2026-10-13 15:27 ` Markus Elfring
2026-10-16 9:14 ` Dan Carpenter [this message]
2026-10-16 11:55 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atHq_LLtPx8SXMUt@stanley.mountain \
--to=error27@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=aahringo@redhat.com \
--cc=gfs2@lists.linux.dev \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.