All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liviu Dudau <liviu.dudau@arm.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: Steven Price <steven.price@arm.com>,
	Akash Goel <akash.goel@arm.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Chia-I Wu <olvaffe@gmail.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] drm/panthor: Misc MMU fixes/robustness improvements
Date: Fri, 16 Oct 2026 13:25:29 +0100	[thread overview]
Message-ID: <atIXudY6VCIdO2Tc@e142607> (raw)
In-Reply-To: <20260924-panthor-mmu-fixes-v1-0-e25f9b106466@collabora.com>

On Thu, Sep 24, 2026 at 02:30:42PM +0200, Boris Brezillon wrote:
> The first commit is fixing a bug we've seen on v13 HW. Even though
> we don't quite understand what happens (race in the flush-elimination
> logic when flush requests are sent concurrently from the CPU and the
> MCU), it seems that the downstream driver has always been doing a
> flush+invalidate of RW caches from the start, and that we were doing
> so up until the atomic page table update changes, so let's go back to
> that state and leave the RO L1 caches untouched.
> 
> The second patch a fix for a race that could very well happen if we
> ever end up with a failure between the as_disable() and as_enable()
> calls. We've not experienced this so far, but it seems worth plugging
> the hole regardless. The last patch is a much more theoretical bug,
> which would involve a buggy FW telling us that a CSG is suspended,
> when it's actually. I've deliberately not added a Fixes tag on the
> last one for this very reason, but I think it's worth staying on
> the safe side by addressing this theoretical issue, still.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
> Boris Brezillon (3):
>       drm/panthor: Don't invalidate OTHER caches
>       drm/panthor: Fully disable the AS even if it's going to be re-assigned
>       drm/panthor: Move cache-flush after UPDATE(UNMAPPED)
> 
>  drivers/gpu/drm/panthor/panthor_mmu.c | 43 ++++++++++++++++-------------------
>  1 file changed, 20 insertions(+), 23 deletions(-)
> ---
> base-commit: 45585c3aa285854face65293acc95eff73063d6d
> change-id: 20260924-panthor-mmu-fixes-a1832dc60908
> 
> Best regards,
> --  
> Boris Brezillon <boris.brezillon@collabora.com>
> 

Pushed the whole series into drm-misc-next-fixes after updating the comment
on 1/3 as suggested by sashiko.

Best regards,
Liviu

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯

      parent reply	other threads:[~2026-10-16 12:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24 12:30 [PATCH 0/3] drm/panthor: Misc MMU fixes/robustness improvements Boris Brezillon
2026-09-24 12:30 ` [PATCH 1/3] drm/panthor: Don't invalidate OTHER caches Boris Brezillon
2026-09-24 12:36   ` sashiko-bot
2026-10-16 10:37   ` Liviu Dudau
2026-09-24 12:30 ` [PATCH 2/3] drm/panthor: Fully disable the AS even if it's going to be re-assigned Boris Brezillon
2026-10-16 10:38   ` Liviu Dudau
2026-09-24 12:30 ` [PATCH 3/3] drm/panthor: Move cache-flush after UPDATE(UNMAPPED) Boris Brezillon
2026-10-16 10:41   ` Liviu Dudau
2026-10-16 12:25 ` Liviu Dudau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atIXudY6VCIdO2Tc@e142607 \
    --to=liviu.dudau@arm.com \
    --cc=airlied@gmail.com \
    --cc=akash.goel@arm.com \
    --cc=boris.brezillon@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=olvaffe@gmail.com \
    --cc=simona@ffwll.ch \
    --cc=steven.price@arm.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.