On Thu, Oct 15, 2026 at 08:07:45AM -0300, Maíra Canal wrote:
> Hi Maxime,
> 
> On 14/10/26 14:27, Maxime Ripard wrote:
> > The vc4 HDMI connector reset implementation creates a pristine state,
> > initializes the HDMI state, and sets the TV margins. It does not
> > perform any hardware reset.
> > 
> > Since this is equivalent to what atomic_create_state expects, convert
> > the reset function to an atomic_create_state hook that returns the
> > initialized state.
> > 
> > Signed-off-by: Maxime Ripard <mripard@kernel.org>
> 
> The order of the parameters in
> __drm_atomic_helper_connector_hdmi_state_init() bothers me a bit, as
> it's the reverse of drm_atomic_helper_connector_tv_margins_state_init(),

You're right, I'll send a patch to align
__drm_atomic_helper_connector_hdmi_state_init() with the same convention
we have for all other _state_init helpers

Thanks!
Maxime