Re: ASUS T302CHI keyboard dock (0b05:182f) missing from hid-asus, brightness keys dead

[Benjamin Tissoires <bentiss@kernel.org>]

On Oct 16 2026, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.com>

You are missing a proper title, and FWIW, b4 doesn't recognize this as a
patch.

> 
> synonym reports: "The dock (USB 0b05:182f) reports brightness on the ASUS
> vendor usage page 0xff31, usages 0x10 and 0x20, which hid-asus already maps to
> KEY_BRIGHTNESSDOWN / KEY_BRIGHTNESSUP. Because the device is not in
> asus_devices[], it is claimed by hid-generic, which ignores the vendor page
> entirely, so Fn+F5 and Fn+F6 produce no input events at all - not even a
> scancode. Keys on the standard consumer page (volume) on the same device work
> fine, which makes this look like a backlight or ACPI problem rather than a HID
> one."
> 
> Add the device ID.
> 
> Reported-by: synonym <20000l@pm.me>
> Signed-off-by: Jiri Kosina <jkosina@suse.com>

Anyway, feel free to push it to for-7.4/hid-asus with my:

Acked-by: Benjamin Tissoires <bentiss@kernel.org>

Cheers,
Benjamin

> ---
>  drivers/hid/hid-asus.c | 2 ++
>  drivers/hid/hid-ids.h  | 1 +
>  2 files changed, 3 insertions(+)
> 
> diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
> index ec966fc0a411..42655a6d59d9 100644
> --- a/drivers/hid/hid-asus.c
> +++ b/drivers/hid/hid-asus.c
> @@ -1733,6 +1733,8 @@ static const struct hid_device_id asus_devices[] = {
>  	  QUIRK_USE_KBD_BACKLIGHT | QUIRK_ROG_NKEY_KEYBOARD },
>  	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
>  		USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_T101HA_KEYBOARD) },
> +	{ HID_DEVICE(BUS_USB, HID_GROUP_GENERIC,
> +		USB_VENDOR_ID_ASUSTEK, USB_DEVICE_ID_ASUSTEK_T302CHI_KEYBOARD) },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(hid, asus_devices);
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 43bbddf84e61..63d69d49ee50 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -218,6 +218,7 @@
>  #define USB_DEVICE_ID_ASUSTEK_T100TAF_KEYBOARD	0x1807
>  #define USB_DEVICE_ID_ASUSTEK_T100CHI_KEYBOARD	0x8502
>  #define USB_DEVICE_ID_ASUSTEK_T101HA_KEYBOARD	0x183d
> +#define USB_DEVICE_ID_ASUSTEK_T302CHI_KEYBOARD	0x182f
>  #define USB_DEVICE_ID_ASUSTEK_T304_KEYBOARD	0x184a
>  #define USB_DEVICE_ID_ASUSTEK_I2C_KEYBOARD	0x8585
>  #define USB_DEVICE_ID_ASUSTEK_I2C_ZENBOOK_KEYBOARD	0x4b42
> 
> -- 
> Jiri Kosina
> SUSE Labs
> 
>