From: Daniel Thompson <danielt@kernel.org>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Jingoo Han <jingoohan1@gmail.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, mfd@lists.linux.dev,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 2/4] mfd: aat2870: Derive brightness steps from max current
Date: Fri, 16 Oct 2026 16:30:29 +0100 [thread overview]
Message-ID: <atJDFRXmgZ37GrCE@aspen.lan> (raw)
In-Reply-To: <20261013180933.487013-3-clamor95@gmail.com>
On Tue, Oct 13, 2026 at 09:09:31PM +0300, Svyatoslav Ryhel wrote:
> @@ -69,10 +57,11 @@ static int aat2870_bl_update_status(struct backlight_device *bd)
> dev_dbg(&bd->dev, "brightness=%d, power=%d, state=%d\n",
> bd->props.brightness, bd->props.power, bd->props.state);
>
> - ret = aat2870->write(aat2870, AAT2870_BLM,
> - (u8)aat2870_brightness(aat2870_bl, brightness));
> - if (ret < 0)
> - return ret;
> + if (brightness) {
> + ret = aat2870->write(aat2870, AAT2870_BLM, (u8)brightness - 1);
> + if (ret < 0)
> + return ret;
> + }
>
> if (brightness == 0) {
I think this could be spelled "else" ;-)
However, other than this this looks good. With that change applied:
Reviewed-by: Daniel Thompson (RISCstar) <danielt@kernel.org>
Daniel
next prev parent reply other threads:[~2026-10-16 15:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 18:09 [PATCH v3 0/4] mfd: aat2870: Convert to use OF bindings Svyatoslav Ryhel
2026-10-13 18:09 ` [PATCH v3 1/4] dt-bindings: mfd: Document Skyworks AAT2870 Svyatoslav Ryhel
2026-10-13 18:16 ` sashiko-bot
2026-10-16 15:23 ` Daniel Thompson
2026-10-13 18:09 ` [PATCH v3 2/4] mfd: aat2870: Derive brightness steps from max current Svyatoslav Ryhel
2026-10-13 18:16 ` sashiko-bot
2026-10-16 15:30 ` Daniel Thompson [this message]
2026-10-16 16:27 ` Svyatoslav Ryhel
2026-10-13 18:09 ` [PATCH v3 3/4] mfd: aat2870: Convert to use OF bindings Svyatoslav Ryhel
2026-10-13 18:21 ` sashiko-bot
2026-10-16 15:34 ` Daniel Thompson
2026-10-13 18:09 ` [PATCH v3 4/4] mfd: aat2870: Add support for VIN and IN-LDO power supplies Svyatoslav Ryhel
2026-10-13 18:18 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atJDFRXmgZ37GrCE@aspen.lan \
--to=danielt@kernel.org \
--cc=broonie@kernel.org \
--cc=clamor95@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.