From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 959603AEF21 for ; Sat, 17 Oct 2026 16:39:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792255173; cv=none; b=e6Pst/WjpOdzCSgCSRHlx3NDuqha4JhuSiWcsKBzuSOnnP+dAY7JUlx9Lmjlfp84ZthvhiKnBoa/yvjgwAiFzGt1rsob2QelIyDOqvoIF8GVgvFlUhDYtEp6O5lZK+yw+00XjRCwWr4bxICZ9w7kQyjp2+fb5HDn1Ot70da/ExI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792255173; c=relaxed/simple; bh=VjJXPVvJ28GFo5oaYh5V0N4OmfzYXgOo11M2D9Ou1Sw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KzRoQbFPOsBd4DimIv+qjdL0BsoOG0bVNFqQc7loUH6PQSYm3TgwoY39eQqF0a8IlmY0+lmVFjYf/NwjgvaMNvKpg06/ZDR+/lFKOo9h2c1Q4PJhfYO/aPYMV7w4zP+LJp6JxEbEpsy9teGJO/3xvYBac8HVu3ExLQ7ktQtyXsk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iqcI3njC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HErIJawx; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iqcI3njC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HErIJawx" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69HGAEhR1179625 for ; Sat, 17 Oct 2026 16:39:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=hz4iIDuDhHEcy2mIuGeKuord 9GLsrFZT6JV2X218PUA=; b=iqcI3njCDzM4e7mRHLw+YV3xmeKx13qdpNpYLO1c uKuJcnhcRz3rtqo+XqDGeMCZv2dURNY8sE4Up/wSPorj21shN+H4P4PvOUiE1k4f HrKJsV+TXCcL1K6rMrtrXUEtT4Vlu4w4TsY7ngl01CsdTZz1rKlYemGVmnu3eNHV +HjThJ6ViFeCJyAVpyHQYmZUV+RGbosOkNtCwmXNHB6OUn0sulMIxvCNKMz7qg71 VvhPs8OoWfwTc1Wwi9VbA8nr0EEah65QxY+qlhZZrIAZfY7QJDXrV6PujpiUFd11 LA1oKqK2zNAXkDqjMldYzsbUJ7V6A2GAOrlTldaC5GhPdA== Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hc0bghdw7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Oct 2026 16:39:30 +0000 (GMT) Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-35d4538fd74so2936059eec.1 for ; Sat, 17 Oct 2026 09:39:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792255170; x=1792859970; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=hz4iIDuDhHEcy2mIuGeKuord9GLsrFZT6JV2X218PUA=; b=HErIJawxF5lJ0QwREIG21d5ruyH1jYT/J+TC7ErmLVmAUiG+BZ6dKxlH8j6DqilzAg jg3RQ25xvauatTKojuuRjJtZa/NUPdMHOgiNF2kz5XbDlzLVgD5g/RHNYG11qS4NHSdc Ol+9nskt/Oyqgvjwg+Ozygrx9+xx9fBLZXqFbvTu84v7hyDnxTMjTEdmKRkpf1QOAsmu o3niBiKUbO5bYSykvq55H4sg8IpfcFiehxuySdlb9xtjd1/o0NOB2FpjFT2ZY+90CXdA hCn/nSvwrLi341GxoBWkRvxDBePphPF8M5LIjqHa9cvXNkhjL3ssvxe1LN6xbcgLKlif RFZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792255170; x=1792859970; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hz4iIDuDhHEcy2mIuGeKuord9GLsrFZT6JV2X218PUA=; b=VP4YS+q3HNsjI8Ud8pMnvCNhlZaYes4xr4kQX/0V5Rsh+kk2BUw08JwGAUUlxIJesg jag3wPn+S2JZXb8xE5iHULqJoEMnBAY278/ZvhBgju5OdGnp4c6pXqjxO2p1YDvL6E5k np2Pkd7Akzt2ul2O5aems+pCjtfRT4EKgAPtR2YHNWQPjfe3A7JpOcwY4uoAlvE6dILt 0g0zpSXZ5lvvvLVNFviL4iUItWGNhbvwQz/U0mVZXdkzUYmisnuFh486O5vJJV1kp1Dh bHq2XmlOWNznxFr7AddRZpTjELMOpslvfpZaSqX7qdMdwC13k9LgR4bpJeLNYga83cwG 22sA== X-Forwarded-Encrypted: i=1; AKwUvBxVItuvWkPmvQDipOE4PsC15ldFdVaP6IdTKalPkiIqmeMhMNgObVXpQMDuRO8q4e3ClIY=@lists.linux.dev X-Gm-Message-State: AFq9FYIgbm9bLdOIZH8PM4RM+KJpFCDerlQoxPUbIE93aphZfpCQBQwX QtSNRidQuW3uHZXPJQQ61DMVzWRAT9/B55y1+DT8DKXCVuF86/TRiXnOb9vaoIpc5GrmlHa5Msr KHxSQAMdQC0MinZFYsYrcGLkRK5BsGdGK1PgWFRuUG+fbu3tQ/5l8qDQ= X-Gm-Gg: AYBFou1+A0KOShdzTOZx60LBcR9J+bt5OoftL8kB2KqVvquWgvZnMBydC2kz22bAWir KB6vhXaPHeFOMs4cS3/+bsq+1voffOTmFAKG4fl8zehsMFNB7/zk++bHAnKREh+tArr2wI000Ig 0uI1P7I8rpaMaT8jSDB/fIhtTVxFAg9LqW8OxzGwqLh6u46zK/lSdpBmPZbGWZsMXQLmnVMDoog 1R/s6FEP6CjQi6gqEWL3aGiOtcw3ZY4sYlsFAwonqnAtBO4O9WQDeEkbHqk7OT+AD6NGYqy07Of ys5PMfyCtsmij/ezjre5FS9dxcG8qGUe++CiN4roWEf2vMIS74HvBGIvmJH5P7uB5MJIftfkpxn DeONUEarayDsu X-Received: by 2002:a05:7300:2406:b0:360:5f7e:2eb9 with SMTP id 5a478bee46e88-361a254da08mr4630090eec.32.1792255169746; Sat, 17 Oct 2026 09:39:29 -0700 (PDT) X-Received: by 2002:a05:7300:2406:b0:360:5f7e:2eb9 with SMTP id 5a478bee46e88-361a254da08mr4629905eec.32.1792255166648; Sat, 17 Oct 2026 09:39:26 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-360813b6e33sm17691508eec.7.2026.10.17.09.39.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2026 09:39:26 -0700 (PDT) Date: Sat, 17 Oct 2026 22:09:10 +0530 From: Mohd Ayaan Anwar To: Bartosz Golaszewski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , Bartosz Golaszewski , Eric Dumazet , Radu Rendec , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski Subject: Re: [PATCH net-next v16 4/7] net: stmmac: qcom-ethqos: update phy_mode to the resolved interface in mac_finish() Message-ID: References: <20261014-qcom-sa8255p-emac-v16-0-0266c2ead980@oss.qualcomm.com> <20261014-qcom-sa8255p-emac-v16-4-0266c2ead980@oss.qualcomm.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261014-qcom-sa8255p-emac-v16-4-0266c2ead980@oss.qualcomm.com> X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfXyahv9Cp88xNV D2fKWAG3HrTC04EIxUgOByzzge/h8HOHpKPiNd9b+k1IM2beFPSVXdJVFHc3QF/a96I0iGTCsbm OgzOfhzo5SIuJ07qGd4QGSbtm2bGJsQ= X-Authority-Analysis: v=2.4 cv=FayiV5+6 c=1 sm=1 tr=0 ts=6ad3a4c2 cx=c_pps a=cFYjgdjTJScbgFmBucgdfQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=K33ZUWoUxhUzfzW7EYwA:9 a=CjuIK1q_8ugA:10 a=scEy_gLbYbu1JhEsrz4S:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfXzRb2R+Q0smZk Tkd+Wf3mmTSm6VTkL/wwiddLmAj4lWa0WZCs/oAfrKodbmHbxl6cCJjUUqJPyJYNp40IN1Iz7eB wn1NCLnhx1JMGqkUPU5frmfCBqBUfKFy2/foRMcRkZ15iVe3o9LMzYUoGF3YmwJY2WZelxP9FcI pGs8LsQvyFGd2s1vfUKm/bZGHJXqpkbYY8Vklz3n00Om90ttxa00k6ecZtaC/wz53RP2+Ielk7V atyVrgloR8TflOFHM/ARLzxTXLDUpZaWZO1b8Scagx0yD041/T3QEggmPShM7+PWioANSxgwK4x OWJZblsVkC0yh6Td0R+0NZGz2eR2LRtxwEfT8w19z3OxJf6ZRukVaxYkag5WqnWdVzdUkR1K1cA OAyZFJ8KS06SzZA5PwTAmwcdH2LKfSm02wVhNIBo5C6aZw4D+PlNQR4Ms1B75aNg7KfqMRGKNDL onyexTac3yfUhAqmyOg== X-Proofpoint-ORIG-GUID: hb5CXng2lAnC6wj4z0KRbWwMqUm0KJY8 X-Proofpoint-GUID: hb5CXng2lAnC6wj4z0KRbWwMqUm0KJY8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-17_05,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 clxscore=1015 priorityscore=1501 phishscore=0 bulkscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610170066 On Wed, Oct 14, 2026 at 02:36:43PM +0200, Bartosz Golaszewski wrote: > ethqos->phy_mode is read by serdes_powerup() and > qcom_ethqos_set_sgmii_loopback() to configure the SerDes and its > wrapper for the correct interface. It is set once at probe from the DT > phy-mode property and never updated. > > phylink resolves the actual runtime interface and passes it to the > mac_finish() callback. On platforms that only ever operate at one speed > these two values are always the same, but when the interface changes > at runtime - for example switching between SGMII and 2500BASE-X - the > stored value becomes stale. The next serdes_powerup() call, on > a subsequent link cycle, then reinitializes the SerDes to the wrong mode. > > Update ethqos->phy_mode from the interface argument in > ethqos_mac_finish_serdes() so that it always reflects the last > resolved interface. > > With that, we now update the phy_mode to the runtime-resolved interface, > so any subsequent resume with a 1G SGMII link skips the loopback setup > and the DMA reset hangs. To remedy this, extend the guard to include > PHY_INTERFACE_MODE_SGMII. > > Signed-off-by: Bartosz Golaszewski > --- I am not sure but should this have a Fixes: tag? Reviewed-by: Mohd Ayaan Anwar Ayaan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D692BCCF2C1 for ; Sat, 17 Oct 2026 16:39:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H+PTaM5NXnWp5zNEBCbgCv9hx0j0j4sSi0AC4u8Bt8s=; b=vmu03TwzLgwH9Y mRmNCdlvMdbo3QNeCXMjMX9PSQqaBMvR2Qu1yZmYUzXaMUvpeJMRVz1Jbaq6OLT/ym9EBf8P36rQA KQ3vZWsUWAVN4SWrAFt/Z3KvR8ueGTT6KFJQ4GtQeQmgrqQU5WYoADP1G3mIIQIjF1pZvZUlx1hWq eq21vrGF90pfDNcP2WPeD6vetgoetEvcPN4bWPuo7NzFB7CiocdwYEe/qXpdcLv/UK6zX+iZCPlSp pA/HD/RNegAMvKNloMBrAi7EwW5gqnCfIxZrM7pqQOrGZVd6a0PNBHETtcKnRAvcGXS37mGCS0XWc lrZpcd+FMwzAb6sE2P9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xI7RU-00000004wL2-1Vhp; Sat, 17 Oct 2026 16:39:32 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xI7RR-00000004wJW-28p3 for linux-riscv@lists.infradead.org; Sat, 17 Oct 2026 16:39:31 +0000 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69HG9qEA2031395 for ; Sat, 17 Oct 2026 16:39:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=hz4iIDuDhHEcy2mIuGeKuord 9GLsrFZT6JV2X218PUA=; b=iqcI3njCDzM4e7mRHLw+YV3xmeKx13qdpNpYLO1c uKuJcnhcRz3rtqo+XqDGeMCZv2dURNY8sE4Up/wSPorj21shN+H4P4PvOUiE1k4f HrKJsV+TXCcL1K6rMrtrXUEtT4Vlu4w4TsY7ngl01CsdTZz1rKlYemGVmnu3eNHV +HjThJ6ViFeCJyAVpyHQYmZUV+RGbosOkNtCwmXNHB6OUn0sulMIxvCNKMz7qg71 VvhPs8OoWfwTc1Wwi9VbA8nr0EEah65QxY+qlhZZrIAZfY7QJDXrV6PujpiUFd11 LA1oKqK2zNAXkDqjMldYzsbUJ7V6A2GAOrlTldaC5GhPdA== Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hc0kxhbum-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Oct 2026 16:39:28 +0000 (GMT) Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-3580c07911eso2499251eec.0 for ; Sat, 17 Oct 2026 09:39:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792255167; x=1792859967; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=hz4iIDuDhHEcy2mIuGeKuord9GLsrFZT6JV2X218PUA=; b=Adqoyl3VEdi+elyTpQ55ybVsDo+2i6wiVEQAeUf0qjeq3771rQH33PjCHsTycFNnUS 70XUj3JoPgJr3iBJk9KnT/9Qb0UGNpBVjm2BkxX/1B+Joc7fOymUQ2wRfRUU/a4q1iy7 noBnMJjmkI2pmlQ5t713cKrupHyMNvEptpK549Ho4R/l4gDQOzYsBtU7/4E4qfiH44Pp MqOcfTr5n32anVnS7RoOmLlx8T+2bycei36uXOcwJHGaMT2RLQHGEQaRhabN8jFnLdUs jmUq5WquyZaew5G9u+B3d82UZw3kQXZdQBs6BIAW2H47tAaFPvEE1Fr1zRBlKXJpLkrZ KNsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792255167; x=1792859967; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hz4iIDuDhHEcy2mIuGeKuord9GLsrFZT6JV2X218PUA=; b=TYTyfy1M8sMSGpRPR2cJrxOeKdF5MpWWTNmkhQg8+CIQK/athyF7P9TjcFqH8WgAqA Fl6zDAOoJIHwwQA7/FWYqkcZ6OwIN2NcgJ32pmN8O8XQA4VOQmqXDtBvK8pNVAv/r6J1 UT/pYBYwAQ0mOCOh74zrC9WHXMAO5IzrPxznhgffiXrdqlr9L1xWNzOxhQXvmitjcprZ D/aCEqvG4K90Vsv8/ZAvUCQDpovWbxgWHGA3xBxbkmv0Qj+h718oAtZh+YRidZasz9Nk 3AvOKPV4dV2vdNbJczQTtl6/S7WyPZuwnhjyraxcI+7CZUZ2Ox13YyfEcqyI3WmfOh9V 4LIw== X-Forwarded-Encrypted: i=1; AKwUvBySLB0sldXkAzwNFv2T4V7iToOXcUPbsEkw8hZyGACC/qJuWvK6T6ofTmxZTuvHfe5OuVLQh/xQllliEg==@lists.infradead.org X-Gm-Message-State: AFq9FYJjoyMgLsCEkMtva54wbCetQV1JIdTagdPoyqi3x3QUc8ahFGb3 mdPOFOBElMTgbb1LA6lwYyAB7dJw40bMionTYsA6gwt+rgdLB0m2mz4SxDA2VW4Xayvi8LEd0Nr sLis/EnlzUpDVhY/ICOXHt4loSWl10Ry2ig8CeZiuhGs3kxUsBIUW5z2flkZNpaQ2aXBoQWY= X-Gm-Gg: AYBFou3c59E/yV/CPKeHEZ4W77VabP8tkTQclTg7R+9vmFHIK1DNCpmON+dHsPhFyfU giUDHQswgiqjufOTe0e63ISRqeyc0mz+HFXU0DFuAGaYXgCtfikTSvcxYYCUWlGDDRAA7rsXDhb EEPqmHh4dXlFTtQX/swy0riBfgqeJCk+DgR5Ju+mOf5JSSwM0EZWDWDoS9tnfBfyVvQZTBk2mJ1 8szKh7fLiFxKxHBq3sukE2oOai0U4N/6QsbE5yJznP49+LcpR3A4pxDIL36O8C8gik9dBbMZ4xk 1bVPqMNORm75AiCeG8BA5w4YdwYuIYs8Uoor6TLm/RMLpNeBtIzzHyEwO/jB7uMXk3/RmlHknTU SOcNeogyWfFce X-Received: by 2002:a05:7300:2406:b0:360:5f7e:2eb9 with SMTP id 5a478bee46e88-361a254da08mr4629937eec.32.1792255167270; Sat, 17 Oct 2026 09:39:27 -0700 (PDT) X-Received: by 2002:a05:7300:2406:b0:360:5f7e:2eb9 with SMTP id 5a478bee46e88-361a254da08mr4629905eec.32.1792255166648; Sat, 17 Oct 2026 09:39:26 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-360813b6e33sm17691508eec.7.2026.10.17.09.39.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2026 09:39:26 -0700 (PDT) Date: Sat, 17 Oct 2026 22:09:10 +0530 From: Mohd Ayaan Anwar To: Bartosz Golaszewski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , Bartosz Golaszewski , Eric Dumazet , Radu Rendec , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski Subject: Re: [PATCH net-next v16 4/7] net: stmmac: qcom-ethqos: update phy_mode to the resolved interface in mac_finish() Message-ID: References: <20261014-qcom-sa8255p-emac-v16-0-0266c2ead980@oss.qualcomm.com> <20261014-qcom-sa8255p-emac-v16-4-0266c2ead980@oss.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20261014-qcom-sa8255p-emac-v16-4-0266c2ead980@oss.qualcomm.com> X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfX6gpk3mPc9HW1 2KdEp/3FMJou2ZfUd0C3Tz2KNK7ttcQH+ZLjV90RoQkyYuB84VHqP6sRMUcmss0YU42Y85LAEqd z6ZZ0eHfaRKQ4O4I9dd7Ii6YMiv4yMQ= X-Authority-Analysis: v=2.4 cv=JpZkP84C c=1 sm=1 tr=0 ts=6ad3a4c0 cx=c_pps a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=K33ZUWoUxhUzfzW7EYwA:9 a=CjuIK1q_8ugA:10 a=bBxd6f-gb0O0v-kibOvt:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfX3LkfHo+7kg0O sFgJ/Ap2zTHIDW7KNgfCluTGIgGPuI8jQ7TrgnH6YZAMGG6UGFVLRtpI9oz5wrx/oJD/o8F98gN HcGhKbcnVPG5oVLKsLfbRlWjLo+5gMldQOwiMO+sKPvhMquJ7KILcdFjsDSaLOrxBK5qnGgfWO+ Yo+BJAmWC68dO76fGXokcRX1KQr9W8F7t7UiDvp+OwNwF0sCe4/pynEcow5T9F2z8p+q6Fn74I3 c/YkolRQEleK9ZHSdb7oG2Jh5pLHvttYV2Cv2ou3eto3i1Mg9lKez75rabN7DDkxRzc/pkBTHLG fHUedZ8C4WRGJZ9TtoNQVZ5T01OLnKXDE+I0qc+tMwXX2yTVfu7KsfoOIluhxqoLT1JzaGeViX1 0gnJbh9yEnXVnskkOBEYRT4zqu+8/miFc/7K1IgfBOwtCYPMkVJyNHKRujdgJiASotM6SL576No 9FfqncC8AzmFrWol+HQ== X-Proofpoint-ORIG-GUID: ZMCVz6n4MsImCDLcAkfxWH2rOXG7cha4 X-Proofpoint-GUID: ZMCVz6n4MsImCDLcAkfxWH2rOXG7cha4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-17_05,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 phishscore=0 suspectscore=0 malwarescore=0 clxscore=1011 impostorscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610170066 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261017_093929_660214_33287C23 X-CRM114-Status: GOOD ( 19.40 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Oct 14, 2026 at 02:36:43PM +0200, Bartosz Golaszewski wrote: > ethqos->phy_mode is read by serdes_powerup() and > qcom_ethqos_set_sgmii_loopback() to configure the SerDes and its > wrapper for the correct interface. It is set once at probe from the DT > phy-mode property and never updated. > > phylink resolves the actual runtime interface and passes it to the > mac_finish() callback. On platforms that only ever operate at one speed > these two values are always the same, but when the interface changes > at runtime - for example switching between SGMII and 2500BASE-X - the > stored value becomes stale. The next serdes_powerup() call, on > a subsequent link cycle, then reinitializes the SerDes to the wrong mode. > > Update ethqos->phy_mode from the interface argument in > ethqos_mac_finish_serdes() so that it always reflects the last > resolved interface. > > With that, we now update the phy_mode to the runtime-resolved interface, > so any subsequent resume with a 1G SGMII link skips the loopback setup > and the DMA reset hangs. To remedy this, extend the guard to include > PHY_INTERFACE_MODE_SGMII. > > Signed-off-by: Bartosz Golaszewski > --- I am not sure but should this have a Fixes: tag? Reviewed-by: Mohd Ayaan Anwar Ayaan _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10C68CCF2C1 for ; Sat, 17 Oct 2026 16:39:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NWpmoUJrz3t9BdrNjHTMb4+PYKHjscL0FPn1zRivoCA=; b=tJu1bqiKQul9wh zddbbvAYQq15xdshFFGu889jKfsK9Q+k32YK9V/d68RHkfiLOhS6wTdXq4bo76xfgDREYeQ0pr9ct nud3v/m6dZIS9R1ySsIMIUmRL3NDsPwW7tFMf/skfSFBq7auOEZa95xIdtFtdPuhTkhymYFkOwd11 g6iRAmT2/j7S74R0WDfHruUKBWeoKQyyALGDrmOc4Hyj+NRV7vmqVLN+Ov0ifXuYfQPkqDR7G63UG 8/ODnd4EFbhgEDaa7IIoHh4gTVksnok8UPanz9tShXyQcv71pvjOgdwRMvzYg4D7E+BCzCppqnVU8 29mkiToFsUj/cSHk0dEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xI7RU-00000004wL6-1zT3; Sat, 17 Oct 2026 16:39:32 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xI7RR-00000004wJX-2EJP for linux-amlogic@lists.infradead.org; Sat, 17 Oct 2026 16:39:31 +0000 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69HGA1rA1480415 for ; Sat, 17 Oct 2026 16:39:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=hz4iIDuDhHEcy2mIuGeKuord 9GLsrFZT6JV2X218PUA=; b=iqcI3njCDzM4e7mRHLw+YV3xmeKx13qdpNpYLO1c uKuJcnhcRz3rtqo+XqDGeMCZv2dURNY8sE4Up/wSPorj21shN+H4P4PvOUiE1k4f HrKJsV+TXCcL1K6rMrtrXUEtT4Vlu4w4TsY7ngl01CsdTZz1rKlYemGVmnu3eNHV +HjThJ6ViFeCJyAVpyHQYmZUV+RGbosOkNtCwmXNHB6OUn0sulMIxvCNKMz7qg71 VvhPs8OoWfwTc1Wwi9VbA8nr0EEah65QxY+qlhZZrIAZfY7QJDXrV6PujpiUFd11 LA1oKqK2zNAXkDqjMldYzsbUJ7V6A2GAOrlTldaC5GhPdA== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hc13usata-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Oct 2026 16:39:28 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-35d4538fd74so2935979eec.1 for ; Sat, 17 Oct 2026 09:39:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792255167; x=1792859967; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=hz4iIDuDhHEcy2mIuGeKuord9GLsrFZT6JV2X218PUA=; b=Adqoyl3VEdi+elyTpQ55ybVsDo+2i6wiVEQAeUf0qjeq3771rQH33PjCHsTycFNnUS 70XUj3JoPgJr3iBJk9KnT/9Qb0UGNpBVjm2BkxX/1B+Joc7fOymUQ2wRfRUU/a4q1iy7 noBnMJjmkI2pmlQ5t713cKrupHyMNvEptpK549Ho4R/l4gDQOzYsBtU7/4E4qfiH44Pp MqOcfTr5n32anVnS7RoOmLlx8T+2bycei36uXOcwJHGaMT2RLQHGEQaRhabN8jFnLdUs jmUq5WquyZaew5G9u+B3d82UZw3kQXZdQBs6BIAW2H47tAaFPvEE1Fr1zRBlKXJpLkrZ KNsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792255167; x=1792859967; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hz4iIDuDhHEcy2mIuGeKuord9GLsrFZT6JV2X218PUA=; b=2v6C6bP+NjE5I5TC4NMqE/RRXoKzEI7OD9J2QQ0MjpX5P5wPr0/Hn6frWNhJqTj7/F rpsTkadU9q4aXbag61TkZefk8Z8mHgtBP8Ixed4w4ZwFgFBx61SzVBxdDWJ8rQbNFzRY 0XKkJchPzP8ghwSzTYaQw8cxsjVVSm5NGzQjXy+8TCD+61SW1yT6mh243GdhWuXrj+9M f01DZ7GWBbgk7Ie/VGYwDOJ/Eppsrvq6y7187ROvyNckFD3qF9XTTH7kZRhzcQ6O0moJ WnV1lTyqJDYUqGLFUt6iM+8gqHcm9sX9ctR9LfRRx3S83fEbkE3z6t58p/9TZJMkFa0e FzrQ== X-Forwarded-Encrypted: i=1; AKwUvBx1TtrxaGWQ8LdsGT3sr+RLQPxDQnQa9pp9UnrcGIblp7yK15JhSa18Osv4CPHib2ISBY7CDNQGu4wGLkHX@lists.infradead.org X-Gm-Message-State: AFq9FYLg7mQdpHFnpM5bKVqzzqh/SPMr3YniRcNXhxBx0f3oZP/VkGbj 0DCpNhDDArJtXwrX+pbkLV5+yIBciEzRMcPxXS2m0oUm6eLqB1lEKEPnR7dtSNX1WHjfpxte+OW I3wYNYtJTk/5iwPbb22fgQJXnWVFVLVjaW+b+KK3vWIbJZjr3MqweIXXeola2MI0E0TJFnda8TQ == X-Gm-Gg: AYBFou2MOgI1tzDndlq2BZw40zwbuf4QIvrelcFIHaWeDxioblYDZW9JM+GDA4FSobw iioDsb65oaB66EOzJ6AT7l6P2t8kmLUiO1RT1vjh+5Rf+iiQzbowuKqPt6pC+cjynvVB88dSXu5 mH/OJqQD/rCYc7pzR5pAgNiANsVO5I9FHAEEwEvxPg8jtbDyuefPzFqrYmAKCPeB+aPiclIVEO6 Pe1AyqGm4PToIv2Mrirm03SXFRXu+NGXt/42wWO0QcN8HIJoVFlA18/oAn2YUMjP6I2CFy2aCrm 3yP2zfvcCgpZE9SDASPZDC2DQ5kE5GlPRAtxxe+7h4ZljOxWo0fpHIu4RYCaV+e4/Qfj7R/6qIE hQuSuVq77A65V X-Received: by 2002:a05:7300:2406:b0:360:5f7e:2eb9 with SMTP id 5a478bee46e88-361a254da08mr4629938eec.32.1792255167277; Sat, 17 Oct 2026 09:39:27 -0700 (PDT) X-Received: by 2002:a05:7300:2406:b0:360:5f7e:2eb9 with SMTP id 5a478bee46e88-361a254da08mr4629905eec.32.1792255166648; Sat, 17 Oct 2026 09:39:26 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-360813b6e33sm17691508eec.7.2026.10.17.09.39.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2026 09:39:26 -0700 (PDT) Date: Sat, 17 Oct 2026 22:09:10 +0530 From: Mohd Ayaan Anwar To: Bartosz Golaszewski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , Bartosz Golaszewski , Eric Dumazet , Radu Rendec , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski Subject: Re: [PATCH net-next v16 4/7] net: stmmac: qcom-ethqos: update phy_mode to the resolved interface in mac_finish() Message-ID: References: <20261014-qcom-sa8255p-emac-v16-0-0266c2ead980@oss.qualcomm.com> <20261014-qcom-sa8255p-emac-v16-4-0266c2ead980@oss.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20261014-qcom-sa8255p-emac-v16-4-0266c2ead980@oss.qualcomm.com> X-Proofpoint-GUID: CExeHwYe8mkGssIgaCNwHDAtzd1tFaK1 X-Proofpoint-ORIG-GUID: CExeHwYe8mkGssIgaCNwHDAtzd1tFaK1 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfX2kqBLzhF+Eci Jb3Kj5h9AjhfObuOz67ocTsQuPUAgo90ED2gBa5SpFtXeLeReNplXFT+e7NNvII2lm570xr+YT8 uxWwlj/w6ZLD8KzbbMVjiUJEl7p/9mo= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfXxUIuvD1QF1As 0sl/MvFFhe7i8rCmEY3Yr51qwEq2AVKPYTOeZb8wGeh7KF22lyavYFFnoYGHXUJxM2fe0XcD92G EVyQXSD87fCQiFdRwYt3Xw/nDvColOhQ9+470Znlh8qJUHVb1XwkdXrYTAwDZplor4kgyjLYu6G gGRP237kSCuHC39dBxLF0nMSy0Ja8fmcJofdnyGCkkXWGMknMoJQhEm1l0LuOv22+27hCE2eW7P g5FVXi6GTnsAW7DdyG2gBIbNYwikltTn4jpOKgnLdf9AncMV+43SXRo14t3IAECyb48aGBifhal kZMUSI+s2e5VzZCK5cbIQG8zjIN9fye8KWcD0LYdHbdBui0YG2/E0cz6LdWPe9dIFsBlqKfAnqX y+SJeOtqX1tkO9LEJpR3tkHvOqbCOFemvgLyQTTnqMHcoUj4D89HJ+FI16DIYkAJiYU0xJzGYGE psPIgeENXL2IuF9XLBw== X-Authority-Analysis: v=2.4 cv=SKzXx+vH c=1 sm=1 tr=0 ts=6ad3a4c0 cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=K33ZUWoUxhUzfzW7EYwA:9 a=CjuIK1q_8ugA:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-17_05,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1011 impostorscore=0 spamscore=0 suspectscore=0 phishscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610170066 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261017_093929_678075_CD3FB25C X-CRM114-Status: GOOD ( 19.48 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Wed, Oct 14, 2026 at 02:36:43PM +0200, Bartosz Golaszewski wrote: > ethqos->phy_mode is read by serdes_powerup() and > qcom_ethqos_set_sgmii_loopback() to configure the SerDes and its > wrapper for the correct interface. It is set once at probe from the DT > phy-mode property and never updated. > > phylink resolves the actual runtime interface and passes it to the > mac_finish() callback. On platforms that only ever operate at one speed > these two values are always the same, but when the interface changes > at runtime - for example switching between SGMII and 2500BASE-X - the > stored value becomes stale. The next serdes_powerup() call, on > a subsequent link cycle, then reinitializes the SerDes to the wrong mode. > > Update ethqos->phy_mode from the interface argument in > ethqos_mac_finish_serdes() so that it always reflects the last > resolved interface. > > With that, we now update the phy_mode to the runtime-resolved interface, > so any subsequent resume with a 1G SGMII link skips the loopback setup > and the DMA reset hangs. To remedy this, extend the guard to include > PHY_INTERFACE_MODE_SGMII. > > Signed-off-by: Bartosz Golaszewski > --- I am not sure but should this have a Fixes: tag? Reviewed-by: Mohd Ayaan Anwar Ayaan _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC7A6CCF2C1 for ; Sat, 17 Oct 2026 16:39:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DpRE1RAIWEQGb6ipuOPpOyMa1LyAbEEXHpYi8HrsGt8=; b=DekV44FGSrMAFo gAusZsYZTPZHE48GkfxFhgiJqtyBte+APl1OIZ9UboH/8RjimpbQ8i6km7lRJc9eZXjns+c9uIlX2 00QbbVGQ+PaMdeegC6GSSYI4YVUgwcx0i97oEhDt3dEqbTvK3sYsxZLFiAwfV38kHvjMkEBAVz5Ka qhmz22xrkVItvFhtuC0tT0w8Zufh8RgGIKcJQCpnrCyU78ja6snYzUBSuBAFMGzVfHNDtp2ckbuYi FBcZ2z8bF3oaVF6mo3Lz7zfy+bSUux4wNoisxecnx+XI72Tdgy9XkwAcjWJBxGqPqYZOFVPIhRqgX lieFKTOVEs7E6n4d3P0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xI7RU-00000004wKw-1GBp; Sat, 17 Oct 2026 16:39:32 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xI7RR-00000004wJV-1tgL for linux-rockchip@lists.infradead.org; Sat, 17 Oct 2026 16:39:30 +0000 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69HGA3FZ2032773 for ; Sat, 17 Oct 2026 16:39:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=hz4iIDuDhHEcy2mIuGeKuord 9GLsrFZT6JV2X218PUA=; b=iqcI3njCDzM4e7mRHLw+YV3xmeKx13qdpNpYLO1c uKuJcnhcRz3rtqo+XqDGeMCZv2dURNY8sE4Up/wSPorj21shN+H4P4PvOUiE1k4f HrKJsV+TXCcL1K6rMrtrXUEtT4Vlu4w4TsY7ngl01CsdTZz1rKlYemGVmnu3eNHV +HjThJ6ViFeCJyAVpyHQYmZUV+RGbosOkNtCwmXNHB6OUn0sulMIxvCNKMz7qg71 VvhPs8OoWfwTc1Wwi9VbA8nr0EEah65QxY+qlhZZrIAZfY7QJDXrV6PujpiUFd11 LA1oKqK2zNAXkDqjMldYzsbUJ7V6A2GAOrlTldaC5GhPdA== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hc0kxhbuj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Oct 2026 16:39:28 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-35d4538fd74so2935989eec.1 for ; Sat, 17 Oct 2026 09:39:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792255167; x=1792859967; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=hz4iIDuDhHEcy2mIuGeKuord9GLsrFZT6JV2X218PUA=; b=Adqoyl3VEdi+elyTpQ55ybVsDo+2i6wiVEQAeUf0qjeq3771rQH33PjCHsTycFNnUS 70XUj3JoPgJr3iBJk9KnT/9Qb0UGNpBVjm2BkxX/1B+Joc7fOymUQ2wRfRUU/a4q1iy7 noBnMJjmkI2pmlQ5t713cKrupHyMNvEptpK549Ho4R/l4gDQOzYsBtU7/4E4qfiH44Pp MqOcfTr5n32anVnS7RoOmLlx8T+2bycei36uXOcwJHGaMT2RLQHGEQaRhabN8jFnLdUs jmUq5WquyZaew5G9u+B3d82UZw3kQXZdQBs6BIAW2H47tAaFPvEE1Fr1zRBlKXJpLkrZ KNsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792255167; x=1792859967; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hz4iIDuDhHEcy2mIuGeKuord9GLsrFZT6JV2X218PUA=; b=xR/2xp62uuxpdSGaS51wrybgUBI/WhyiCokLhYnffaFrEufL91hoSLGC/fO/h7irNV kysdhpxW+XF6eSbsZMrAqIPNC1+hhKG6F/U36behhM8Wt8mV9rQwg2c5Qk8ehbQI1IdK sNLSKth4oKuDJx8I6to/gMcraSGKxEzFmv5BlsdJi3lq1DZMN4GTRO5k4HjAUv005LZK EGd7zZ5DuQwWYvd+0Kdz+vWHJUQZQCIUlpbC6NJqe2xJ1OjFIAHpTvQTXJt9IqKhDAYX CnHuES5DCA2QO87P4t2MLRhQKtfEomtz1ctbJRYKQjihwTS55a+aQ/Aw63x4y97OYnuw vzkg== X-Forwarded-Encrypted: i=1; AKwUvBzJkpNCf2vL/jMNeDWD7UWxKfFGONM1JGSD9CiH/pV7VK33AYv/1TArJjTuGGP+O8ZuLgacS7fS8CEO0xPKXw==@lists.infradead.org X-Gm-Message-State: AFq9FYLhDxytIDSNII8raDuBrj1a8GLBG8IRzv3SDkYrvExOwhyaB0f6 aLRrWQfogsgyE5RYSd3C909DEWVSKHfQSQbO+fWeYrqJNaw0nF7mVSlf5oXrGtBFdaIJX3m0o9T n2L1HOeHnzxiyyTdOrYdLjyxIWyoUImh4uNDhBsZuzFgDfyp5wiT2y6hewWnD9wOJIHfkGuhDFV Q= X-Gm-Gg: AYBFou2SHFgPHb2fuOFA8r9IaCDPElcCH/IlyRRB9q+gJ0mwB31qiy2MI4zsiDH5qNa LcIagJG5LB39kkNUHfF1WonjfNhCtHMRyBHHRsWh2wAkX2yhzxumZgZklB6kZlsMpn/lN4v6EXf 0J6ufhgygi8UujZcjyRv6jUAgoFkycuhW9aX2hT6qlK0umAl/e2TiPqhQb1XaxkCcbeeatc2f9H KoVpzs9J7NeKCz77qJoB5Qh30hM0sEMNJoUCCS/T9fQY59Xw5Wos44yC1IWV6qO5Y0mRgR2RdvG TfTNQhokPHgjuXoCa/3zIzq/ljGoGmC4bEbl/ZPoDfRVVTamyYGRd3ggF5MRN2i4Bi0qRites19 mC1Ns32oqadW+ X-Received: by 2002:a05:7300:2406:b0:360:5f7e:2eb9 with SMTP id 5a478bee46e88-361a254da08mr4629957eec.32.1792255167312; Sat, 17 Oct 2026 09:39:27 -0700 (PDT) X-Received: by 2002:a05:7300:2406:b0:360:5f7e:2eb9 with SMTP id 5a478bee46e88-361a254da08mr4629905eec.32.1792255166648; Sat, 17 Oct 2026 09:39:26 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-360813b6e33sm17691508eec.7.2026.10.17.09.39.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2026 09:39:26 -0700 (PDT) Date: Sat, 17 Oct 2026 22:09:10 +0530 From: Mohd Ayaan Anwar To: Bartosz Golaszewski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , Bartosz Golaszewski , Eric Dumazet , Radu Rendec , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski Subject: Re: [PATCH net-next v16 4/7] net: stmmac: qcom-ethqos: update phy_mode to the resolved interface in mac_finish() Message-ID: References: <20261014-qcom-sa8255p-emac-v16-0-0266c2ead980@oss.qualcomm.com> <20261014-qcom-sa8255p-emac-v16-4-0266c2ead980@oss.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20261014-qcom-sa8255p-emac-v16-4-0266c2ead980@oss.qualcomm.com> X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfX7y5DUy7jCIcV +5fHdDAzLJdGkh8eVpXh9r+Ja+pvV1/kJJjByMUZcSpv6lL/MjiydYxi0SgnpAsO16UQco/eeOT +MPrbalmyJjonb1iHOfoiMyS6SUgI2o= X-Authority-Analysis: v=2.4 cv=JpZkP84C c=1 sm=1 tr=0 ts=6ad3a4c0 cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=K33ZUWoUxhUzfzW7EYwA:9 a=CjuIK1q_8ugA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfX6U7J6Vw75C+c GRnx/8iEiDuhiYAahmJ97qPqOzFianNFgfAybaJ3ea7hLUcaIdeb9HNTZtPejjGejTz77e+jW35 sJQnaNjVTCadNVm5HC9JtsilJg6f8r7RAxi/rMLaoCS0M9MJtjsJslenaWxhIXzZVfiFmZdNylj 3OfTShA14rx0N2ayw8yJ0Vsiit8PttuTp5XePJ1SKcljSMGrkch2KbPmgvKpITeMDGFvsewQ1p3 SGBlZhp6GIF6VAK25/5IoIlX2kQx13oRy76q/9t/hj5E1ph5v+aGV2+/w+cHUglaNrauS4cwphn d1TQqdC/AeLc5rZDpkd4aA+sifPJz8ZWnZ9chtDMMin1o44wHxJQWqvmRdbHX5c0Aq1LECXDF5x A9gkKqpVgwa0XnKJ10YPWtz9szl8kQzvdryAXrIQg8RN4QYlpz8oRnxHkvnyZEQEyuJUwZp0BNz 1d2noQGflI8KloRXdcw== X-Proofpoint-ORIG-GUID: JbEZKgajBpXnOmMbP3VlqaKfj1TWSrIm X-Proofpoint-GUID: JbEZKgajBpXnOmMbP3VlqaKfj1TWSrIm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-17_05,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 phishscore=0 suspectscore=0 malwarescore=0 clxscore=1011 impostorscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610170066 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261017_093929_647335_6A86232C X-CRM114-Status: GOOD ( 19.61 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Wed, Oct 14, 2026 at 02:36:43PM +0200, Bartosz Golaszewski wrote: > ethqos->phy_mode is read by serdes_powerup() and > qcom_ethqos_set_sgmii_loopback() to configure the SerDes and its > wrapper for the correct interface. It is set once at probe from the DT > phy-mode property and never updated. > > phylink resolves the actual runtime interface and passes it to the > mac_finish() callback. On platforms that only ever operate at one speed > these two values are always the same, but when the interface changes > at runtime - for example switching between SGMII and 2500BASE-X - the > stored value becomes stale. The next serdes_powerup() call, on > a subsequent link cycle, then reinitializes the SerDes to the wrong mode. > > Update ethqos->phy_mode from the interface argument in > ethqos_mac_finish_serdes() so that it always reflects the last > resolved interface. > > With that, we now update the phy_mode to the runtime-resolved interface, > so any subsequent resume with a 1G SGMII link skips the loopback setup > and the DMA reset hangs. To remedy this, extend the guard to include > PHY_INTERFACE_MODE_SGMII. > > Signed-off-by: Bartosz Golaszewski > --- I am not sure but should this have a Fixes: tag? Reviewed-by: Mohd Ayaan Anwar Ayaan _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip