From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDEECCCF2C4 for ; Sat, 17 Oct 2026 16:43:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A5QXkyLgqve2yg7aR0QbgBy6tWTAd+S8xlmq02cu4VU=; b=oVn9j78Aq2luyMGtSjmLP212gA Pt7mcvDOg34IJq92/oMWDHeM+Uc2bC1P1B986k7PUPgvIz+HMuAnRZy+LoPH7Wmlt77VEcsZ85pI6 1Q99aMZHhHgHO7qM/p07X6I2UQV+l41kUq8ETYdyjGa9fbxIIxMv6ZJU+Rx2z9v/uMa4lBj8dugE7 dmMi0a3nO5A3j2hJDL4fs5E+Kj7UYA334Qw+XDAjSJd+zVDEcLvCw9DXTD7pDho3ubsGpW53damRb SMgzzvwwVZNUGq4VaatLTVHBzBXUyR9KDmYJk6ueG3LIfcz9gqh1ypQ2Bfp3HAJpEsicC29tlOro1 ABoNE6eg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xI7Uk-00000004wmk-1xr8; Sat, 17 Oct 2026 16:42:54 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xI7Uh-00000004wjj-0WyB for linux-arm-kernel@lists.infradead.org; Sat, 17 Oct 2026 16:42:52 +0000 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69HGABIv1480699 for ; Sat, 17 Oct 2026 16:42:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=A5QXkyLgqve2yg7aR0QbgBy6 tWTAd+S8xlmq02cu4VU=; b=lNhoZ5KmND8CPcI2ztJrmEz30rkXHlfA6ZXPZ/BF dIjaldaBjswQDQz152ahMBvv8elLhUYIikte8R33fvDM1XFYB4bJJwxbmkydvHs9 eShIPCBWf8E5pwxIyBHGeuDQy6qdqbdVggs0w6DviKRSBV4mr+P3cTJTp4wdY74Z 5KS3ymg6PgRQRKbX/+YVIu7Re+hZZAA+q5SytRzeNXF0f5SCG5w6ckx/tUicRxJW NwxJhIQeClRVZ0OtvWLuWHL0rqEzv6Gfy7aqB1TktkhdKtYwuruOrhAkDsgnYJJ5 WmRvDQrRAWN6umuhYE7m35Y2hOg40tfgMs8wZ1wwrVlYWw== Received: from mail-dl1-f72.google.com (mail-dl1-f72.google.com [74.125.82.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hc13usay5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Oct 2026 16:42:49 +0000 (GMT) Received: by mail-dl1-f72.google.com with SMTP id a92af1059eb24-1383723dfddso1863185c88.0 for ; Sat, 17 Oct 2026 09:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792255369; x=1792860169; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=A5QXkyLgqve2yg7aR0QbgBy6tWTAd+S8xlmq02cu4VU=; b=KHHRRs9D9rXxwuqStD72wm0lV8UbC9/+xsXoWFejfstpoY2ng3UpEUh4VTUJ6VUe5Z BVFqFQ1rtfv8Z1lSfwY+vwTYDVI6yf2+Sg2R+hcF+KYZ0+6fgKJpZ0oqWBzq57MiGSJ1 cqYqakSV5AzsVKLRxZkOHPTGC9bqSNA1zFo5558/rG8jG+thrBwW9G7/skx0bop+zq/r Re4zS4R4wcpUkjYb8v5rrIWR4NdvhDUa+614Jvb3q017u+Nt3tSqHcHsXsk+Bilkra0t xEMoTBuoETFYF6Ng/RXrjxKCRYUILeBgzBifug5f46XooI/AMGekq287lDAlxtXb6tXp 31Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792255369; x=1792860169; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=A5QXkyLgqve2yg7aR0QbgBy6tWTAd+S8xlmq02cu4VU=; b=A/0xFZ34nJq86Z+6zbx/gztCf8evwr+OzoNCa4WyGr2NE/sIZ61iz18kZD4lI/kZp/ F03xJCxT1PM4nZBOnFyzYophNxZ6MI7yhx6tmfpJ9okHLRVOEufL58SQRypTO5sDqz3H NX3eU8D+otaTXYoZ1zvafHkVGYWbiyIavghc5tIWGiZZ/DZw9C5CaA3+pGuXxbnenn93 ZJS3XVR7sExx1x+an9kK6CPeFCmiIrBDZpUST5qKOd24cpIC4juKgakTnhJ89RZ8e4eJ qV64+pPkoqfnTMSWaW+QBBQRncdEA2SGS1kW6KXFJZWW275gfIuF/njmRmDFVT3rfM9j 9MxQ== X-Forwarded-Encrypted: i=1; AKwUvBzgQBh3ikB1JWTPt8Q0vtzlIzR/mP8hh4nvzkD50vrds+lXZ4pUSGmL5fdBkLvpwhy8Pz1GZ/rqL8C0UsQggZRV@lists.infradead.org X-Gm-Message-State: AFq9FYKEgEDJ9hfXa8CYUIAejxN3VkVhSau7hjtZar8mTxp8M7FUs+ns 3457pLhdnSpBF8YOIbVLnHM89DEMkOFKroq4sjCXrqLCRtevgkuO+iLlbjocTVoof35Zocs2da4 rvQuqyZ1R48ReDGCJ23y0ynFJuz+h8gcCm+bXkRKUtws887HguslRngqPN5EtDymKYxMSb7574C 8ifQ== X-Gm-Gg: AYBFou2F84dun1xuUwancXWlGC3hp3FQ3hpXybnxhaxlnCz48UKaZxAJzd3Pd81mb0v gth4ewhnCYikTWkucmaikD2eM8iELIQj+KNHgQ16ccAQDYL2VxAxQCCDJ5dcVuZLZnV0wN0aQ0O qBsEUpd8Y8AUod3nGRxw+ZM1vM735cbjVko9eodjGbCdDx3nBKdpl5UffIrfC71ndQ8JnsdF+e/ XPT+Qx0jyRXyNM8hCy4/bWmQkfI9GPeYywWElDalWK/T5KonWHKO5s7AOD/zHb4VKZKl0NJaY6C i2yaFLWvR6Hsuo1hlbvyK54uHEeDgZoamJe71K8rGXN1vSYvtUvkjLoJu7ggB/xVlqEWhppgM2E OcWzGMTQx5w7CUA== X-Received: by 2002:a05:7022:7e89:b0:14d:ef19:246f with SMTP id a92af1059eb24-18513e7b18emr4689721c88.45.1792255368735; Sat, 17 Oct 2026 09:42:48 -0700 (PDT) X-Received: by 2002:a05:7022:7e89:b0:14d:ef19:246f with SMTP id a92af1059eb24-18513e7b18emr4689692c88.45.1792255368055; Sat, 17 Oct 2026 09:42:48 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-183190aa7bbsm15041602c88.5.2026.10.17.09.42.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2026 09:42:47 -0700 (PDT) Date: Sat, 17 Oct 2026 22:12:32 +0530 From: Mohd Ayaan Anwar To: Bartosz Golaszewski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , Bartosz Golaszewski , Eric Dumazet , Radu Rendec , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski Subject: Re: [PATCH net-next v16 5/7] net: stmmac: qcom-ethqos: reuse the address of ethqos_emac_driver_data Message-ID: References: <20261014-qcom-sa8255p-emac-v16-0-0266c2ead980@oss.qualcomm.com> <20261014-qcom-sa8255p-emac-v16-5-0266c2ead980@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261014-qcom-sa8255p-emac-v16-5-0266c2ead980@oss.qualcomm.com> X-Proofpoint-GUID: Q48xsI5HKl_6ak8tYyAjQnLexS5v6jfF X-Proofpoint-ORIG-GUID: Q48xsI5HKl_6ak8tYyAjQnLexS5v6jfF X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfX6oespeiS4gWG 26XJTpo8et04nTx1cZ9LAHxFBkaf3VXx5VUcvC0EavfGz0M8268ceylZmba4gT68oDhPuv7RgSQ P1VOopQpVI/a2NJ3cIlrT3Haygo7BP8= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfX8xnWt1CAUjIm Kvjk/BoWSKY5BQI3vp7WXGisnvJLn0fS/7X+eJ5iKsl0OP0AwlMG3f8Vzx4IkAzdoklylDNGt1d uMFOJ0udJEZRrEqJLFZ1n0VWZdyu5/3g9DJXMSo89oAkTXc5zqUTpX5vNmeZLwUda+6rQoRvYUT JnDEdHhw0pR2et7l1tR4+5VLwslq7azIUdcQ37UPdSBmUCs4BTpjXITjJOzYs46X6whS628IxJQ Dl0QIGPPnjmA8e+80AHFHAqkYVPpr487h3+Jt2RhglmCss5lFCxate7uYy6bVn7hO+oCHzft8s7 E9fzKrjbmEPXYkbPMtrOdEWlQSqGFtVdUOGmWK8OOPWAs8lSOlC4tnjgof4KwkOaVhRYwYZ7kL2 NQBSOs9aI2CW+Spy6dRjwr5g/oiM6//sIXGBDSdbsg9tcB/KH+cIqntWd6gdLUp7nPTZLM3CS33 YRidaSGeaIMGdc84xIw== X-Authority-Analysis: v=2.4 cv=SKzXx+vH c=1 sm=1 tr=0 ts=6ad3a589 cx=c_pps a=bS7HVuBVfinNPG3f6cIo3Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=XX1oeNa5M8xgm1Jp0F0A:9 a=CjuIK1q_8ugA:10 a=zZCYzV9kfG8A:10 a=vBUdepa8ALXHeOFLBtFW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-17_05,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 impostorscore=0 spamscore=0 suspectscore=0 phishscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610170066 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261017_094251_284481_95474BFE X-CRM114-Status: GOOD ( 14.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 14, 2026 at 02:36:44PM +0200, Bartosz Golaszewski wrote: > Instead of needlessly copying the fields of ethqos_emac_driver_data into > struct qcom_ethqos, just use the address of the former as a reference. > It's .rodata after all. This is done in order to avoid having either two > calls to of_device_get_match_data() or having to extend the latter with > another field when adding support for SCMI. > > Signed-off-by: Bartosz Golaszewski > --- After testing it on a couple of legacy non-SCMI boards, I did not find any issues with this patch, so: Tested-by: Mohd Ayaan Anwar Reviewed-by: Mohd Ayaan Anwar Ayaan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01C6FCCF2CF for ; Sat, 17 Oct 2026 16:43:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b6jTmc2rvRi2A8z1WNfsiiCLe4UTCt9blwPQypOEzX8=; b=W2FXdNYlYTCslZ GkPbPcoXkoFHPFcvIDGP1VUi1++oReFb5/oxJKdSOb5reup9Q5CZiwS8a1D5/g0bGFewBo0WvlZ1Y JcCQ2NE967KsGSfzMdTAAFRYm6eKe8iHClV5dSsuNUa/Z2Cckk89RNiAcXyEk+x0l7Np16wcsYMSq taeOoc2mLYLaGCt4PjlGgvDa02vvfhJUM7HNI8nlKZpJzgi5L9Xcr4xw3NvOG56ot2yd2XTKVQIEN NVhIVx2uEDgZlawjDyeKEeKhagmzYc9lIoW+0sSrq7bGsnvp8TkEPiVPZbcbFOE7g7Sb0qKsxYPv1 IBRZQRypmdLuLAWeIp4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xI7Uj-00000004wlU-19QO; Sat, 17 Oct 2026 16:42:53 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xI7Ug-00000004wix-0OO4 for linux-rockchip@lists.infradead.org; Sat, 17 Oct 2026 16:42:52 +0000 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69HGA3c8019873 for ; Sat, 17 Oct 2026 16:42:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=A5QXkyLgqve2yg7aR0QbgBy6 tWTAd+S8xlmq02cu4VU=; b=lNhoZ5KmND8CPcI2ztJrmEz30rkXHlfA6ZXPZ/BF dIjaldaBjswQDQz152ahMBvv8elLhUYIikte8R33fvDM1XFYB4bJJwxbmkydvHs9 eShIPCBWf8E5pwxIyBHGeuDQy6qdqbdVggs0w6DviKRSBV4mr+P3cTJTp4wdY74Z 5KS3ymg6PgRQRKbX/+YVIu7Re+hZZAA+q5SytRzeNXF0f5SCG5w6ckx/tUicRxJW NwxJhIQeClRVZ0OtvWLuWHL0rqEzv6Gfy7aqB1TktkhdKtYwuruOrhAkDsgnYJJ5 WmRvDQrRAWN6umuhYE7m35Y2hOg40tfgMs8wZ1wwrVlYWw== Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hc26k17fr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Oct 2026 16:42:49 +0000 (GMT) Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-359b81ad4e8so1325128eec.0 for ; Sat, 17 Oct 2026 09:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792255369; x=1792860169; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=A5QXkyLgqve2yg7aR0QbgBy6tWTAd+S8xlmq02cu4VU=; b=KHHRRs9D9rXxwuqStD72wm0lV8UbC9/+xsXoWFejfstpoY2ng3UpEUh4VTUJ6VUe5Z BVFqFQ1rtfv8Z1lSfwY+vwTYDVI6yf2+Sg2R+hcF+KYZ0+6fgKJpZ0oqWBzq57MiGSJ1 cqYqakSV5AzsVKLRxZkOHPTGC9bqSNA1zFo5558/rG8jG+thrBwW9G7/skx0bop+zq/r Re4zS4R4wcpUkjYb8v5rrIWR4NdvhDUa+614Jvb3q017u+Nt3tSqHcHsXsk+Bilkra0t xEMoTBuoETFYF6Ng/RXrjxKCRYUILeBgzBifug5f46XooI/AMGekq287lDAlxtXb6tXp 31Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792255369; x=1792860169; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=A5QXkyLgqve2yg7aR0QbgBy6tWTAd+S8xlmq02cu4VU=; b=f4lmaR2X/xySKHtWIcVsU9gvJ4J08QOZEF90mxBebp8nEe70Cs5yONQJkz+HySQtol +2kDODB7fl0SiBJzCDRTkjc1PDu5GYzTS5MIFHdVjADAF+9yaj4Up/qUJ74EqQARZ9ma KHldts4Po/pnnKsenS6IFj0T90C3ppiHEhQPg/4i7UekhVHCURSmLyiY8sCvuEZOMmod 9uIoZgKsDpo5YlUrDr8/Wt97yLQC0Ptv6Ov3gqHILKX/qdUGWvb332S5SIX7wwlGIOYo d/WkdvWIt4+K2ubPWGgy/JqSWj5t2ly4UlPYPiAXSMN7fc4n0UNElrQpYZHSXGkSg657 P/pQ== X-Forwarded-Encrypted: i=1; AKwUvBzqHCvLddbQIz4i7tYwTweehF6WUNCb2z4FSKSPmdy7hP5KwUAFbjgj89JmiCw8AdyRfRxOW9NkqXkDQkW18Q==@lists.infradead.org X-Gm-Message-State: AFq9FYIvkJnaYL9YIES5p0udn4P6KKepALX77i7I7+tny90+cwENNolz zWAyFV9HFsZnC3wOuWDMbVugnWODdle2q5Ap4PdEq2zNLNB+lepgKu+reTK2QvTjdcv0N4uQABm ctU1ti/2vXYRPhbZbYd5xfEbtzqOJxOGMIqZ1LWywM6aD8MdmfqgkqH5bjQ1PO1KgRMyyGrNc0S U= X-Gm-Gg: AYBFou1ndvTUI3QQE4qtA3ooyvs1mg4mnuzWWLcvMq0QeXTC6Dfpsf6FJ0MyWIrSD1R pGr6E8Kz7Q4k+kO/jxH2HiL6AoQhmRH7oadkckedLEWGaxPj19IwI8p4dqpylAxzuYgW//x3y7z 8NFBgiekpirsTGUwhfkcdaQ5g7ryYVXthmij90URvVcM8PUI+KGUWI9nThvY3gMaheS6N5yF0iN KqjX8ZSmQwg5JVCax3fOJJ2xZ62tKXgxIU3U5QT2INd0rKBEriiuyM2WFbe41E68eCIHoA/n9XP 2cdJ9pllsRvswsqbrft2iSp06h41RRp8UiTwQID6U9WRz4An7Tf0d/+ekchU3ET2y9u2LB3Bas7 emUFskIVgZviJBg== X-Received: by 2002:a05:7022:7e89:b0:14d:ef19:246f with SMTP id a92af1059eb24-18513e7b18emr4689740c88.45.1792255368763; Sat, 17 Oct 2026 09:42:48 -0700 (PDT) X-Received: by 2002:a05:7022:7e89:b0:14d:ef19:246f with SMTP id a92af1059eb24-18513e7b18emr4689692c88.45.1792255368055; Sat, 17 Oct 2026 09:42:48 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-183190aa7bbsm15041602c88.5.2026.10.17.09.42.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2026 09:42:47 -0700 (PDT) Date: Sat, 17 Oct 2026 22:12:32 +0530 From: Mohd Ayaan Anwar To: Bartosz Golaszewski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , Bartosz Golaszewski , Eric Dumazet , Radu Rendec , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski Subject: Re: [PATCH net-next v16 5/7] net: stmmac: qcom-ethqos: reuse the address of ethqos_emac_driver_data Message-ID: References: <20261014-qcom-sa8255p-emac-v16-0-0266c2ead980@oss.qualcomm.com> <20261014-qcom-sa8255p-emac-v16-5-0266c2ead980@oss.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20261014-qcom-sa8255p-emac-v16-5-0266c2ead980@oss.qualcomm.com> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfXz625R/0bIdsH JnPfBjj3KMl5qKPVxFT+j904JlN70qQhWFSAGA5bUuxsdivf7lbNPLAahlBoAjSxzqM9t5YDA2m 1FZjNaO0ucxnxx/IU6iC+vzRRqZhtkKfctm0XKNNuvyUzTwcG4smTx6KAaoYpupYMmQbC1BeX+F IW8sCjgmkWdjDnAHH+KQZXkcz6L7WIi0kA2st+cDqmJqA7/JaFQxcavd8OBC41BJ7DTey7Ybim+ qgx26C4sVNLPmfZUQo2wjZxXYbrJB5OYXPoqANQnZh3alL0U33/x6by1hC4SCg0Y8y+wbdRZCyf kUWlASbNxU6xpPf9XUYMBtetxV+AfAu1jWEFwetl6U58aoBBlhbIERKqxr0WS71MUkP8dUe46rR FnH32CRBtAICAFst+/dCZWImBl+eDntnjkNPzagypswXjIqETvDZ40rAh47q8QiC0+E6ztn2nGH FFx5VkErjB4i03Oq54A== X-Proofpoint-GUID: xhM7l06tJAv2kHYc8fJHJncg4XTg0bmf X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfX/Ris7ktCjoxn I3jvqXLtMgkBz4kd6WhJvKpQlUaHH2Ajk30kligpKy1rqZKp+KUTHQsUgKBPjzaQwFF5giweIbK kUB6PXi4H2RhL1rxCj9nq05NfkbVTas= X-Proofpoint-ORIG-GUID: xhM7l06tJAv2kHYc8fJHJncg4XTg0bmf X-Authority-Analysis: v=2.4 cv=Cowq4X4D c=1 sm=1 tr=0 ts=6ad3a589 cx=c_pps a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=XX1oeNa5M8xgm1Jp0F0A:9 a=CjuIK1q_8ugA:10 a=zZCYzV9kfG8A:10 a=bBxd6f-gb0O0v-kibOvt:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-17_05,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 adultscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610170066 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261017_094250_418942_FEE38619 X-CRM114-Status: GOOD ( 13.31 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Wed, Oct 14, 2026 at 02:36:44PM +0200, Bartosz Golaszewski wrote: > Instead of needlessly copying the fields of ethqos_emac_driver_data into > struct qcom_ethqos, just use the address of the former as a reference. > It's .rodata after all. This is done in order to avoid having either two > calls to of_device_get_match_data() or having to extend the latter with > another field when adding support for SCMI. > > Signed-off-by: Bartosz Golaszewski > --- After testing it on a couple of legacy non-SCMI boards, I did not find any issues with this patch, so: Tested-by: Mohd Ayaan Anwar Reviewed-by: Mohd Ayaan Anwar Ayaan _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84178CCF2C1 for ; Sat, 17 Oct 2026 16:43:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R5pJbF+5WsnybcUXBR9Bw+l+frOfwgNzH97CaTki/Rg=; b=Zq+sOZqx6AfGI4 DOIhh2aPfJHpnfniMEH4WFc1+raZJ6u1SJqaLiBKm0GNN0gnG7cyHV3KE1p3Oa12T3cyjKLC46BnV qmYlTSYqkbUmVjE6u5CbZnUwsJSBox8aEPP7SthMYiXanrAgfItD7ONBV3y2Xsb6U2K/g1sxLTMFX HB8B4sd88rD5bfW9AzalTEfc6vnAKQJgF8T6sPF8b+oehHYSs3Bieow2Astp1ObdYpOGGixSBpciH R3ixZT4Ee888YddEdrQcLkX68PjDbA6c36ZgbER3qRBFFtcAMLxsBnRs8kcrF57nsXnllXo5GdzmR XdN6KXU9Dalog1fTZP+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xI7Uk-00000004wn2-2Ndk; Sat, 17 Oct 2026 16:42:54 +0000 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xI7Uh-00000004wjq-1aV1 for linux-riscv@lists.infradead.org; Sat, 17 Oct 2026 16:42:53 +0000 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69HG9smV1332658 for ; Sat, 17 Oct 2026 16:42:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=A5QXkyLgqve2yg7aR0QbgBy6 tWTAd+S8xlmq02cu4VU=; b=lNhoZ5KmND8CPcI2ztJrmEz30rkXHlfA6ZXPZ/BF dIjaldaBjswQDQz152ahMBvv8elLhUYIikte8R33fvDM1XFYB4bJJwxbmkydvHs9 eShIPCBWf8E5pwxIyBHGeuDQy6qdqbdVggs0w6DviKRSBV4mr+P3cTJTp4wdY74Z 5KS3ymg6PgRQRKbX/+YVIu7Re+hZZAA+q5SytRzeNXF0f5SCG5w6ckx/tUicRxJW NwxJhIQeClRVZ0OtvWLuWHL0rqEzv6Gfy7aqB1TktkhdKtYwuruOrhAkDsgnYJJ5 WmRvDQrRAWN6umuhYE7m35Y2hOg40tfgMs8wZ1wwrVlYWw== Received: from mail-dl1-f69.google.com (mail-dl1-f69.google.com [74.125.82.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hbxcnsnns-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Oct 2026 16:42:50 +0000 (GMT) Received: by mail-dl1-f69.google.com with SMTP id a92af1059eb24-1383723dfddso1863220c88.0 for ; Sat, 17 Oct 2026 09:42:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792255369; x=1792860169; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=A5QXkyLgqve2yg7aR0QbgBy6tWTAd+S8xlmq02cu4VU=; b=KHHRRs9D9rXxwuqStD72wm0lV8UbC9/+xsXoWFejfstpoY2ng3UpEUh4VTUJ6VUe5Z BVFqFQ1rtfv8Z1lSfwY+vwTYDVI6yf2+Sg2R+hcF+KYZ0+6fgKJpZ0oqWBzq57MiGSJ1 cqYqakSV5AzsVKLRxZkOHPTGC9bqSNA1zFo5558/rG8jG+thrBwW9G7/skx0bop+zq/r Re4zS4R4wcpUkjYb8v5rrIWR4NdvhDUa+614Jvb3q017u+Nt3tSqHcHsXsk+Bilkra0t xEMoTBuoETFYF6Ng/RXrjxKCRYUILeBgzBifug5f46XooI/AMGekq287lDAlxtXb6tXp 31Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792255369; x=1792860169; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=A5QXkyLgqve2yg7aR0QbgBy6tWTAd+S8xlmq02cu4VU=; b=oNuWpJc6tM09zswLhCLN3I3wEsqrQyQ7/LSGN2eBgzGC1jTS3teGwQDzhTPainkgtw h29tRaN13HvzOHuVXZE0a9LjMvlxm5nZSmyXN77KYF2bxcwNrljP99JbhpAdUqxnv9sm Ouv20+gRqBrzBEp4gvIEq7K+3fuIAZv72sS+JsWwEVUtccF6VgvAGlr+J/PLbRlJSB7z roZQhN1rDM1mtgLI92yvxyH3fRY8fEbDmv3lyE6rCieb+pEKE+x2XqoqwXlL/+lyESDW w8WhbGQttZx2DFvwlhUpKNTAvN5AyG2XhQozTRQ8fVPuLZTdXE+8sa94/RIK7qKthhro tYMg== X-Forwarded-Encrypted: i=1; AKwUvBw57dsTOK6T9w9IXJmldHpQw83nlxpvd5rt5KNn01Rz3OqPTuLaTf4NuGuF4DWpj7I/vGkf8zsoKTkpGw==@lists.infradead.org X-Gm-Message-State: AFq9FYKeesvxKca6l4/YP9ijXBHE/UlNRUnMtaRtPqGV07tSCnuBCquU aA2lKy6cMsQ544gmoDy5e6hetosW0SFajPIjy0IQzU1TNXYJN+UVs1/lOE2eHawym1ArzkSRc2Q kZAX0UVxklC2lBw2Jf8nFG2HKBMPO+n6BLR6fhNB5zte2che02stWtIxWTTmfoX1K6GpZsWI= X-Gm-Gg: AYBFou1Cf3Pk1koPAC0Ck6FqlmNOQx5Gg4KGH51iSj1uaV5VjtxHsP3V42o9RDCgNiy kSjhlmCDn3p2sutyXWir3vF15s6ZYQXV48DhtChnFY4+xADEuzd5TkMgAqFhW27npdQVFxJiPZW LeDvHE/FJF5PCkC+GNEiPTP6Bf5FZHiqeFe4KpXsIN4/VqApe4+9nA3VOP8ukasddi1UDqCwUOP DAYkoKL+kjD47jMhLqP1LxeBryCf47brZuIt9yxsknSjYysW+aEiRu2e4IeMOzdXY7BgpqTOkxX 9ZaFgf4rlBRRbp15uso8RI+IMUhd4ZBF97weRKzpggU4eYE1DGVMEROJOhTwGdLWZlmEVYj0hBk Le29VE33OI8tHTw== X-Received: by 2002:a05:7022:7e89:b0:14d:ef19:246f with SMTP id a92af1059eb24-18513e7b18emr4689793c88.45.1792255369365; Sat, 17 Oct 2026 09:42:49 -0700 (PDT) X-Received: by 2002:a05:7022:7e89:b0:14d:ef19:246f with SMTP id a92af1059eb24-18513e7b18emr4689692c88.45.1792255368055; Sat, 17 Oct 2026 09:42:48 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-183190aa7bbsm15041602c88.5.2026.10.17.09.42.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2026 09:42:47 -0700 (PDT) Date: Sat, 17 Oct 2026 22:12:32 +0530 From: Mohd Ayaan Anwar To: Bartosz Golaszewski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , Bartosz Golaszewski , Eric Dumazet , Radu Rendec , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski Subject: Re: [PATCH net-next v16 5/7] net: stmmac: qcom-ethqos: reuse the address of ethqos_emac_driver_data Message-ID: References: <20261014-qcom-sa8255p-emac-v16-0-0266c2ead980@oss.qualcomm.com> <20261014-qcom-sa8255p-emac-v16-5-0266c2ead980@oss.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20261014-qcom-sa8255p-emac-v16-5-0266c2ead980@oss.qualcomm.com> X-Authority-Analysis: v=2.4 cv=BNUmP1QG c=1 sm=1 tr=0 ts=6ad3a58a cx=c_pps a=kVLUcbK0zfr7ocalXnG1qA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=XX1oeNa5M8xgm1Jp0F0A:9 a=CjuIK1q_8ugA:10 a=zZCYzV9kfG8A:10 a=vr4QvYf-bLy2KjpDp97w:22 X-Proofpoint-GUID: rEENHKcHWFn17VRPk-yBro0vJZqmWmvw X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfX+u5fy/ggz1D7 AcnKaLkOAkQZMQdeMkMasQE0+T2NR1xRMQCUFd2VNbCMw8uJpNH9cGMck8Ux/gzmD1zS7pU3hZz Cruw5WT5XOnuKxCogi1V6VQL4i3jTGU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfXyEbByNO+fba7 AkhPvVq+a2b/vr6kSOMq+ivCrYAcFYjZqZLX/vMDadxH2GDRmHdsSfsRek0+f3kgdQWurrx0Dsz LdzJB+NARIfMkAJxW8k1JbLWqsX0xtRoeutmR7d6ofmMehQftic0x8QoZ+sIwxgBRh5zvcDR6oe oqnV4tDF82GHnYGxX4bf8fcH43IV+hCoQfYiXN6aw/vQYzjaI8jMSLVBgEQOynjyfiu9eo5UhUX uR5N2UOkif3DwOkgQmxz57QRLF6VwE2wBYTH621s4CSwxyIoB0yBrwWXhe1zgP30J6Q8AibFQbC Aq+nY+H0z4bz/2hQSuJ8JmL3AIM/yeA1VzHzaVUE8trL8O3HHsK9ILLI2Reasr/phiptnD6aHAC 5YgKzO9qxu65X97VY6//9u/2Vb8l82lX71KRtPIL5Wcz8hS7mBXD96zR7iSIh1MkPRHrs3Ayz4m G5EZULA8w93VCNs8yHg== X-Proofpoint-ORIG-GUID: rEENHKcHWFn17VRPk-yBro0vJZqmWmvw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-17_05,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610170066 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261017_094251_531297_0FA1A920 X-CRM114-Status: GOOD ( 13.29 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Oct 14, 2026 at 02:36:44PM +0200, Bartosz Golaszewski wrote: > Instead of needlessly copying the fields of ethqos_emac_driver_data into > struct qcom_ethqos, just use the address of the former as a reference. > It's .rodata after all. This is done in order to avoid having either two > calls to of_device_get_match_data() or having to extend the latter with > another field when adding support for SCMI. > > Signed-off-by: Bartosz Golaszewski > --- After testing it on a couple of legacy non-SCMI boards, I did not find any issues with this patch, so: Tested-by: Mohd Ayaan Anwar Reviewed-by: Mohd Ayaan Anwar Ayaan _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7799CCCF2CA for ; Sat, 17 Oct 2026 16:42:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BW4xPUcs1779kW36YLuUjPeO5BwM2DOzAY7jGMkvpko=; b=BG8z37JRCf46+x nRrUlPAjpiqsnrnApWxgweOE/0dstaDDojLZEcF6CWzTtcz7YQQEI6fMqsZ+y1kYzvjBDtHa7Bg8K jKotahd0oGaPKATRWgehABNsUOiQvF6J65e6tJByNLtD0xcCH4VsZ8R2zc+EDvXCsUO2yqMEtmN7q m5nkvY4ZQmCZHwZzOy2th7xA78P2y3zAW4J90zK/uVKzVC+G+o68N6TyVKobFLp8eJipuDdNOLKhB 3Zlz2kdx1df3cTP+gNoD9d/XA8i7c8TIZeskPYZFWkx2PJHdTlqFiE2QO48B+Zb9/c8NSs4t6coIr j5MWprSUzib9u9dckO3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xI7Uj-00000004wlQ-0h96; Sat, 17 Oct 2026 16:42:53 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xI7Ug-00000004wiw-0OWm for linux-amlogic@lists.infradead.org; Sat, 17 Oct 2026 16:42:51 +0000 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69HGBXaC1523442 for ; Sat, 17 Oct 2026 16:42:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=A5QXkyLgqve2yg7aR0QbgBy6 tWTAd+S8xlmq02cu4VU=; b=lNhoZ5KmND8CPcI2ztJrmEz30rkXHlfA6ZXPZ/BF dIjaldaBjswQDQz152ahMBvv8elLhUYIikte8R33fvDM1XFYB4bJJwxbmkydvHs9 eShIPCBWf8E5pwxIyBHGeuDQy6qdqbdVggs0w6DviKRSBV4mr+P3cTJTp4wdY74Z 5KS3ymg6PgRQRKbX/+YVIu7Re+hZZAA+q5SytRzeNXF0f5SCG5w6ckx/tUicRxJW NwxJhIQeClRVZ0OtvWLuWHL0rqEzv6Gfy7aqB1TktkhdKtYwuruOrhAkDsgnYJJ5 WmRvDQrRAWN6umuhYE7m35Y2hOg40tfgMs8wZ1wwrVlYWw== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hc1839bdt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 17 Oct 2026 16:42:49 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-35cbea41088so1356011eec.1 for ; Sat, 17 Oct 2026 09:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792255369; x=1792860169; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=A5QXkyLgqve2yg7aR0QbgBy6tWTAd+S8xlmq02cu4VU=; b=KHHRRs9D9rXxwuqStD72wm0lV8UbC9/+xsXoWFejfstpoY2ng3UpEUh4VTUJ6VUe5Z BVFqFQ1rtfv8Z1lSfwY+vwTYDVI6yf2+Sg2R+hcF+KYZ0+6fgKJpZ0oqWBzq57MiGSJ1 cqYqakSV5AzsVKLRxZkOHPTGC9bqSNA1zFo5558/rG8jG+thrBwW9G7/skx0bop+zq/r Re4zS4R4wcpUkjYb8v5rrIWR4NdvhDUa+614Jvb3q017u+Nt3tSqHcHsXsk+Bilkra0t xEMoTBuoETFYF6Ng/RXrjxKCRYUILeBgzBifug5f46XooI/AMGekq287lDAlxtXb6tXp 31Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792255369; x=1792860169; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=A5QXkyLgqve2yg7aR0QbgBy6tWTAd+S8xlmq02cu4VU=; b=GW/YjmH4NhI+SwCSrN71ky2opZ5gHPBKvMe+3/Xx2yhK6N1Q9LluL5Xr4H2Ac/lazn BxQFoXkV/wHUruNZSbDySNbIOg9zv/1oij/+h8+S4n3WTRjlb1W05H8SX96859Qxrqtm JM8AK4K8KqOCY2rQi1mJadB2seM7b6q8/0/kxQv4jeLRPGMWtxxC9Ntu302/j6HlSexU X8IVYPsHDtYm32UxgaH826HMldBBV8PDxT0aTdasEam1SCtxVmztCQxar8GA5dqEp4RX IoQgsjGwQ04oehlqjFoOJHXyZMDeDkKMJK5Yf60TyfkJovddMgBt/dNg6Mrd8xW14JyI ahYA== X-Forwarded-Encrypted: i=1; AKwUvBz8+qYEbonwtdYGR4OJHtStwpsJ7CutKJqWTqN4Wwlhyvn1O0f66afLv3lTNEvZjzjUSc587rxuCMhloGnS@lists.infradead.org X-Gm-Message-State: AFq9FYKO9v9abr6CpLizQb4vbs90CNi9Lq48NEzUjXXHe53KI2MF1SxT IAY+hDe0aNZLHuEy16m6d2zDlIq8VG/D/TnrYMQlaB7ZL5kNnGUtG7m+oP5aomuEG5XAXU+rUIg 3n2oYwC7NWvV9p0CK0X8DQsv+Qr69mP8THshdyXXE9rsYHVd9pZatdNNLGs+JoNX3Aw/vlLCqqA == X-Gm-Gg: AYBFou0nh5qnq1RR1sakULjVnxGygPaAyygqTILAQPfDUomflTPP4m75AOmtX4bamqR oCVVUQqa4S6WUFLHWCjvM8mslwcOm+PcCOHHT/hGeE1JwaAG8dtmhhvm/spvcL9hRy5PKXgaVBE k3mjJ9YZaGkB+0M8RU377OhKeGIS/0VVgvrnSsWwQEIF52MaYc9a8B9U89QpbwSsVUxAnIeMmw8 kG2G3eCzvOr8NyQ+VjcQ7OnSjvRmO/5QpJV3VHE3RnKan2xSKge0dB4uov2UmNwnqxjgbfcLFS4 lClI0ZrYvsbFDL/v16NxzMCC+eX5QaSmqhkh49FmEvPi+SrnFUv3F/pWft2Ce817Q+dYU7+ba6g vii3Hl6sHR4Wbeg== X-Received: by 2002:a05:7022:7e89:b0:14d:ef19:246f with SMTP id a92af1059eb24-18513e7b18emr4689735c88.45.1792255368758; Sat, 17 Oct 2026 09:42:48 -0700 (PDT) X-Received: by 2002:a05:7022:7e89:b0:14d:ef19:246f with SMTP id a92af1059eb24-18513e7b18emr4689692c88.45.1792255368055; Sat, 17 Oct 2026 09:42:48 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-183190aa7bbsm15041602c88.5.2026.10.17.09.42.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Oct 2026 09:42:47 -0700 (PDT) Date: Sat, 17 Oct 2026 22:12:32 +0530 From: Mohd Ayaan Anwar To: Bartosz Golaszewski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Vinod Koul , Giuseppe Cavallaro , Chen-Yu Tsai , Jernej Skrabec , Neil Armstrong , Kevin Hilman , Jerome Brunet , Shawn Guo , Fabio Estevam , Jan Petrous , s32@nxp.com, Romain Gantois , Geert Uytterhoeven , Magnus Damm , Maxime Ripard , Christophe Roullier , Bartosz Golaszewski , Eric Dumazet , Radu Rendec , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Drew Fustini , linux-sunxi@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, sophgo@lists.linux.dev, linux-riscv@lists.infradead.org, Bartosz Golaszewski Subject: Re: [PATCH net-next v16 5/7] net: stmmac: qcom-ethqos: reuse the address of ethqos_emac_driver_data Message-ID: References: <20261014-qcom-sa8255p-emac-v16-0-0266c2ead980@oss.qualcomm.com> <20261014-qcom-sa8255p-emac-v16-5-0266c2ead980@oss.qualcomm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20261014-qcom-sa8255p-emac-v16-5-0266c2ead980@oss.qualcomm.com> X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfX7paF7HSqDAN4 /APf2ILWwQZ46P7SOyDBP/8va06n76sotXwbm3Whp6pmbo/6agUpTRvbn9Xfpzchg1N0j+UOyKx 4A5gqe53xUbMzitkIU+IHeMmRApOhrw= X-Proofpoint-GUID: K7qrQLnIR1woB9rteHufCQDzuAWRtsZd X-Authority-Analysis: v=2.4 cv=Bu8IUoX5 c=1 sm=1 tr=0 ts=6ad3a589 cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=XX1oeNa5M8xgm1Jp0F0A:9 a=CjuIK1q_8ugA:10 a=zZCYzV9kfG8A:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE3MDA2NiBTYWx0ZWRfX8JucW4Kqbvlg tty4LLp2z9voJvr7x9IqAn9MKJ9CTB1PvoUdTPEQAX/Zq4syLRaBWQZKsxO0Rw7prwNyEUSKMcu QKEdHvBwRby3H1ubAM2ViTClNi0H0LDBI5sjxfw6KcWuwrjbkmsbZucI4Gu8gf/ell7DH6HD6+F togx3ucDV5BDjb2FbgM0m2oDU5Puk0bICkteWXaHG5CAkoiZ94RTPFKnm5Hyko9p+4Qh7ve0zBy wfyV7b9//6wwWp+LhF/99Peqy3NyHb+1bCPTMQfqRxGOldH3LsvEiFrtlzapR8ZGUjxLJhjCbao I5Rbra+EaLxgVARHHs+g4E5eTFRmC9DvDsI5FSkNGqwWlCDtg9aFdRe+ZdUR8UZYjNlimcxXuWG zRccZQX0xvONOmiYRd+A08TSiiDo2bcNEjkvbS0Tql+MTBNZLLWzAsL3ytSEg55kaGiDns/nMoK VkYVU1q/IjudzDGVdfA== X-Proofpoint-ORIG-GUID: K7qrQLnIR1woB9rteHufCQDzuAWRtsZd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-17_05,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 suspectscore=0 clxscore=1015 adultscore=0 priorityscore=1501 phishscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610170066 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261017_094250_418434_0044C60A X-CRM114-Status: GOOD ( 13.22 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Wed, Oct 14, 2026 at 02:36:44PM +0200, Bartosz Golaszewski wrote: > Instead of needlessly copying the fields of ethqos_emac_driver_data into > struct qcom_ethqos, just use the address of the former as a reference. > It's .rodata after all. This is done in order to avoid having either two > calls to of_device_get_match_data() or having to extend the latter with > another field when adding support for SCMI. > > Signed-off-by: Bartosz Golaszewski > --- After testing it on a couple of legacy non-SCMI boards, I did not find any issues with this patch, so: Tested-by: Mohd Ayaan Anwar Reviewed-by: Mohd Ayaan Anwar Ayaan _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic