From: Harry Yoo <harry@kernel.org>
To: Vitaly Wool <vitaly.wool@konsulko.se>
Cc: akpm@linux-foundation.org, cl@gentwo.org, hao.li@linux.dev,
hch@lst.de, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
nickolai@csail.mit.edu, rientjes@google.com,
roman.gushchin@linux.dev, vbabka@kernel.org,
vitaly.vul@partner.samsung.com
Subject: Re: [PATCH v1] mempool: fix min_nr exceeding the elements array after concurrent resizes
Date: Sun, 18 Oct 2026 17:15:28 +0100 [thread overview]
Message-ID: <atTv1tg9q9n92kZv@thinkstation> (raw)
In-Reply-To: <20261018160315.1465504-1-vitaly.wool@konsulko.se>
On Sun, Oct 18, 2026 at 06:03:15PM +0200, Vitaly Wool wrote:
> > > How about we take my patch [1] instead since
> > > it isn't prone to this bug and is a nice optimization to the existing
> > > mempool_resize() at the same time?
> >
> > It is not a good idea to squeeze a bug fix and an optimization
> > into one patch.
>
> Generally speaking, yes. But that patch had been submitted before the fix
> popped up, so there was no sqeezing per se.
I mean the patch you've submitted does two things (wihch is not good).
It should be split into two patches that 1) fixes the bug and 2)
optimizes it.
(Setting aside the question of whether the optimization is worth the
complexity)
--
Cheers,
Harry / Hyeonggon
next prev parent reply other threads:[~2026-10-18 16:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 13:25 [PATCH v1] mempool: fix min_nr exceeding the elements array after concurrent resizes Nickolai Zeldovich
2026-10-16 15:46 ` Harry Yoo
2026-10-16 16:33 ` Nickolai Zeldovich
2026-10-18 15:01 ` Vitaly Wool
2026-10-18 15:15 ` Harry Yoo
2026-10-18 16:03 ` Vitaly Wool
2026-10-18 16:15 ` Harry Yoo [this message]
2026-10-19 6:45 ` Vitaly Wool
2026-10-19 13:27 ` Harry Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atTv1tg9q9n92kZv@thinkstation \
--to=harry@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@gentwo.org \
--cc=hao.li@linux.dev \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nickolai@csail.mit.edu \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@kernel.org \
--cc=vitaly.vul@partner.samsung.com \
--cc=vitaly.wool@konsulko.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.