All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Cc: Vincent Jardin <vjardin@free.fr>,
	Romain Naour <romain.naour@smile.fr>,
	arnout@rnout.be, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3] boot/uboot: support custom DTS with CONFIG_OF_UPSTREAM
Date: Sun, 18 Oct 2026 21:32:27 +0200	[thread overview]
Message-ID: <atUeDroTYvzii7To@windsurf> (raw)
In-Reply-To: <20261003210614.1376879-1-alexander.sverdlin@gmail.com>

On Sat, Oct 03, 2026 at 11:06:12PM +0200, Alexander Sverdlin wrote:
> Since U-Boot 2024.07, boards with CONFIG_OF_UPSTREAM build their device
> trees from dts/upstream/src/<arch>/<vendor>/ instead of arch/<arch>/dts/,
> so the files copied by BR2_TARGET_UBOOT_CUSTOM_DTS_PATH were misplaced.
> 
> Derive the destination from the U-Boot configuration, including the vendor
> sub-directory taken from CONFIG_DEFAULT_DEVICE_TREE.
> 
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>

Thanks for the patch. However, I don't really understand the
use-case. If your board DT is not in the upstream Linux kernel, why
would you enable CONFIG_OF_UPSTREAM in the first place?

The whole point of CONFIG_OF_UPSTREAM=y is to tell U-Boot "use the DT
from the upstream kernel". But if you have to copy your own DT, it
means your board DT is not in upstream Linux. So, just disable
CONFIG_OF_UPSTREAM in your U-Boot configuration, and use the existing
BR2_TARGET_UBOOT_CUSTOM_DTS_PATH option that copies to arch/ARCH/dts/
and does the job.

Could you clarify why we would want this change? I'm kind of missing
the point.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-10-18 19:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-03 21:06 [Buildroot] [PATCH v3] boot/uboot: support custom DTS with CONFIG_OF_UPSTREAM Alexander Sverdlin
2026-10-18 19:32 ` Thomas Petazzoni via buildroot [this message]
2026-10-18 19:45   ` Alexander Sverdlin
2026-10-19  7:42     ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atUeDroTYvzii7To@windsurf \
    --to=buildroot@buildroot.org \
    --cc=alexander.sverdlin@gmail.com \
    --cc=arnout@rnout.be \
    --cc=romain.naour@smile.fr \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vjardin@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.