From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 934414973BF for ; Sun, 18 Oct 2026 20:04:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792353868; cv=none; b=Mk/74vx81k7ysVxF/OY7+1ehAK2q6qBNG+me2XRnMwrBZeNGXWmUDr1ow6pxpXbqhyEDWrYg49csVZIS5LwawTG3AcB3vAzwI1ajxiFivP4v6ukPzlb+8KJGfGmD9SMyX4AZ50BYayXjIj1gTTAq9+gNxkpfBjdTILSmNkjEJOE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792353868; c=relaxed/simple; bh=DBE/gCmfuhXwykxDQWOrWz7lluxwth9kB66PmzDn3lo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EO4KvxCLIkZ1jhrexS+yuhKjJ5ufL3DCVTpNw5Y+xaZ8WbEt5xPJJ3l/EvrDadX5aHLaNzgWhsDoszduh4f5mbxjTwmtZoSqC+2QtAAAAaGJTwC6a3FsP5z7H7a1IwIlrfQiCNU4v4zU+r6MyzNu2Mcke6fbW9bKoxJraoh0YVo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WyPRuKrB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IxQAsvwk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WyPRuKrB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IxQAsvwk" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69IJQgtS3914774 for ; Sun, 18 Oct 2026 20:04:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= i3xZ9op9l58SU7/YC9N8juWPncXRu5l0tsz+cj5uvOA=; b=WyPRuKrB37c3X8Aj Jp1pnZjXYlcnbxq3+u/w3d3++aibxFILsd6NSKt2kKMMLfKBy0C9F7ZDVN39I2/6 GEYgtKgKXtFHt8jjiekUKZlIYcHY3Nno0Ktq55Q1kJho3VB1L9JjRMILTuqTOl91 HAf2eceZEQyEVOzL4oUWFwg8LK94sm4qc8CN2aSAClMZprJI4YJVhcm3zRfIJsh5 qSs6w+gsL5GRyZJBHbGXPXcGRDEyVHZO2OfgVbqRzuX3DGVB/Mn05xcaM5C5JaXf vGuWsAejptzO0/oJ6k29Tn5OpUL8zjRbqrfIVFyunI7YWBBA8FXS8dazKbvTSICj fsfmUQ== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hc2a9knxc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 18 Oct 2026 20:04:25 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-3580c07911eso4596955eec.0 for ; Sun, 18 Oct 2026 13:04:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792353865; x=1792958665; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=i3xZ9op9l58SU7/YC9N8juWPncXRu5l0tsz+cj5uvOA=; b=IxQAsvwkiYO2d2BJQ26kzK6tcB+v69N1psTXDuYxol+bUfq3CI3nCoQuJr3OZEcJV/ +9wXEkMyy9c3gRcLhkWCFljr2yF1vpKUJgRLJuTGqdfjLXw6/jgGcUtLwwRIzRPca79y Lj9kU8SO23EHEZnuzE6/r/rxvdONErq5DcAEY4fyI3co9R7Rv0T4uy6z6lE2Z4mnDWGp 4KpGeIbNovSIRLBhck3QQUJvhgEDvZlqNwnbQOPcts0o3vetCyRHf0tn90Y2IuXGCEHO QxueUfKx0QdmnAD/JnmO1C8A5hnHMdApItlGJUmd+syXkNduqQPCJDVzh6a3nzEZmFye QRkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792353865; x=1792958665; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=i3xZ9op9l58SU7/YC9N8juWPncXRu5l0tsz+cj5uvOA=; b=Q3E1qk0F6Socv6GjiyFt7LVUxQliaDwqTVKZBEndYiOI79sCf4sWClIYlb87kR403v AJEutUUR6xUDjeYb+8RcKIo97I75PfGQ7i+BUWZfiOar5VYxx/2z6XpgpZgMB+tWg3MW z86y/o1/uvCnPh/GBIUuw8H5GHFkHckJdKYbcJ3Io4qa/4fI+x5x+XanZU3DJHJLHnYZ ImcGmhtGBxZMR6l/eh8Y+MCMVDsH7n0+HkGTvjL8utRuLIyUS/DQtkgKaI7ZZU8WmnJT zFHZB8XHW3coTTuNw8ZGHVfnejWwPFweevRnu8z0Lzj+S0O0zRUTQgR3wYHXRWx8hGyG 7loQ== X-Forwarded-Encrypted: i=1; AKwUvBww/qpThSjNfDi7CKrc7yCZlgi+sRSZ7pGS6zLLaJDnSxL3MFD/lOpwMPunlgToBAKZuPFeMpsuLxMm@vger.kernel.org X-Gm-Message-State: AFq9FYJllWCEzSB8kgu9HVqHM5rbDvw+r+TCRw3c7zeSyqRnok3oqlnJ dagALx+af+T6Y7f+5DR40QDwaYAU1Ta93DoiVrvHIUHiOX8DiwHWc27y636WqBk3GOcQimo3WWN PG5UHoMD2fAJm/b/LdWoO87g8PWTVCAb5wDRmIgZR8miINrJjCiu+lfRAjU/wFdF5 X-Gm-Gg: AYBFou1qV8F5be0JQpApSLlXxMnbJ9fIrm6R83edulNgl6hB1Q6DyeyqJWovzy7ZPX0 GqTVPrRqYtebv34NwoJfMvGXDJ/ZiaHKLXz85Nl3gALm3K9ggfGCYOVp56AOWtxGLZ87dACuEv6 i1PZKkp1N76KteQX59jbnrfVLaWaHT0vmRg1lJZeVtZPtDwhEiuKNb3mUadhDhx/kEbjr9iqGaX 4JNtSRqr6EA+taV7z0feUEIlVmTnHu6TIEZuUvGHtTnbZWPfvyk5bXfKMgxsW8KMRI7aeRMG8Xz EOiM7bHZWVMFQ/xHi3t5pPPGUiQ5pdyNnu1+VKgDaTlHd8X5ImrF972wb9o2pn1e94EcZAymcE9 DrMBDGs59DYu1 X-Received: by 2002:a05:693c:4003:b0:351:6409:25c9 with SMTP id 5a478bee46e88-361a2942adbmr9329025eec.35.1792353864884; Sun, 18 Oct 2026 13:04:24 -0700 (PDT) X-Received: by 2002:a05:693c:4003:b0:351:6409:25c9 with SMTP id 5a478bee46e88-361a2942adbmr9328972eec.35.1792353864174; Sun, 18 Oct 2026 13:04:24 -0700 (PDT) Received: from oss.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3608308a87csm43680240eec.28.2026.10.18.13.04.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Oct 2026 13:04:23 -0700 (PDT) Date: Mon, 19 Oct 2026 01:34:11 +0530 From: Mohd Ayaan Anwar To: netdev-bot+sashiko@kernel.org Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, afd@ti.com, andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, richardcochran@gmail.com, andersson@kernel.org, konradybcio@kernel.org, alexandre.torgue@foss.st.com, peppe.cavallaro@st.com, joabreu@synopsys.com, maxime.chevallier@bootlin.com, mcoquelin.stm32@gmail.com, lorenzo.bianconi@oss.qualcomm.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v3 4/9] net: stmmac: qcom-ethqos: fix RGMII_ID mode to use DLL bypass Message-ID: References: <20261017-shikra_ethernet-v3-4-26a8beb44b8f@oss.qualcomm.com> <179232045490.3135.14337314664378256554@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <179232045490.3135.14337314664378256554@kernel.org> X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE4MDA3OSBTYWx0ZWRfXzbDDSGA8CPc7 tMgJY1/A5c5RINlUG3Ag1PJnoPRn7NNmhNfepk0h0z0vOn8IDXbvg+PVB3WfWnaFBKCxPOULmXC puVoANcAsrDQlkoptr2j6JSVTvaq5yI= X-Proofpoint-GUID: 6PgD0py2fJmSrSulwAfVfMsQw57n7pyT X-Proofpoint-ORIG-GUID: 6PgD0py2fJmSrSulwAfVfMsQw57n7pyT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE4MDA3OSBTYWx0ZWRfX99G7fgHyuTjW c+WJxyjRPjbBeaCMP5pYqqDcXOeOWRC9az1z3psqJrZJ6s+4sBLqG93MjUpB4OPJ9+NI2wshxyZ 0YdKTUw/h6nktfQbt2YB+Bh3EDUbGCTtT46beUt56c+WcG9X5lpqsLJub19WmSndgTT1PwnaMsR CmYgSeAza9+xpUyDL5jW+dsRZVX/h7mTefrgkvMFdombD9kSkJ1YDMvzwtVxfM+/W+Xg8dc/jce Xk0OI8TIa9iGa/TTDdmsVnnL8P/wSv3OfjJ08Qjv4+ge4UBvP/wEybXjY6pDCftMLwPARbRw+72 PG0skTYg4q0nrc/GdQwhpA7jtKf18lQbYyTwADQp998xjtrjg4WycimYLTk224fmMG0U9XmdsFw K93QWTArqMXAhoIlzz4RXzFhXrBsYalvMEOe8GuQ50Y2DnysHmseCtdCdveh++P1OLCGWd8gotc Zo5Wg/qFZGjWRRDX7iw== X-Authority-Analysis: v=2.4 cv=PMeaavqC c=1 sm=1 tr=0 ts=6ad52649 cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=rVh5EO9gQq6FD6a5X-wA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-18_04,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 spamscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 adultscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610180079 On Sun, Oct 18, 2026 at 10:47:34AM +0000, netdev-bot+sashiko@kernel.org wrote: > Thank you for your contribution! Sashiko AI review found 3 potential > issue(s) to consider. > > Critical: 0 · High: 0 · Medium: 2 · Low: 1 > > If you believe none of the issues are legitimate, please reply to each > issue of Medium severity or higher and explain why the AI is wrong. > If any of them are legitimate and you plan to respin, please let patchwork > know by including "pw-bot: cr" as a separate line at the end of your reply > (one such reply per series is enough). > > - [Medium] In rgmii-id mode at 100M and 10M, ethqos_set_clk_tx_rate() now > calls clk_set_rate(link_clk, 25000000) or clk_set_rate(link_clk,… > - [Medium] net: stmmac: qcom-ethqos: rgmii_setmask() on multi-bit > RGMII_CONFIG2_RSVD_CONFIG15 > - [Low] The commit is titled and described as a fix for a defect in the > current tree, but it has no Fixes: tag. > > -- > > > [Severity: Medium] > Can qcs404 and sc8280xp actually produce 25 MHz and 2.5 MHz on the link > clock? > > On qcs404 the "rgmii" link clock is GCC_ETH_RGMII_CLK. Its parent's > frequency table only has these entries: > > drivers/clk/qcom/gcc-qcs404.c:ftbl_emac_clk_src > 5 MHz, 50 MHz, 125 MHz, 250 MHz > > On sc8280xp it is GCC_EMAC0_RGMII_CLK, and the lowest entry is 50 MHz: > > drivers/clk/qcom/gcc-sc8280xp.c:ftbl_gcc_emac0_rgmii_clk_src > 50 MHz, 125 MHz, 250 MHz > > Both branch clocks have CLK_SET_RATE_PARENT. The parent RCGs round up > rather than fail: > > drivers/clk/qcom/clk-rcg2.c:clk_rcg2_determine_rate() { > ... > return _freq_tbl_determine_rate(hw, rcg->freq_tbl, req, CEIL); > } > > So in rgmii-id mode at 100M/10M, the request would silently become 50 MHz > or 5 MHz on qcs404, and 50 MHz on sc8280xp. clk_set_rate() would still > return 0. > As mentioned in another reply, I will update the series to use this new flow for PHY managed RGMII delay for only SoCs that could be validated, i.e. shikra and qcs615. Ayaan pw-bot: cr