From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 064C847FB03 for ; Mon, 19 Oct 2026 06:14:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792390494; cv=none; b=WR09g0lOE4BDDOZwagFPcXs+ih/n/5AoL9XsU5P3kZO2juYnHxuU6GCdXLho5Tryb/tLFmBQ5i1Ctl2qkOLoEbRR9u+sKMPhtdfSLLNIz4X8Di/l/1eAJHfTxTZ4vVVjRO7VZcLOIWppDTvQWMS9+A6+3G47iqB/Sa9wk7e6KFE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792390494; c=relaxed/simple; bh=hLviHrUQcnY9d6Hs59o7A7DhG6hJV3vxIcScsJNeYyM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CDYP8HL8qyuh1lnz7lSpnoLFVjI+grYm+P155hpQSna2Xz8Y95PclxJbaCKCaMLFV+qTiI8OURf0A3clr6Z/6wyEO1MhHT2TEE/zjJr+3e9k2MZRhQM33Sy4CPJ6lHhSe5b1ASF7kNZy3crIVDUtlq42wRel5ZHqq3TLC9bUOqs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b15sAq9N; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b15sAq9N" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-3ab9268d90eso974393a91.3 for ; Sun, 18 Oct 2026 23:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792390492; x=1792995292; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=CH7/2Pn88Czop2CrZPadAXkcJAGF4wsEW/e1YNB1cxQ=; b=b15sAq9NWihv6GFpfqSH5HJ3jmNXepVPacRSjllpONskWo3VoEK4Itgk5hQGhDqVUm OWiPBYy0UhE40WYO7DWnLZlZpp1Jwz4eqeXN2NSXpBe447i3vO6tMCc7g3awQB10u3Jj jTYX/R96bQphJx/b/em2D3HoMpomNXcg8xaw48nYpVKInNkwqKttKW2Y5t+OgBhBj5Fy EbpmE93ZISJExcTC6ZjYcexazX0RFzhEETQCXjJaWpZSM11D4gqsKPPoT80kk/2BPyfp 49Q5kSYl++unHpMs6blx4qxYak19NowZTS7eZvDPax0vG4/9RmoFI/cMVEqXRgNQ7P5Q Zvog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792390492; x=1792995292; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CH7/2Pn88Czop2CrZPadAXkcJAGF4wsEW/e1YNB1cxQ=; b=TAnp4Z/7Pq6o1eM0C+ZNuUAdCZ7+DMXMS73rY8zf3DGBeIVKZj/QJB+TSEgj+hvpE7 pAhD+JVVIG7Q10sRtcZIP0+f5IWzQvDcAfkymvfhUiCKKqi906DC46IXVuc0AeBwKonz tEsKpZWtP1D7D+xp0jxz5R4oU/8FquIonoNKgdZPEQWcqh0/tIfPU6o2g95oPvCf14sd /SABEe45hbZXP84+ULE0GC+0JasL6K9TwInC+DAA+qc6rRUkFZFAyawPRIBW/142FlEP RK3hjvW+NccCf0pWos3dYFXBsaVStlS4GwN+Byt88lJ3qjKag6MCu5HK5OkOmf2G9Hk3 qQWQ== X-Forwarded-Encrypted: i=1; AKwUvBwG/3RZiyMyNjCgrEhpjHMw2yv+rCAyNKi9/cFRn8FnQcY4SBttAggfV1V45AEnpDKczH05NYLltUM=@vger.kernel.org X-Gm-Message-State: AFq9FYK80cpSen0G8x2jTlKt11YVsnpStFzA/h0HWSFLvzLNzfxPA1L/ gweGF7XsNgcGLrlSezjVkf6vSL5cjwI9S6xetiYDa2eDG1l1weTLD2I2 X-Gm-Gg: AYBFou0S0Ql3fHqZilIMyXRhDykPKgWdaSudW9zvpAMoMRQyzh80BDMHb7S3T1GSQB7 tVTjAC/VAFKDIxAdfjKDrsNfixDTaAl033UWmjZFDN2YAPTF8ks4mDtwIlLN/rgsWBo72uBE7h7 MR7I6EpzGnzQS1vZEKe+Fe9Kmw4pO837o/krCBmmRxT6dbGoCfIBXB/AR1BgsELbQDl5gINXv5h lMYessp+FPR5lJfQCbJGemh8xhg5heVvtucImx73stn5/IFYDB+rtMGx1O8N1UdyUsfBdq2dvqs uKCsXh3dA74cluFtLbqsTpVbQxYkHQideAPYc+fTH4svyjTpi3Kny91UKE63HQ1Ecag6WONZwI/ BZFUrmpmX1//emUfA5x6L/3DX+m/tXC8gPH6KO5uie6tSVSYbVxOXrlPDQB85yQP9ZmaHE7agvy irrGTvYgqxDIX71aTxEBjdmh/itlb1PJ+8FHOvj7XM5i7Ne4epY8fPJ9KSmMjj X-Received: by 2002:a17:90b:3851:b0:3ab:c80:9362 with SMTP id 98e67ed59e1d1-3aceeea8f3amr5078332a91.35.1792390492104; Sun, 18 Oct 2026 23:14:52 -0700 (PDT) Received: from localhost ([27.122.242.71]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ac94794dd9sm19035101a91.12.2026.10.18.23.14.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Oct 2026 23:14:51 -0700 (PDT) Date: Mon, 19 Oct 2026 15:14:46 +0900 From: Hyunchul Lee To: Christian Brauner Cc: Jan Kara , Al Viro , ecryptfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, exfat@lists.linux.dev, linux-fsdevel@vger.kernel.org, ntfs@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-btrfs@vger.kernel.org, gfs2@lists.linux.dev, linux-efi@vger.kernel.org, linux-mtd@lists.infradead.org, linux-xfs@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH RFC 14/28] ntfs: don't set SB_RDONLY after filesystem errors Message-ID: References: <20261012-work-fs-sb_rdonly-v1-0-60743a3dc326@kernel.org> <20261012-work-fs-sb_rdonly-v1-14-60743a3dc326@kernel.org> Precedence: bulk X-Mailing-List: linux-efi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20261012-work-fs-sb_rdonly-v1-14-60743a3dc326@kernel.org> Hi Christian, > diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c > index 4066bacabe37..12ad2ce938ba 100644 > --- a/fs/ntfs/super.c > +++ b/fs/ntfs/super.c > @@ -269,6 +269,8 @@ static int ntfs_reconfigure(struct fs_context *fc) > > ntfs_debug("Entering with remount"); > > + /* Mark the volume dirty first if an error made it read-only. */ > + flush_work(&vol->error_work); > sync_filesystem(sb); > if (sb_rdonly(sb) && !(fc->sb_flags & SB_RDONLY)) { .... return -EROFS; Before this patch, SB_RDONLY is set, so remount,rw returned -EROFS. With this patch, sb_rdonly(sb) is false, so remount,rw skips the check and return success even though writes are rejected with -EROFS. I think that the condition should be test NVolErrors(), for example if ((sb_rdonly(sb) || NVolErrors(vol)) && !(fc->sb_flags & SB_RDONLY)) { -- Thanks, Hyunchul From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0BFDCCF2DA for ; Mon, 19 Oct 2026 06:15:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B+sb0rr3ZDZ0rjRiVjWn43Hb5P8eYYTYFrF8WOkV4qM=; b=NLaCOF7D34kZWo GCV8yDp/rcDwAA5Kp3SbTcEMD3ylwcDsVPjxBvIu4CtrIZ+xi6ii66l62bo3SHYpDgFEiFTWFOt1+ DBTWbvxzmqiV4pv1ipJrtylmozW5OATzQEWau+Yl9LS3q/f2p3yvq5buivWRaKhSJ/DzbEtiRrH/Y fZpgQUwcNdPPUK0ZfbRprsj6/2S1KxEIW2YYnTu7mff48cfjNGGs4DNN4+PACBWIYmfos+hA9HATA dBQnVncRPzoh3NogkBgj8Q7+/cN6rbRWjEnYRcueSr4LN5GiE3PM2b4APFnnscOTJbsiLawuNZzyW EiyC/vUIzsctXAxfUqKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xIge8-00000006gF3-1s9Y; Mon, 19 Oct 2026 06:14:56 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xIge5-00000006gEg-3GAc for linux-mtd@lists.infradead.org; Mon, 19 Oct 2026 06:14:55 +0000 Received: by mail-pj1-x102a.google.com with SMTP id 98e67ed59e1d1-38d489b6b71so934925a91.0 for ; Sun, 18 Oct 2026 23:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792390492; x=1792995292; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=CH7/2Pn88Czop2CrZPadAXkcJAGF4wsEW/e1YNB1cxQ=; b=McqFomcOwuuUrazLCYHWyb5IDYuYKEXLE+gvNFn+npP+CnHJXttwHAzxY9uR5XUdqL pfbRkj6mL80N6WyLbsx5xiX5y7eF+01bA7xozNFxZ+v9WkkA98AxzT/CZjobs2lvpZ1e AQsvw2kjzZhLv50xz1jrkTjCajaAumx8V/piyWfoJQQPmw9f4JNOzbp5sFeqFZ12gytr 4X4cm7FyS9QeJB8OHov+X0ni0Npdg/G/9ybz8Tner6PilptciilEJUVBai3SUiXrx9EU U4fSubZN/JgV8NNLtjSxaee2nooD5xG6AOHPK3bgxSvdIAg0D5j7diw2isvpG/VaGnYq mnhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792390492; x=1792995292; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CH7/2Pn88Czop2CrZPadAXkcJAGF4wsEW/e1YNB1cxQ=; b=0wOZFhFWr0/7Hu81OWVAtjyIW0NAleo51DDWF+UuRk5HVo6jTSN511YrGcNasnlgXj dIN1Ia5uQ5HpoKkx1kJtPAjFtf1y9OZ4v/fBfa79MzH7ttg+H+xp6Cx7BWp1fU8y65qM fh2cRRLDeAYAQFQKUA/E+PjGIEinOWQwHhd00PWW2HrKESyyA1+a0rsSVfG4H4JvgR0s vOKtvLjMCq/LpRd5ZgnSzaVzF8h3Ou233nGLXzLoVJl+gmE/S+F84OA7OszWbrCs73Rs HyfawHXZs1w0e5F/GUhtDGaHuSzQIFFdNFvVbMp8WnHFOssbdhWg3I01XpgwjfI7EUlZ RNGg== X-Forwarded-Encrypted: i=1; AKwUvBy3iC1LvMugYv+mwXzI2+vEj7uLxtsEzUvYZjEpsm9y45T/ser/VzdabiwHibw1mzUL5A/iZ8dv6tA=@lists.infradead.org X-Gm-Message-State: AFq9FYI/kCHgL8BTS28Hyw7EjMQLWHWK1rBHAQIPOEFnXh7GIf0xpcZF zXF90499S/zvUpuUPPaN++ILkk9XzehO4RL4XiLwvmg70CP3Z0oxrVqT X-Gm-Gg: AYBFou0xs1r+Ra8kVO2vl/HZpM6jWHJFajpcn/0Gl4ixeqiibdsWydl7DlXKbSrBrhQ M46l+IfYncnzAqgAUTVKdrRPiyRpeLDCxK4wCkEB9bb0cO8Fc1/aybIrNs3ufVtbWWK/uKQy7he NQnRScDs4gr5OwmfxUDAP1xRcGhecCDzkWJNpvyY+A0P30uoadwFAcrbVSQubGo98zmuKlbGgjd 5nW9GAD70pYPrE0+ssdl/JOKhCsjSPy+URRwB1hqre5MQOyOrFIEBQwqkUQT0bE4hE/YZjitR/w 4bjEDejQ/QnVnxY4EmCuv673jQbhYsrVthbtXXRmxPF/Bm1Q56vg5jg/7kSJNt/lRaH8Tl6wY7m qxA2tRKmTA/VhdcyCmN3vPihr2x9diKYPfONRugaPdAa5pTsbfakE4BngJNuVmO+03slPLLbSrR Hz1DYdf7c6DesHZ1YzDTbiv9bBxiVxi6l6/G99G3fjfinqNX3ZwbOnzWGi28/H X-Received: by 2002:a17:90b:3851:b0:3ab:c80:9362 with SMTP id 98e67ed59e1d1-3aceeea8f3amr5078332a91.35.1792390492104; Sun, 18 Oct 2026 23:14:52 -0700 (PDT) Received: from localhost ([27.122.242.71]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ac94794dd9sm19035101a91.12.2026.10.18.23.14.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Oct 2026 23:14:51 -0700 (PDT) Date: Mon, 19 Oct 2026 15:14:46 +0900 From: Hyunchul Lee To: Christian Brauner Cc: Jan Kara , Al Viro , ecryptfs@vger.kernel.org, linux-ext4@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-nilfs@vger.kernel.org, exfat@lists.linux.dev, linux-fsdevel@vger.kernel.org, ntfs@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-btrfs@vger.kernel.org, gfs2@lists.linux.dev, linux-efi@vger.kernel.org, linux-mtd@lists.infradead.org, linux-xfs@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH RFC 14/28] ntfs: don't set SB_RDONLY after filesystem errors Message-ID: References: <20261012-work-fs-sb_rdonly-v1-0-60743a3dc326@kernel.org> <20261012-work-fs-sb_rdonly-v1-14-60743a3dc326@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20261012-work-fs-sb_rdonly-v1-14-60743a3dc326@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261018_231453_841642_C48ECD7B X-CRM114-Status: GOOD ( 12.25 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi Christian, > diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c > index 4066bacabe37..12ad2ce938ba 100644 > --- a/fs/ntfs/super.c > +++ b/fs/ntfs/super.c > @@ -269,6 +269,8 @@ static int ntfs_reconfigure(struct fs_context *fc) > > ntfs_debug("Entering with remount"); > > + /* Mark the volume dirty first if an error made it read-only. */ > + flush_work(&vol->error_work); > sync_filesystem(sb); > if (sb_rdonly(sb) && !(fc->sb_flags & SB_RDONLY)) { .... return -EROFS; Before this patch, SB_RDONLY is set, so remount,rw returned -EROFS. With this patch, sb_rdonly(sb) is false, so remount,rw skips the check and return success even though writes are rejected with -EROFS. I think that the condition should be test NVolErrors(), for example if ((sb_rdonly(sb) || NVolErrors(vol)) && !(fc->sb_flags & SB_RDONLY)) { -- Thanks, Hyunchul ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/