Re: [PATCH v3 1/3] imap-send: use the recommended TLS_method()

[Patrick Steinhardt <ps@pks.im>]

On Sat, Oct 17, 2026 at 12:09:54PM +0200, Beat Bolli wrote:
> SSLv23_method() has been deprecated since OpenSSL 1.1.0, and
> TLS_method() is the recommended function[1].
> 
> Let's use the current function, lest a reader of the code thinks we
> don't support current TLS versions.
> 
> [1]: https://docs.openssl.org/master/man3/SSL_CTX_new/#history
> 
> Signed-off-by: Beat Bolli <dev+git@drbeat.li>

I would have appreciated a cover letter that points out:

  - What this series is doing.

  - What has changed between v2 and v3, ideally including a range-diff.

Like, why is there a third patch now, for example? I have no idea, so
for reviews to go smooth and efficient we require help from the authors
of a given patch series.

I would recommend using b4 going forward, which automatically manages
all of those details for you.

Also, we strongly encourage folks to please reply to review feedback
directly instead of just sending the next version of a patch series.

Patrick