From: Florian Westphal <fw@strlen.de>
To: liuc63 <liuc63@xiaopeng.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Phil Sutter <phil@nwl.cc>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Florent Fourcot <florent.fourcot@wifirst.fr>,
Romain Bellan <romain.bellan@wifirst.fr>,
Weibin Liu <liuwb@xiaopeng.com>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] netfilter: nf_conntrack_netlink: fix inverted IPv6 tuple filter
Date: Mon, 19 Oct 2026 10:42:11 +0200 [thread overview]
Message-ID: <atXX4zhsKh_qRvgM@strlen.de> (raw)
In-Reply-To: <20261019075629.2091511-1-liuc63@xiaopeng.com>
liuc63 <liuc63@xiaopeng.com> wrote:
> From: Liu Chao <liuc63@xiaopeng.com>
>
> ctnetlink_filter_match_tuple() returns 0 (no match) when the IPv6
> source or destination address differs from the filter, because the
> !ipv6_addr_cmp() test is inverted. ipv6_addr_cmp() returns 0 when
> the addresses are equal, so the negation makes the branch trigger on
> a match instead of a mismatch, which is the opposite of the IPv4
> path above.
>
> Drop the '!' so the IPv6 branch returns 0 only when the addresses
> differ, matching the IPv4 semantics and the caller's expectation.
Reviewed-by: Florian Westphal <fw@strlen.de>
prev parent reply other threads:[~2026-10-19 8:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 7:56 [PATCH] netfilter: nf_conntrack_netlink: fix inverted IPv6 tuple filter liuc63
2026-10-19 7:58 ` netdev-bot+sinfo
2026-10-19 8:42 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atXX4zhsKh_qRvgM@strlen.de \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=florent.fourcot@wifirst.fr \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=liuc63@xiaopeng.com \
--cc=liuwb@xiaopeng.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=romain.bellan@wifirst.fr \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.