From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Myeonghun Pak <mhun512@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
patches@opensource.cirrus.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
stable@vger.kernel.org, Ijae Kim <ae878000@gmail.com>
Subject: Re: [PATCH v4] ASoC: wm8962: Stop IRQ from requeuing mic_work on remove
Date: Mon, 19 Oct 2026 16:39:43 +0100 [thread overview]
Message-ID: <atY5v0BUNKLtm99Q@opensource.cirrus.com> (raw)
In-Reply-To: <20261018021817.3859256-1-mhun512@gmail.com>
On Sat, Oct 17, 2026 at 10:18:17PM -0400, Myeonghun Pak wrote:
> The WM8962 IRQ remains registered to the I2C device when an ASoC card is
> unbound. wm8962_remove() cancels mic_work, but a MICD or MICSCD interrupt
> can queue it again before the component is destroyed. The work then
> accesses the component and reports to the old jack.
>
> Mask microphone interrupts and disable detection in wm8962_mic_detect(),
> wait for any handler that already read the old mask, and drain mic_work
> before changing the jack pointer. When installing a new jack, unmask its
> interrupts before enabling detection, preserving the existing hardware
> sequence. Call this path from component remove while the component is
> still valid, leaving the IRQ registered for FLL, FIFO and thermal events.
>
> Tegra's card remove callback runs after ASoC removes the codec component
> and PCM runtimes. Drop its redundant microphone cleanup.
>
> Fixes: 0512615db6db ("ASoC: wm8962: Convert interrupt handler to direct regmap usage")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Co-developed-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Ijae Kim <ae878000@gmail.com>
> Signed-off-by: Myeonghun Pak <mhun512@gmail.com>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
prev parent reply other threads:[~2026-10-19 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 2:18 [PATCH v4] ASoC: wm8962: Stop IRQ from requeuing mic_work on remove Myeonghun Pak
2026-10-19 15:39 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atY5v0BUNKLtm99Q@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=ae878000@gmail.com \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mhun512@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.