Re: [PATCH 2/7] Input: s6sy761 - split into core and I2C modules

[Lukas Timmermann <linux@timmermann.space>]

On Mon, Oct 12, 2026 at 01:04:36PM +0200, Uwe Kleine-König wrote:
> On Sun, Oct 11, 2026 at 02:44:57PM +0200, Lukas Timmermann wrote:
> 
> Please don't add new usages of <linux/mod_devicetable.h>. <linux/i2c.h>
> is enough to get the definition of of_device_id and i2c_device_id.
> 
> I didn't look into the other patches of this series in detail, but I
> suspect that the same holds true in your spi patch. <linux/spi/spi.h>
> provides of_device_id and spi_device_id, so don't add
> <linux/mod_devicetable.h> there either.
> 
> (If you want to go full iwyu, use the subsystem specific headers below
> linux/device-id/.
> 

I see. I found some mails from you in regards to that topic. Thanks for
explaining.

> > +static const struct of_device_id s6sy761_of_match[] = {
> > +	{ .compatible = "samsung,s6sy761", },
> > +	{ },
> 
> No trailing comma after the list terminator please.
> 

Noted.

> > +};
> > +MODULE_DEVICE_TABLE(of, s6sy761_of_match);
> > +
> > +static const struct i2c_device_id s6sy761_id[] = {
> > +	{ "s6sy761" },
> 
> please make this: { .name = "s6sy761" }
> 
> Best regards
> Uwe

Thank you. I will include your findings in v2.

Best regards
Lukas