From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Tristan Madani <tristmd@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, tristan@talencesecurity.com
Subject: Re: [PATCH] Input: applespi - validate ACPI property buffer length
Date: Mon, 26 Oct 2026 18:04:00 -0700 [thread overview]
Message-ID: <at_4L4QXfXikGrAy@google.com> (raw)
In-Reply-To: <20261027002919.3589149-1-tristan@talencesecurity.com>
Hi Tristan,
On Tue, Oct 27, 2026 at 12:29:19AM +0000, Tristan Madani wrote:
> applespi_get_spi_settings() reads three ACPI _DSD properties
> (spiCSDelay, resetA2RUsec, resetRecUsec) as u64 values from their
> buffer pointers without verifying that the buffer is at least 8
> bytes long. If a firmware implementation provides a shorter buffer,
> the u64 dereference reads beyond the allocated object.
>
> Add buffer length checks before each u64 dereference.
>
> Fixes: 038b1a05eae6 ("Input: add Apple SPI keyboard and trackpad driver")
> Cc: stable@vger.kernel.org
This makes sense but we somewhat trust system firmware so why is this
needed in stable?
> Signed-off-by: Tristan Madani <tristan@talencesecurity.com>
Why is the difference with From: ?
Thanks.
--
Dmitry
prev parent reply other threads:[~2026-10-27 1:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 0:29 [PATCH] Input: applespi - validate ACPI property buffer length Tristan Madani
2026-10-27 1:04 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=at_4L4QXfXikGrAy@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tristan@talencesecurity.com \
--cc=tristmd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.