From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Scott Collyer <scollyer@google.com>
Cc: Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/chrome: cros_ec: trigger kernel_restart on EC_HOST_EVENT_PANIC
Date: Tue, 20 Oct 2026 00:44:47 +0000 [thread overview]
Message-ID: <ata5f5ZmYkrcdt_I@google.com> (raw)
In-Reply-To: <CALUcz=0TtozoU+EP97Pu5pPYc=_G97xM=yR3cZ9WH_kLgrxQoQ@mail.gmail.com>
On Mon, Oct 19, 2026 at 03:12:37PM -0700, Scott Collyer wrote:
> On Sun, Oct 18, 2026 at 7:50 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
> We would like to drop kernel_restart() entirely and instead focus only on
> surfacing the EC_HOST_EVENT_PANIC event so that userspace crash reporting
> daemons can collect the panic dump and handle recovery policy.
>
> Specifically, for non-ACPI/LPC transports (e.g. MKBP host events
> over ISHTP/SPI),
> we would:
> 1. Register a subscriber on ec_dev->event_notifier (e.g., in cros_ec_dev) to
> listen for EC_HOST_EVENT_PANIC.
> 2. Trigger the existing ec_dev->panic_notifier chain so debugfs flushes any
> pending console logs.
> 3. Emit a kobject_uevent (e.g. ERROR=PANIC) on the cros_ec device kobject to
> notify userspace crash collectors.
>
> Does this separation of mechanism and policy align with what you'd like to
> see upstream? If so, would you prefer the event notifier subscriber in
> cros_ec_dev, or is there another location you'd recommend?
IIUC, this patch is specifically for ISHTP. I'd expect cros_ec_ishtp.c
to register the event notifier and check if the incoming event is
EC_HOST_EVENT_PANIC.
prev parent reply other threads:[~2026-10-20 0:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 17:22 [PATCH] platform/chrome: cros_ec: trigger kernel_restart on EC_HOST_EVENT_PANIC Scott Collyer
2026-10-14 7:17 ` Tzung-Bi Shih
2026-10-14 21:30 ` Scott Collyer
[not found] ` <CALUcz=3WE+SUx2j8LKFQQK-fMVXdk69rZJ9nKgBMQ_UwnWRPSA@mail.gmail.com>
2026-10-19 2:50 ` Tzung-Bi Shih
2026-10-19 22:12 ` Scott Collyer
2026-10-20 0:44 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ata5f5ZmYkrcdt_I@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=scollyer@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.