From: Andrea Righi <arighi@nvidia.com>
To: Tejun Heo <tj@kernel.org>
Cc: sched-ext@lists.linux.dev, David Vernet <void@manifault.com>,
Changwoo Min <changwoo@igalia.com>,
Emil Tsalapatis <emil@etsalapatis.com>,
David Dai <david.dai@linux.dev>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHSET sched_ext/for-7.5] sched_ext: scx_qmap: Drop the compat code and fix a lowpri starvation
Date: Tue, 20 Oct 2026 00:00:19 +0200 [thread overview]
Message-ID: <ataS89RDe7vZ6nGg@gpd4> (raw)
In-Reply-To: <20261019213221.2919481-1-tj@kernel.org>
On Mon, Oct 19, 2026 at 11:32:19AM -1000, Tejun Heo wrote:
> Hello,
>
> scx_qmap is often used to exercise sched_ext features as they land and
> already requires the kernel it ships with, so its compat code only keeps
> untested fallbacks around. The first patch drops it.
>
> The second fixes scx_qmap's lowpri path. Nice 19 tasks coming back from
> LOWPRI_DSQ go to SHARED_DSQ, which is consumed ahead of the FIFOs, so enough
> nice 19 CPU hogs starve every other task until the watchdog ejects the
> scheduler. They now go to their FIFO instead.
>
> Tested with root and sub-scheduler instances under nice 0 and nice 19 CPU
> hogs. Without the fix, the root is ejected within seconds. With it, the runs
> complete and the FIFOs keep being dispatched.
>
> Based on sched_ext/for-7.4-fixes (ff343a94e44d).
>
> This patchset contains the following 2 patches.
>
> 0001 sched_ext: scx_qmap: Drop the compat code
> 0002 sched_ext: scx_qmap: Queue re-enqueued lowpri tasks on their FIFO
Both look good to me.
Reviewed-by: Andrea Righi <arighi@nvidia.com>
Thanks,
-Andrea
next prev parent reply other threads:[~2026-10-19 22:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 21:32 [PATCHSET sched_ext/for-7.5] sched_ext: scx_qmap: Drop the compat code and fix a lowpri starvation Tejun Heo
2026-10-19 21:32 ` [PATCH 1/2] sched_ext: scx_qmap: Drop the compat code Tejun Heo
2026-10-19 21:32 ` [PATCH 2/2] sched_ext: scx_qmap: Queue re-enqueued lowpri tasks on their FIFO Tejun Heo
2026-10-19 22:00 ` Andrea Righi [this message]
2026-10-19 22:03 ` [PATCHSET sched_ext/for-7.5] sched_ext: scx_qmap: Drop the compat code and fix a lowpri starvation Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ataS89RDe7vZ6nGg@gpd4 \
--to=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=david.dai@linux.dev \
--cc=emil@etsalapatis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.