From: Jarkko Sakkinen <jarkko@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: David Howells <dhowells@redhat.com>,
keyrings@vger.kernel.org, stable@vger.kernel.org,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:SECURITY SUBSYSTEM"
<linux-security-module@vger.kernel.org>
Subject: Re: [PATCH v2 2/6] KEYS: Reject @desclen values >= KEY_MAX_DESC_SIZE in key_alloc()
Date: Tue, 20 Oct 2026 03:19:55 +0300 [thread overview]
Message-ID: <atazq_p9kYi38xWa@kernel.org> (raw)
In-Reply-To: <ataBwhb8d2M1q2ux@kernel.org>
On Mon, Oct 19, 2026 at 11:46:58PM +0300, Jarkko Sakkinen wrote:
> On Mon, Oct 19, 2026 at 12:17:59PM -0700, Eric Biggers wrote:
> > On Mon, Oct 19, 2026 at 09:17:22PM +0300, Jarkko Sakkinen wrote:
> > > @desclen in key_alloc() is saved to the 16-bit wide desc_len field in
> > > struct keyring_index_key.
> > >
> > > Reject @desclen values at or above KEY_MAX_DESC_SIZE with -EINVAL in
> > > order to account for the NUL terminator and prevent integer overflow.
> >
> > This should say something like: "in order to match the userspace limit
> > and avoid u16 truncation".
> >
> > There are also similar truncations of desc_len to u16 in
> > key_create_or_update() and keyring_search().
>
> Ack.
Please correct if I'm wrong but I think these don't need anything
special given that both are capped by strndup().
Br, Jarkko
next prev parent reply other threads:[~2026-10-20 0:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 18:17 [PATCH v2 0/6] KEYS: rhashtable bug fixes Jarkko Sakkinen
2026-10-19 18:17 ` [PATCH v2 1/6] KEYS: Expand key->{datalen,quotalen} to unsigned int Jarkko Sakkinen
2026-10-19 18:24 ` sashiko-bot
2026-10-19 19:12 ` Eric Biggers
2026-10-19 20:32 ` Jarkko Sakkinen
2026-10-19 18:17 ` [PATCH v2 2/6] KEYS: Reject @desclen values >= KEY_MAX_DESC_SIZE in key_alloc() Jarkko Sakkinen
2026-10-19 18:30 ` sashiko-bot
2026-10-19 19:17 ` Eric Biggers
2026-10-19 20:46 ` Jarkko Sakkinen
2026-10-20 0:19 ` Jarkko Sakkinen [this message]
2026-10-19 18:17 ` [PATCH v2 3/6] KEYS: Prevent overflow of user->{qnkeys,qnbytes} " Jarkko Sakkinen
2026-10-19 18:25 ` sashiko-bot
2026-10-19 19:23 ` Eric Biggers
2026-10-19 20:53 ` Jarkko Sakkinen
2026-10-20 0:26 ` Jarkko Sakkinen
2026-10-19 18:17 ` [PATCH v2 4/6] KEYS: Prevent overflow of quota " Jarkko Sakkinen
2026-10-19 18:23 ` sashiko-bot
2026-10-19 19:25 ` Eric Biggers
2026-10-19 20:55 ` Jarkko Sakkinen
2026-10-19 20:56 ` Jarkko Sakkinen
2026-10-19 18:17 ` [PATCH v2 5/6] KEYS: Reject @datalen values over INT_MAX Jarkko Sakkinen
2026-10-19 18:24 ` sashiko-bot
2026-10-19 19:31 ` Eric Biggers
2026-10-19 21:07 ` Jarkko Sakkinen
2026-10-19 23:55 ` Jarkko Sakkinen
2026-10-20 0:03 ` Jarkko Sakkinen
2026-10-19 18:17 ` [PATCH v2 6/6] KEYS: Verify the key identity in __keyctl_unlink Jarkko Sakkinen
2026-10-19 18:21 ` sashiko-bot
2026-10-19 19:35 ` Eric Biggers
2026-10-19 21:06 ` Jarkko Sakkinen
2026-10-19 21:16 ` Jarkko Sakkinen
2026-10-19 18:29 ` [PATCH v2 0/6] KEYS: rhashtable bug fixes Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atazq_p9kYi38xWa@kernel.org \
--to=jarkko@kernel.org \
--cc=dhowells@redhat.com \
--cc=ebiggers@kernel.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.