Re: [PATCH] staging: rtl8723bs: replace yield() with usleep_range() and cond_resched()

[Dan Carpenter <error27@gmail.com>]

On Tue, Oct 20, 2026 at 12:59:47AM -0400, sarbansah151@gmail.com wrote:
> yield() merely reschedules the calling task and does not sleep, so
> using it in hardware poll loops spins the CPU while waiting on the
> device. checkpatch.pl flags this class of bug ("Using yield() is
> generally wrong", see yield() kernel-doc in sched/core.c).
> 
> In the firmware download poll loops the git history shows a
> commented-out mdelay(10) at these sites, which indicates a ~10ms
> delay was intended; restore it with usleep_range(10000, 20000), the
> correct idiom for sub-20ms sleeps. In the firmware checksum/ready
> poll loops use usleep_range(1000, 2000) to rate-limit register
> polling.
> 
> In the TX path there is an explicit comment that sleeping even 1ms
> causes throughput loss, so use cond_resched() there instead: it
> yields the CPU only when the scheduler actually wants to run
> something else.
> 
> Signed-off-by: Sarban Sah <sarbansah151@gmail.com>
> ---

We generally wouldn't merge this without testing even without the
staging anti-AI rules, but mainly this driver has been deleted in
linux-next.

regards,
dan carpenter