From: Patrick Steinhardt <ps@pks.im>
To: Harald Nordgren <haraldnordgren@gmail.com>
Cc: Matt Hunter <m@lfurio.us>, git@vger.kernel.org
Subject: Re: [PATCH] init: show absolute path of (re)initialized repository
Date: Tue, 20 Oct 2026 16:37:14 +0200 [thread overview]
Message-ID: <atd8mopIi44pMBAC@pks.im> (raw)
In-Reply-To: <CAHwyqnVf++okhdjUuVewkK5ZhqbKSoE3TixhpNORdWrMGUA=mw@mail.gmail.com>
On Tue, Oct 20, 2026 at 02:37:05PM +0200, Harald Nordgren wrote:
> > I'm a bit on the fence about whether we want to have a regression test
> > or not. It feels like a very specific thing in the user-facing output,
> > so it's a bit dubious whether it's really worth it. But on the other
> > hand, folks like you seem to care enough to make the test worthwhile, so
> > maybe we should have one?
>
> It seems self-evident that we need a regression test here. Because
> it's specifically the thing that would have prevented it, and the only
> thing that will prevent a new regression later on :)
I wouldn't necessarily say self-evident as the result isn't wrong. It's
still correct, even though it has changed compared to the previous
status quo.
Patrick
next prev parent reply other threads:[~2026-10-20 14:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 5:38 [PATCH] init: show absolute path of (re)initialized repository Matt Hunter
2026-10-20 6:55 ` Patrick Steinhardt
2026-10-20 9:13 ` Matt Hunter
2026-10-20 12:14 ` Patrick Steinhardt
2026-10-20 12:37 ` Harald Nordgren
2026-10-20 14:37 ` Patrick Steinhardt [this message]
2026-10-20 15:32 ` Harald Nordgren
2026-10-20 16:29 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atd8mopIi44pMBAC@pks.im \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=haraldnordgren@gmail.com \
--cc=m@lfurio.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.