From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Paul Louvel <paul.louvel@bootlin.com>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v5 2/5] watchdog: w83627hf_wdt: Convert to platform driver model
Date: Tue, 20 Oct 2026 13:29:38 +0000 [thread overview]
Message-ID: <atdswsr3flA_GFtj@google.com> (raw)
In-Reply-To: <20261020-w83627hf_wdt-improvements-v5-2-90b226684fc7@bootlin.com>
On Tue, Oct 20, 2026 at 10:11:55AM +0200, Paul Louvel wrote:
> This driver is not yet converted to the driver model.
> Convert it and add missing error messages in probe.
>
> Signed-off-by: Paul Louvel <paul.louvel@bootlin.com>
I'm not sure if the W=1 warning reported by 0day bot [1] (also flagged by
Sashiko [2]) is still relevant as the truncation can never actually happen
for now. Even if the truncation really happened, it should be harmless.
Given that,
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
[1] https://lore.kernel.org/oe-kbuild-all/202610080027.3OsJDwfo-lkp@intel.com
[2] https://lore.kernel.org/all/sashiko-outbox-178668@kernel.org
next prev parent reply other threads:[~2026-10-20 13:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 8:11 [PATCH v5 0/5] watchdog: w83627hf_wdt: Convert driver to the driver model and add minute support Paul Louvel
2026-10-20 8:11 ` [PATCH v5 1/5] watchdog: w83627hf_wdt: Replace magic numbers with descriptive macros Paul Louvel
2026-10-20 8:11 ` [PATCH v5 2/5] watchdog: w83627hf_wdt: Convert to platform driver model Paul Louvel
2026-10-20 8:59 ` sashiko-bot
2026-10-20 13:29 ` Tzung-Bi Shih [this message]
2026-10-20 8:11 ` [PATCH v5 3/5] watchdog: w83627hf_wdt: Move register offsets into driver data Paul Louvel
2026-10-20 13:44 ` Tzung-Bi Shih
2026-10-20 8:11 ` [PATCH v5 4/5] watchdog: w83627hf_wdt: Store Super I/O configurations in platform data Paul Louvel
2026-10-20 8:11 ` [PATCH v5 5/5] watchdog: w83627hf_wdt: Add minute mode counting Paul Louvel
2026-10-20 14:08 ` Tzung-Bi Shih
2026-10-20 15:42 ` Guenter Roeck
2026-10-20 16:28 ` Paul Louvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atdswsr3flA_GFtj@google.com \
--to=tzungbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=paul.louvel@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.