From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: buildroot@buildroot.org, Christian Stewart <christian@aperture.us>
Subject: Re: [Buildroot] [PATCH v7 1/3] package/pkg-golang.mk: use golang toolchain default GOPROXY
Date: Tue, 20 Oct 2026 23:19:11 +0200 [thread overview]
Message-ID: <atfahdwTiFb2QEI-@windsurf> (raw)
In-Reply-To: <20261002192648.3757582-1-james.hilliard1@gmail.com>
On Fri, Oct 02, 2026 at 01:26:46PM -0600, James Hilliard wrote:
> This change sets the default GOPROXY value to match Go's built-in
> default of "https://proxy.golang.org,direct" which provides several
> benefits:
>
> - Avoid package breakages due to missing module sources
> - Better alignment with upstream Go toolchain defaults
> - Faster downloads via the proxy compared to direct Git clones
> - Maintains reproducible builds through Go's module checksum validation
>
> The default value from the toolchain can be read with "go env GOPROXY"
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Thanks, series applied. To be honest, I hesitated a bit on PATCH 2/3
because I'm not quite sure to understand under which (realistic)
circumstances one would want to tweak BR2_GOPROXY. But fair enough,
since both Christian and you agreed on that, I took the patch. It
would have been nice to have some explanation of the "why" in the
commit message: as it is the commit message only explains the "how"
which is already clear by looking at the code.
Thanks!
Thomas Petazzoni
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2026-10-20 21:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 19:26 [Buildroot] [PATCH v7 1/3] package/pkg-golang.mk: use golang toolchain default GOPROXY James Hilliard
2026-10-02 19:26 ` [Buildroot] [PATCH v7 2/3] package/pkg-golang.mk: make GOPROXY configurable James Hilliard
2026-10-02 19:26 ` [Buildroot] [PATCH v7 3/3] package/tailscale: bump to version 1.102.5 James Hilliard
2026-10-20 21:19 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atfahdwTiFb2QEI-@windsurf \
--to=buildroot@buildroot.org \
--cc=christian@aperture.us \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.