From: Waldemar Brodkorb <wbx@openadk.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 2/2] package/chawan: new package
Date: Wed, 21 Oct 2026 00:30:02 +0200 [thread overview]
Message-ID: <atfrauVhAXrHeul4@waldemar-brodkorb.de> (raw)
In-Reply-To: <atfRLgIqqBBd6TuN@windsurf>
Hi Thomas,
Thomas Petazzoni wrote,
> Hello,
>
> On Sat, Sep 19, 2026 at 09:53:57AM +0200, Waldemar Brodkorb wrote:
> > Chawan is a text-mode web browser and pager for Unix-like systems, with
> > a focus on implementing modern web standards while remaining
> > self-contained, easy to understand and extensible.
> >
> > It includes functionality such as CSS, inline images inside the
> > terminal, and JavaScript through a small, independent browser engine.
> >
> > Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
>
> I've applied to master, with some changes.
>
>
> > +CHAWAN_VERSION = 0.4.4
> > +CHAWAN_SITE = https://git.sr.ht/~bptato/chawan/archive
> > +CHAWAN_SOURCE = v$(CHAWAN_VERSION).tar.gz
> > +CHAWAN_LICENSE = Unlicense
> > +CHAWAN_LICENSE_FILES = UNLICENSE
> > +
> > +CHAWAN_DEPENDENCIES = brotli host-nim libssh2 openssl
> > +
> > +ifeq ($(BR2_aarch64),y)
> > +CHAWAN_TARGET_ARCH = arm64
> > +else ifeq ($(BR2_x86_64),y)
> > +CHAWAN_TARGET_ARCH = amd64
> > +else
> > +CHAWAN_TARGET_ARCH = $(BR2_ARCH)
> > +endif
> > +
> > +TARGET_CONFIGURE_OPTS += \
>
> This was very very wrong, as it means you're changing this variable
> for everyone in Buildroot. Variables are global.
>
> "make check-package" actually warned about this:
>
> WARNING: package/chawan/chawan.mk:23: possible typo, variable not properly prefixed: TARGET_CONFIGURE_OPTS -> *CHAWAN_XXXX* (https://nightly.buildroot.org/#_tips_and_tricks)
>
> > + FLAGS="--os=linux \
> > + --cpu:$(CHAWAN_TARGET_ARCH) \
> > + --gcc.exe:$(TARGET_CROSS)gcc \
> > + --gcc.linkerexe:$(TARGET_CROSS)gcc" \
> > + PREFIX="/usr"
>
> So I've changed this to:
>
> +CHAWAN_MAKE_OPTS = \
> + $(TARGET_CONFIGURE_OPTS) \
> + FLAGS="--os=linux \
> + --cpu:$(CHAWAN_TARGET_ARCH) \
> + --gcc.exe:$(TARGET_CROSS)gcc \
> + --gcc.linkerexe:$(TARGET_CROSS)gcc" \
> + PREFIX="/usr"
>
> and then used CHAWAN_MAKE_OPTS.
>
> > +define CHAWAN_BUILD_CMDS
> > + $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) all
> > +endef
> > +
> > +define CHAWAN_INSTALL_TARGET_CMDS
> > + $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \
> > + DESTDIR=$(TARGET_DIR) install
>
> Continuation line should have had one more indentation level (minor
> nit).
>
> Applied with those changes. Thanks!
Thanks for fixing my bugs and applying!
best regards
Waldemar
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2026-10-20 22:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-19 7:53 [Buildroot] [PATCH v2 2/2] package/chawan: new package Waldemar Brodkorb
2026-10-20 20:39 ` Thomas Petazzoni via buildroot
2026-10-20 22:30 ` Waldemar Brodkorb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atfrauVhAXrHeul4@waldemar-brodkorb.de \
--to=wbx@openadk.org \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.