From: "José Guilherme de Castro Rodrigues" <jose.guilherme.cr.bh@gmail.com>
To: git@turtledev.nz
Cc: "Corentin Chary" <corentin.chary@gmail.com>,
"Luke D. Jones" <luke@ljones.dev>,
"Denis Benato" <denis.benato@linux.dev>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] platform/x86: asus-wmi: fix camera key LED on Zenbook S14
Date: Tue, 20 Oct 2026 22:09:05 -0300 [thread overview]
Message-ID: <atgQsQrbCvCGKKld@djouze-zen> (raw)
In-Reply-To: <20261019-asus-wmi-camera-led-v4-1-7744c125bcc9@turtledev.nz>
Hi, Zane.
Thanks for the updated patch!
I've applied the patch locally and it works just fine on my Zenbook S 14
On Mon, Oct 19, 2026 at 07:35:18PM +1300, Zane Hunt via B4 Relay wrote:
> From: Zane Hunt <git@turtledev.nz>
>
> When CAMERA_LED is missing but CAMERA_LED_NEG is there, register
> asus::camera as a read-only LED backed by CAMERA_LED_NEG, and read it
> after every camera key event, sending a brightness_hw_changed event.
> Registering the LED reads it as well, which fixes the LED being dark after
> a cold boot with the camera disabled.
With this patch applied, a write to /sys/class/leds/asus::camera/brightness
returns no error, even though the led is "read-only". I'm wondering
whether we should care about this?
> +
> +/* The firmware owns this LED; a write just resyncs it with the camera state. */
> +static int camera_neg_led_set(struct led_classdev *led_cdev,
> + enum led_brightness brightness)
> +{
> + struct asus_wmi *asus = container_of(led_cdev, struct asus_wmi, camera_led);
> +
> + if (!(led_cdev->flags & LED_UNREGISTERING))
> + camera_neg_led_sync(asus);
> + return 0;
> +}
> +
Is this function necessary? We can't perform what the caller has asked
us to perform, since there is no way to set the LED. If this "resync"
functionality affects the behavior, please ignore this comment.
Apart from the comments, I'm fine with the patch as it is. I just
wondered these two things out loud.
next prev parent reply other threads:[~2026-10-21 1:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 6:35 [PATCH v4] platform/x86: asus-wmi: fix camera key LED on Zenbook S14 Zane Hunt via B4 Relay
2026-10-19 6:35 ` Zane Hunt
2026-10-19 8:38 ` Ilpo Järvinen
2026-10-21 1:09 ` José Guilherme de Castro Rodrigues [this message]
2026-10-21 12:34 ` Rong Zhang
2026-11-16 12:48 ` Rong Zhang
2026-11-17 1:09 ` Denis Benato
2026-11-17 13:52 ` Rong Zhang
-- strict thread matches above, loose matches on Subject: below --
2026-11-15 11:55 skyedryv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atgQsQrbCvCGKKld@djouze-zen \
--to=jose.guilherme.cr.bh@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=denis.benato@linux.dev \
--cc=git@turtledev.nz \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.