All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Miro Kropacek <miro.kropacek@gmail.com>
Cc: geert@linux-m68k.org, schmitzmic@gmail.com,
	linux-m68k@vger.kernel.org,  linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] m68k: Fix atari mouse movement
Date: Tue, 20 Oct 2026 18:41:54 -0700	[thread overview]
Message-ID: <atgXH5V-q8fYe0u4@google.com> (raw)
In-Reply-To: <20261021000338.2160223-1-miro.kropacek@gmail.com>

Hi Miro,

On Wed, Oct 21, 2026 at 10:03:37AM +1000, Miro Kropacek wrote:
> Kernels are built with -funsigned-char since version 6.2, resulting in
> the signed 8-bit position deltas reported by the IKBD being
> misinterpreted as unsigned.
> 
> Carry the sign in the type of the mouse interrupt hook. The scancode
> buffer is shared with the keyboard and joystick paths, where unsigned is
> correct, so it stays unsigned and is cast at the single call site that
> passes it to the mouse driver.

The hook receives the byte stream, so I would rather have it accept u8*
and then do signed cast for displacement values (and only them).

Thanks.

-- 
Dmitry

  reply	other threads:[~2026-10-21  1:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-19 22:28 [PATCH v3 0/5] m68k SuperVidel patches Michael Schmitz
2026-08-19 22:28 ` [PATCH v3 1/5] m68k: Fix atari mouse movement Michael Schmitz
2026-10-21  0:03   ` [PATCH v4] " Miro Kropacek
2026-10-21  1:41     ` Dmitry Torokhov [this message]
2026-10-21  2:23     ` [PATCH v5] " Miro Kropacek
2026-10-21  2:50       ` Michael Schmitz
2026-10-21  7:32         ` Geert Uytterhoeven
2026-08-19 22:28 ` [PATCH v3 2/5] fbdev: Give atafb proper parent Michael Schmitz
2026-08-20 21:51   ` Helge Deller
2026-08-21  6:44     ` Michael Schmitz
2026-09-07 11:39     ` Miro Kropáček
2026-08-19 22:28 ` [PATCH v3 3/5] fbdev: Add support for further video bit depths on atafb:external Michael Schmitz
2026-08-19 22:28 ` [PATCH v3 4/5] fbdev: Add support for SuperVidel's SuperBlitter Michael Schmitz
2026-08-19 22:28 ` [PATCH v3 5/5] m68k: Add support for Svethlana Michael Schmitz
2026-09-27 12:40   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atgXH5V-q8fYe0u4@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=miro.kropacek@gmail.com \
    --cc=schmitzmic@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.