From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: Andy Koppe <andy.koppe@gmail.com>,
git@vger.kernel.org, Karthik Nayak <karthik.188@gmail.com>
Subject: Re: [PATCH v3] refs/files: keep root refs out of loose ref cache
Date: Wed, 21 Oct 2026 07:36:40 +0200 [thread overview]
Message-ID: <athPaILS_RqqMUap@pks.im> (raw)
In-Reply-To: <xmqqik2vss86.fsf@gitster.g>
On Tue, Oct 20, 2026 at 07:27:37PM -0700, Junio C Hamano wrote:
> Patrick Steinhardt <ps@pks.im> writes:
>
> >> Changes from v2:
> >> - Drop fixes to documentation of REFS_FOR_EACH_INCLUDE_ROOT_REFS and
> >> --include-root-refs added in v2. I'll create a separate patch with
> >> those as well as other fixes for outdated uses of "pseudoref".
> >>
> >> The range diff shows the changes from v1, because they're of more
> >> interest than dropping the documentation changes I'd added in v2.
> >
> > Thanks for this. By the way, I would recommend to have a look at b4,
> > which handles all of the bookkeeping for you.
>
> Perhaps it cuts both ways. Can you tell b4 to do the flexible thing
> the author did in this case?
No, it's more restricted in this case. But mistakes like this wouldn't
happen anymore if one were to use it right from the start, so it would
not even have been necessary to have the flexibility :)
Patrick
prev parent reply other threads:[~2026-10-21 5:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 15:32 [PATCH] refs/files: keep root refs out of loose ref cache Andy Koppe
2026-10-15 5:58 ` Patrick Steinhardt
2026-10-15 17:31 ` Junio C Hamano
2026-10-15 19:43 ` Andy Koppe
2026-10-16 7:00 ` Patrick Steinhardt
2026-10-16 15:05 ` Junio C Hamano
2026-10-17 20:04 ` [PATCH v2] " Andy Koppe
2026-10-19 5:57 ` Patrick Steinhardt
2026-10-19 21:30 ` Andy Koppe
2026-10-19 20:34 ` [PATCH v3] " Andy Koppe
2026-10-20 6:42 ` Patrick Steinhardt
2026-10-21 2:27 ` Junio C Hamano
2026-10-21 5:36 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=athPaILS_RqqMUap@pks.im \
--to=ps@pks.im \
--cc=andy.koppe@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.