From: Patrick Steinhardt <ps@pks.im>
To: Cynthia Uche <herroyalpriestess@gmail.com>
Cc: git@vger.kernel.org, christian.couder@gmail.com,
usmanakinyemi202@gmail.com, siddharthasthana31@gmail.com,
kaartic.sivaraam@gmail.com
Subject: Re: [Outreachy PATCH] t2104: avoid suppressing git's exit code
Date: Wed, 21 Oct 2026 10:00:03 +0200 [thread overview]
Message-ID: <athxA6S50czDEUYj@pks.im> (raw)
In-Reply-To: <20261021033723.5265-1-herroyalpriestess@gmail.com>
On Wed, Oct 21, 2026 at 04:37:23AM +0100, Cynthia Uche wrote:
> The exit code of the upstream command in a pipeline is lost, so a
> crash in 'git ls-files' would go unnoticed. Write the output to a
> file and compare that instead.
Makes sense, and the patch looks obviously good to me, too. Thanks!
Patrick
next prev parent reply other threads:[~2026-10-21 8:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 3:37 [Outreachy PATCH] t2104: avoid suppressing git's exit code Cynthia Uche
2026-10-21 8:00 ` Patrick Steinhardt [this message]
2026-10-22 1:22 ` Priestess
2026-10-23 17:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=athxA6S50czDEUYj@pks.im \
--to=ps@pks.im \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=herroyalpriestess@gmail.com \
--cc=kaartic.sivaraam@gmail.com \
--cc=siddharthasthana31@gmail.com \
--cc=usmanakinyemi202@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.