From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADBDF606A319 for ; Wed, 21 Oct 2026 13:37:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HQqcVE+R Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xJWVP-0002Ga-5W; Wed, 21 Oct 2026 09:37:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xJWVF-0002G7-BR for qemu-devel@nongnu.org; Wed, 21 Oct 2026 09:37:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xJWVD-0006HI-OM for qemu-devel@nongnu.org; Wed, 21 Oct 2026 09:37:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1792589830; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XMSZ3ikLUyyuSrG0BVP/AZ6WSVDnph0e9UUEVWobHaw=; b=HQqcVE+RXAVh9dO5Eqjthc0jtAFAnzdx/rnRr7A1BODkfHL7buMcymnJqATpEkzNPMe8q8 urijGB/u/eEOndp+cLqOUtCxA5Z1J4DvVzgQWg9Sg60oP7QkeerNZdAHOvc0Pr5jgPYv9g gmVIm1Mf/qZdt6LeOgUC531g6RraUN0= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-227-E96XLrwvNCi9cskYB0071w-1; Wed, 21 Oct 2026 09:37:03 -0400 X-MC-Unique: E96XLrwvNCi9cskYB0071w-1 X-Mimecast-MFC-AGG-ID: E96XLrwvNCi9cskYB0071w_1792589822 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 265011955DD9; Wed, 21 Oct 2026 13:37:02 +0000 (UTC) Received: from redhat.com (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 12D821956087; Wed, 21 Oct 2026 13:36:59 +0000 (UTC) Date: Wed, 21 Oct 2026 08:36:55 -0500 From: Eric Blake To: Thomas Huth Cc: Kevin Wolf , qemu-block@nongnu.org, Hanna Reitz , Paolo Bonzini , qemu-devel@nongnu.org Subject: Re: [PATCH v2] block: Print simple help text when calling "-blockdev help" Message-ID: References: <20260914090036.125300-1-thuth@redhat.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20260616 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Wed, Oct 21, 2026 at 08:34:20AM -0500, Eric Blake wrote: > On Mon, Sep 14, 2026 at 11:00:36AM +0200, Thomas Huth wrote: > > Other command line options like "-chardev", "-netdev" or "-device" > > already present the user with a list of available parameters, but > > when running "-blockdev help", there is currently only an error > > message. There is already the possibility to run "-drive format=help", > > but it does not seem to be documented, so this is not very useful > > for the average user. Thus let's improve this situation by providing > > a proper list of available drivers when running QEMU with > > "-blockdev help". > > > > Signed-off-by: Thomas Huth > > --- > > v2: Don't re-use the code from "-drive format=help" and print the > > help in a better readable way instead > > One format per line rather than space-separated does seem a bit more > machine-parseable, although the output no longer fits in my preferred > terminal size without scrolling. I guess "more readable" is subjective > ;) That said, we aren't very consistent; "-chardev help" indents each line by two, while "-netdev help" and this patch for "-blockdev help" does not indent. May be worth a followup patch. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org