From: Niklas Cassel <cassel@kernel.org>
To: Manikanta Maddireddy <mmaddireddy@nvidia.com>
Cc: mani@kernel.org, kwilczynski@kernel.org,
linux-pci@vger.kernel.org, kishon@kernel.org,
Frank.Li@kernel.org, bhelgaas@google.com, den@valinux.co.jp,
thierry.reding@kernel.org, jonathanh@nvidia.com,
vidyas@nvidia.com, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] PCI: endpoint: Skip upper halves of 64-bit BARs during search
Date: Wed, 21 Oct 2026 16:25:34 +0200 [thread overview]
Message-ID: <atjLXvkc-XZNF0oi@ryzen> (raw)
In-Reply-To: <atiX5UoJ0qgV0wGN@ryzen>
On Wed, Oct 21, 2026 at 12:46:03PM +0200, Niklas Cassel wrote:
> On Wed, Oct 21, 2026 at 01:36:44PM +0530, Manikanta Maddireddy wrote:
> > pci_epc_get_next_free_bar() skips the upper half of a 64-bit BAR only
> > when it is the starting BAR. If the search subsequently passes a
> > reserved or disabled 64-bit BAR, it can return its upper half as an
> > independent BAR because that slot has a default programmable descriptor.
> >
> > For example, Tegra exposes a programmable 64-bit BAR0 and reserved
> > 64-bit BAR2 and BAR4. A search starting at BAR1 skips BAR1 and BAR2,
> > then incorrectly returns BAR3. The next search can similarly return
> > BAR5, causing the EPF test driver to allocate and program BARs that
> > belong to the reserved hardware windows.
>
> 12a22fb38cbb ("PCI: tegra194: Expose BAR2 (MSI-X) and BAR4 (DMA) as
> 64-bit BAR_RESERVED").
>
>
> I'm fine with this patch, but I think you need to rephrase the kdoc
> to reflect this new reality, because currently the kdoc is confusing/
> not in line with the 'new' meaning of BAR_RESERVED, which can contain
> MSI-X table etc.
To clarify, I can see that you updated the definition in:
27ce1d8ecb9b ("PCI: endpoint: Allow only_64bit on BAR_RESERVED")
But, IMO it is still not super clear.
Perhaps we should have mentioned explicitly that only_64bit is
also allowed on a BAR_RESERVED, if that reserved BAR is 64-bit.
(Since that use case is different from what the kdoc currently
says.)
I also think that this patch needs a Fixes tag with either:
27ce1d8ecb9b ("PCI: endpoint: Allow only_64bit on BAR_RESERVED")
or
12a22fb38cbb ("PCI: tegra194: Expose BAR2 (MSI-X) and BAR4 (DMA) as
64-bit BAR_RESERVED")
Kind regards,
Niklas
prev parent reply other threads:[~2026-10-21 14:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 8:06 [PATCH v1] PCI: endpoint: Skip upper halves of 64-bit BARs during search Manikanta Maddireddy
2026-10-21 8:13 ` sashiko-bot
2026-10-21 10:45 ` Niklas Cassel
2026-10-21 14:25 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atjLXvkc-XZNF0oi@ryzen \
--to=cassel@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=bhelgaas@google.com \
--cc=den@valinux.co.jp \
--cc=jonathanh@nvidia.com \
--cc=kishon@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=thierry.reding@kernel.org \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.