From: Frank Li <Frank.li@oss.nxp.com>
To: sashiko-reviews@lists.linux.dev
Cc: Petko Manolov <petko.manolov@konsulko.com>,
devicetree@vger.kernel.org, imx@lists.linux.dev, robh@kernel.org,
conor+dt@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: fsl: add Draeger M48 dual-cpu board
Date: Wed, 21 Oct 2026 09:57:41 -0500 [thread overview]
Message-ID: <atjS5TA33rHlIjPO@SMW015318> (raw)
In-Reply-To: <sashiko-outbox-180038@kernel.org>
On Wed, Oct 21, 2026 at 09:32:12AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] dt-bindings: arm: fsl: undocumented draeger vendor prefix
> --
>
> commit 795e5eabed6a73f1faa10f56606455efcbd039b8
> Author: Petko Manolov <petko.manolov@konsulko.com>
>
> dt-bindings: arm: fsl: add Draeger M48 dual-cpu board
>
> This commit adds devicetree binding compatible strings for the imx6q and
> imx6dl variants of the Draeger M48 board to
> Documentation/devicetree/bindings/arm/fsl.yaml.
>
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 656f2596e1d53..8f3a04228780a 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -260,6 +260,7 @@ properties:
> > - boundary,imx6q-nitrogen6x
> > - compulab,cm-fx6 # CompuLab CM-FX6
> > - dmo,imx6q-edmqmx6 # Data Modul eDM-QMX6 Board
> > + - draeger,imx6q-m48 # Draeger imx6q variant of M48
> > - ds,imx6q-sbc # Da Sheng COM-9XX Modules
> > - embest,imx6q-marsboard # Embest MarS Board i.MX6Dual
> > - emtrion,emcon-mx6 # emCON-MX6D or emCON-MX6Q SoM
> > @@ -458,6 +459,7 @@ properties:
> > - boundary,imx6dl-nit6xlite # Boundary Devices Nitrogen6 Lite
> > - boundary,imx6dl-nitrogen6x # Boundary Devices Nitrogen6x
> > - bticino,imx6dl-mamoj # BTicino i.MX6DL Mamoj
> > + - draeger,imx6dl-m48 # Draeger imx6dl variant of M48
> > - eckelmann,imx6dl-ci4x10
> > - emtrion,emcon-mx6 # emCON-MX6S or emCON-MX6DL SoM
> > - emtrion,emcon-mx6-avari # emCON-MX6S or emCON-MX6DL SoM on Avari Base
>
> [Severity: Low]
> Should the draeger vendor prefix also be documented under patternProperties
> in Documentation/devicetree/bindings/vendor-prefixes.yaml?
This need be fixed
Frank
>
> Currently, Documentation/devicetree/bindings/vendor-prefixes.yaml has no
> entry for draeger between dptel and dragino:
>
> "^dptel,.*":
> description: Guangdong Dapu Telecom Co., Ltd.
> "^dragino,.*":
> description: Dragino Technology Co., Limited
>
> Without an entry in vendor-prefixes.yaml, process() in scripts/checkpatch.pl
> reports an undocumented vendor prefix warning when device tree files (such
> as arch/arm/boot/dts/nxp/imx/imx6q-draeger-m48.dts and
> arch/arm/boot/dts/nxp/imx/imx6dl-draeger-m48.dts) or driver match tables
> reference draeger,imx6q-m48 or draeger,imx6dl-m48, and any draeger,*
> vendor-specific properties will fail schema validation.
>
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/20261021092140.4142493-1-petko.manolov@konsulko.com?part=1
next prev parent reply other threads:[~2026-10-21 14:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 9:21 [PATCH v3 0/2] arm: dts: nxp: imx: add Draeger M48 CPU board Petko Manolov
2026-10-21 9:21 ` [PATCH v3 1/2] dt-bindings: arm: fsl: add Draeger M48 dual-cpu board Petko Manolov
2026-10-21 9:32 ` sashiko-bot
2026-10-21 14:57 ` Frank Li [this message]
2026-10-21 9:21 ` [PATCH v3 2/2] arm: dts: nxp: imx: Add devicetree files for M48 Petko Manolov
2026-10-21 9:43 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atjS5TA33rHlIjPO@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=petko.manolov@konsulko.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.