From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] package/xmrig: Add support for OpenSSL 4.0.0
Date: Wed, 21 Oct 2026 22:36:23 +0200 [thread overview]
Message-ID: <atkh3QrH-OV8tcnA@windsurf> (raw)
In-Reply-To: <20261021193840.2613533-1-bernd@kuhls.net>
On Wed, Oct 21, 2026 at 09:38:40PM +0200, Bernd Kuhls wrote:
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
> v2: updated patch after upstream discussion (Thomas)
I've applied, but see below.
> diff --git a/package/xmrig/0001-Fix-build-with-OpenSSL-4.0.patch b/package/xmrig/0001-Fix-build-with-OpenSSL-4.0.patch
> new file mode 100644
> index 0000000000..f9b49a0070
> --- /dev/null
> +++ b/package/xmrig/0001-Fix-build-with-OpenSSL-4.0.patch
> @@ -0,0 +1,36 @@
> +From a768091a0001cf4e6fb24885daec68d8c48e1cde Mon Sep 17 00:00:00 2001
> +From: Reuben Roessler <reuben.roessler@canonical.com>
Technically, Reuben is not the author. He suggested the code, but he
didn't formally write the patch. You're now claiming he is the author,
but he isn't, which could be pretty bad if you somehow misunderstood
his suggestion.
In this sort of situation, I would recommend to make your self the
author, and add a:
Suggested-by: Reuben Roessler <reuben.roessler@canonical.com>
in the commit log.
That being said, since what you submitted here is what you proposed
upstream, I merged your patch as-is.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2026-10-21 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 19:38 [Buildroot] [PATCH v2 1/1] package/xmrig: Add support for OpenSSL 4.0.0 Bernd Kuhls
2026-10-21 20:36 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atkh3QrH-OV8tcnA@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.