All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Henning P. Schmiedehausen" <hps@intermeta.de>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix for RPM build target under newer versions
Date: Tue, 17 Dec 2002 10:44:54 +0000 (UTC)	[thread overview]
Message-ID: <atmv76$20o$1@forge.intermeta.de> (raw)
In-Reply-To: 3DFEFF01.7040304@wnyip.net

peter <pvant67@wnyip.net> writes:

>--- /usr/src/linux-2.4.19/Makefile	2002-12-15 19:04:20.000000000 -0500
>+++ /home/pete/Makefile.new	2002-12-17 04:36:49.000000000 -0500
>@@ -567,5 +567,16 @@
> 	rm $(KERNELPATH) ; \
> 	cd $(TOPDIR) ; \
> 	. scripts/mkversion > .version ; \
>-	rpmbuild -ta $(TOPDIR)/../$(KERNELPATH).tar.gz ; \
>+
>+#	RedHat split the RPM build process into a separate
>+#	utility called "rpmbuild", leading to a broken 
>+#	"make rpm" target in the kernel Makefile;
>+#	this patch fixes that.
>+
>+	if [ `rpm --version | cut -b 12-15 | tr -d .` -ge '41' ] ;
>+		then
>+		rpmbuild -ta $(TOPDIR)/../$(KERNELPATH).tar.gz ; \ 
>+		else
>+		rpm -ta $(TOPDIR)/../$(KERNELPATH).tar.gz ; \
>+	fi ; \

Ugh. How about

--- cut ---
RPM=`which rpmbuild`
if [ -z "$RPM" ]; then
  RPM=rpm
fi
$RPM -ta $(TOPDIR)/../$(KERNELPATH).tar.gz
--- cut ---

Looks less fragile. On RH 7.3 (and RH 6.x with upgrades) you also have
a rpmbuild binary (but rpm still does building, this got deprecated
and later removed on 8.0).

	Regards
		Henning

-- 
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen       -- Geschaeftsfuehrer
INTERMETA - Gesellschaft fuer Mehrwertdienste mbH     hps@intermeta.de

Am Schwabachgrund 22  Fon.: 09131 / 50654-0   info@intermeta.de
D-91054 Buckenhof     Fax.: 09131 / 50654-20   

      reply	other threads:[~2002-12-17 10:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-17 10:40 [PATCH] fix for RPM build target under newer versions peter
2002-12-17 10:44 ` Henning P. Schmiedehausen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='atmv76$20o$1@forge.intermeta.de' \
    --to=hps@intermeta.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.