All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: "Michał Kopeć" <michal@nozomi.space>
Cc: Yidi Lin <yidilin@google.com>,
	Hsin-Te Yuan <yuanhsinte@chromium.org>,
	Brian Norris <briannorris@chromium.org>,
	Julius Werner <jwerner@chromium.org>,
	chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: coreboot: Don't skip CBMEM entries outside of known memory
Date: Thu, 22 Oct 2026 08:35:25 +0000	[thread overview]
Message-ID: <atnKzXmotubTRp89@google.com> (raw)
In-Reply-To: <20261017090351.1266064-1-michal@nozomi.space>

On Sat, Oct 17, 2026 at 11:03:51AM +0200, Michał Kopeć wrote:
> coreboot leaves CBMEM out of the /memory node of the device tree that it
> passes to FIT payloads, e.g. LinuxBoot on arm64 Chromebooks, and only
> lists it in the memory reservation block. The kernel has no resource for
> that memory, so region_intersects() reports it as neither System RAM nor
> Reserved memory, and since commit e31ecda9e3af ("firmware: coreboot:
> Skip no-map CBMEM entries") all CBMEM entries are skipped on such boards.
> That loses the coreboot log, the TPM event log and everything else that
> CBMEM devices expose.
> 
> Also accept entries that don't intersect any memory resource. No-map
> regions are still skipped, as they are IORESOURCE_MEM resources, as are
> device regions.
> 
> Fixes: e31ecda9e3af ("firmware: coreboot: Skip no-map CBMEM entries")
> Signed-off-by: Michał Kopeć <michal@nozomi.space>

Thank you for your patch.  I'll queue this after -rc1 and send it as a
fix.

      reply	other threads:[~2026-10-22  8:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-17  9:03 [PATCH] firmware: coreboot: Don't skip CBMEM entries outside of known memory Michał Kopeć
2026-10-22  8:35 ` Tzung-Bi Shih [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atnKzXmotubTRp89@google.com \
    --to=tzungbi@kernel.org \
    --cc=briannorris@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=jwerner@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal@nozomi.space \
    --cc=yidilin@google.com \
    --cc=yuanhsinte@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.